GNU bug report logs - #60808
[PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60808 in the body.
You can then email your comments to 60808 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution
Date: Sat, 14 Jan 2023 03:02:15 -0500

Rather than assume such coarse delays, re-use existing logic for
probing the current filesystem resolution.  This speeds up the
testsuite significantly.  On my system, it speeds -j1 up quite a
lot -- by ~30%.  While I didn't gather many samples to produce a
statistically significant distribution, my runs seem to be fairly
consistent with the values below with deviations of <1 minute.

$ time make -j1
    Before                After
real  33m17.182s      real  23m33.557s
user  12m12.145s      user  12m12.763s
sys   1m52.308s       sys   1m52.853s

$ time make -j32
    Before                After
real  1m35.874s       real  1m4.908s
user  14m24.664s      user  15m58.663s
sys   2m9.297s        sys   2m27.393s

* configure.ac: Set test delays to am_cv_filesystem_timestamp_resolution.
---
 configure.ac | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index dcf2d95566a0..d3a67d5ffec9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -172,15 +172,7 @@ result=no
 test "x$am_cv_prog_ln" = xln && result=yes
 AC_MSG_RESULT([$result])
 
-# The amount we should wait after modifying files depends on the platform.
-# On Windows '95, '98 and ME, files modifications have 2-seconds
-# granularity and can be up to 3 seconds in the future w.r.t. the
-# system clock.  When it is important to ensure one file is older
-# than another we wait at least 5 seconds between creations.
-case $build in
-  *-pc-msdosdjgpp) MODIFICATION_DELAY=5;;
-  *)               MODIFICATION_DELAY=2;;
-esac
+MODIFICATION_DELAY=$am_cv_filesystem_timestamp_resolution
 AC_SUBST([MODIFICATION_DELAY])
 
 ## ------------------------------------------- ##
-- 
2.39.0

Message #8 received at 60808 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60808 <at> debbugs.gnu.org
Subject: Re: [bug#60808] [PATCH 2/2] tests: reuse
 am_cv_filesystem_timestamp_resolution
Date: Sat, 14 Jan 2023 14:52:44 -0700

    -case $build in
    -  *-pc-msdosdjgpp) MODIFICATION_DELAY=5;;
    -  *)               MODIFICATION_DELAY=2;;
    -esac
    +MODIFICATION_DELAY=$am_cv_filesystem_timestamp_resolution

Looks fantastic to me :). --thanks, karl.

Message #11 received at 60808 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60808 <at> debbugs.gnu.org
Subject: Re: [bug#60808] [PATCH 2/2] tests: reuse
 am_cv_filesystem_timestamp_resolution
Date: Fri, 14 Jul 2023 09:52:41 -0600

Hi Mike,

    +MODIFICATION_DELAY=$am_cv_filesystem_timestamp_resolution

I belatedly installed this patch. (I thought you already had.)
Thanks!

2023-07-14  Mike Frysinger  <vapier <at> gentoo.org>

automake: set test delays to am_cv_filesystem_timestamp_resolution.

This patch is from https://bugs.gnu.org/60808.

* configure.ac: Set test delays to
am_cv_filesystem_timestamp_resolution, instead of hardwiring
5sec on DJGPP and 2sec elsewhere. This speeds up test runs
significantly, informally as much 30%.
diff --git a/configure.ac b/configure.ac
index f78ec5153..23a9f97f5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -177,15 +177,7 @@ result=no
 test "x$am_cv_prog_ln" = xln && result=yes
 AC_MSG_RESULT([$result])

-# The amount we should wait after modifying files depends on the platform.
-# On Windows '95, '98 and ME, files modifications have 2-seconds
-# granularity and can be up to 3 seconds in the future w.r.t. the
-# system clock.  When it is important to ensure one file is older
-# than another we wait at least 5 seconds between creations.
-case $build in
-  *-pc-msdosdjgpp) MODIFICATION_DELAY=5;;
-  *)               MODIFICATION_DELAY=2;;
-esac
+MODIFICATION_DELAY=$am_cv_filesystem_timestamp_resolution
 AC_SUBST([MODIFICATION_DELAY])

 ## ------------------------------------------- ##

compile finished at Fri Jul 14 08:45:18 2023

Message #16 received at 60808-done <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: 60808-done <at> debbugs.gnu.org
Date: Fri, 14 Jul 2023 10:20:11 -0600

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.