GNU bug report logs -
#32800
t/silent-custom fails for certain parent directory sequences
Previous Next
Reported by: Frank Schaefer <kelledin <at> gmail.com>
Date: Sat, 22 Sep 2018 00:44:02 UTC
Severity: normal
Tags: confirmed
Done: Mike Frysinger <vapier <at> gentoo.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32800 in the body.
You can then email your comments to 32800 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-automake <at> gnu.org
:
bug#32800
; Package
automake
.
(Sat, 22 Sep 2018 00:44:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Frank Schaefer <kelledin <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
bug-automake <at> gnu.org
.
(Sat, 22 Sep 2018 00:44:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
I just discovered that t/silent-custom can fail if any parent of the
build directory matches the "[012]\.h" regex. Specifically, the 'grep
'[012]\.h' output && exit 1' command triggers a test failure.
(If you're wondering, one of my CI build-boxes just happened to kick
off a build in a '/var/tmp/.build.automake_1.16.1-0.hzA5PJ' tmpdir.)
Maybe refine this regex to " sub/[012]\.h"?
Added tag(s) confirmed.
Request was from
Mike Frysinger <vapier <at> gentoo.org>
to
control <at> debbugs.gnu.org
.
(Thu, 24 Feb 2022 05:58:02 GMT)
Full text and
rfc822 format available.
Reply sent
to
Mike Frysinger <vapier <at> gentoo.org>
:
You have taken responsibility.
(Thu, 24 Feb 2022 05:58:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Frank Schaefer <kelledin <at> gmail.com>
:
bug acknowledged by developer.
(Thu, 24 Feb 2022 05:58:02 GMT)
Full text and
rfc822 format available.
Message #12 received at 32800-done <at> debbugs.gnu.org (full text, mbox):
Fixes automake bug https://bugs.gnu.org/32800.
Have the regex match the entire path with word boundaries on both
sides. This should reduce false positives when the full cwd happens
to match parent directories.
* t/silent-custom.sh: Update the header output regex.
---
t/silent-custom.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/silent-custom.sh b/t/silent-custom.sh
index 01cf464b99eb..977255b1312e 100644
--- a/t/silent-custom.sh
+++ b/t/silent-custom.sh
@@ -74,7 +74,7 @@ do_check ()
$FGREP 'cp ' output && exit 1
$FGREP 'generate-header' output && exit 1
$FGREP 'rm -f' output && exit 1
- grep '[012]\.h' output && exit 1
+ grep '\bsub/[012]\.h\b' output && exit 1
grep '^ XGEN foo$' output
grep '^ GEN \[headers\]$' output
else
--
2.34.1
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 24 Mar 2022 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 40 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.