GNU bug report logs - #26647
Upgrade fabric to 1.13.2, remove upstreamed patch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26647 in the body.
You can then email your comments to 26647 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: guix-patches <at> gnu.org
Subject: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 25 Apr 2017 12:40:36 +1000

[Message part 1 (text/plain, inline)]

Hi Folks,

The attached patch upgrades fabric from 1.13.1 to 1.13.2. The new
upstream version incorporates the patch that was previously required for
tests to pass. Yay!

Regards,
Ben

-- 
Ben Sturmfels

Sturm - Software Engineering
www.sturm.com.au
(03) 9024 2467

[0001-gnu-fabric-Update-to-1.13.2.patch (text/x-patch, inline)]

From c7fb9e66f90acba2ea644600a039ffe31310b2d4 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben <at> sturm.com.au>
Date: Tue, 25 Apr 2017 12:15:43 +1000
Subject: [PATCH] gnu: fabric: Update to 1.13.2.
To: guix-patches <at> gnu.org

* gnu/packages/patches/fabric-tests.patch: Remove.
* gnu/local.mk (dist_patch_DATA): Remove patch.
* gnu/packages/admin.scm (fabric)[source]: Update to 1.13.2
[patches]: Remove as the patch is now included upstream.
---
 gnu/local.mk                            |  1 -
 gnu/packages/admin.scm                  |  5 ++---
 gnu/packages/patches/fabric-tests.patch | 15 ---------------
 3 files changed, 2 insertions(+), 19 deletions(-)
 delete mode 100644 gnu/packages/patches/fabric-tests.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index cb94d27e9..fd29c04e3 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -554,7 +554,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/eudev-conflicting-declaration.patch	\
   %D%/packages/patches/evilwm-lost-focus-bug.patch		\
   %D%/packages/patches/expat-CVE-2016-0718-fix-regression.patch	\
-  %D%/packages/patches/fabric-tests.patch			\
   %D%/packages/patches/fastcap-mulGlobal.patch			\
   %D%/packages/patches/fastcap-mulSetup.patch			\
   %D%/packages/patches/fasthenry-spAllocate.patch		\
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 8f4a4cd41..f541481cb 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2053,15 +2053,14 @@ Intel DRM Driver.")
 (define-public fabric
   (package
     (name "fabric")
-    (version "1.13.1")
+    (version "1.13.2")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "Fabric" version))
        (sha256
         (base32
-         "1z17hw0yiqp1blq217zxkg2jzkv8qd79saqhscgsw14mwlcqpwd0"))
-       (patches (search-patches "fabric-tests.patch"))))
+         "0k944dxr41whw7ib6380q9x15wyskx7fqni656icdn8rzshn9bwq"))))
     (build-system python-build-system)
     (arguments
      `(#:python ,python-2))                       ;Python 2 only
diff --git a/gnu/packages/patches/fabric-tests.patch b/gnu/packages/patches/fabric-tests.patch
deleted file mode 100644
index 4a0ca9f8f..000000000
--- a/gnu/packages/patches/fabric-tests.patch
+++ /dev/null
@@ -1,15 +0,0 @@
-The `fab` excecutable doesn't exist during the test phase as it is created
-dynamically during installation. Refer to the equivalent Python module
-directly.
-
---- a/tests/test_utils.py
-+++ b/tests/test_utils.py
-@@ -93,7 +93,7 @@
-     # perform when they are allowed to bubble all the way to the top. So, we
-     # invoke a subprocess and look at its stderr instead.
-     with quiet():
--        result = local("fab -f tests/support/aborts.py kaboom", capture=True)
-+        result = local("python -m fabric -f tests/support/aborts.py kaboom", capture=True)
-     # When error in #1318 is present, this has an extra "It burns!" at end of
-     # stderr string.
-     eq_(result.stderr, "Fatal error: It burns!\n\nAborting.")
\ No newline at end of file
-- 
2.12.2

Message #8 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ben Sturmfels <ben <at> sturm.com.au>
Cc: 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 25 Apr 2017 15:18:41 +0200

Hi Ben,

> The attached patch upgrades fabric from 1.13.1 to 1.13.2. The new
> upstream version incorporates the patch that was previously required for
> tests to pass. Yay!

I have tried your patch but the tests seem to time out at this point:

    Alias expansion ... ok
    test_tasks.TestExecute.test_calls_task_function_objects
    should execute the passed-in function object ... ok
    test_tasks.TestExecute.test_nested_execution_with_explicit_ports
    nested executions should work with defined ports
    *crickets*

After about an hour I aborted the build.  Is this test supposed to take
a very long time?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #11 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: "Ricardo Wurmus" <rekado <at> elephly.net>
Cc: 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Wed, 26 Apr 2017 10:26:21 +1000

On Tue, 25 Apr 2017, Ricardo Wurmus wrote:

> Hi Ben,
>
>> The attached patch upgrades fabric from 1.13.1 to 1.13.2. The new
>> upstream version incorporates the patch that was previously required for
>> tests to pass. Yay!
>
> I have tried your patch but the tests seem to time out at this point:
>
>     Alias expansion ... ok
>     test_tasks.TestExecute.test_calls_task_function_objects
>     should execute the passed-in function object ... ok
>     test_tasks.TestExecute.test_nested_execution_with_explicit_ports
>     nested executions should work with defined ports
>     *crickets*
>
> After about an hour I aborted the build.  Is this test supposed to take
> a very long time?

Ow, that's a shame. The tests run fine for me, but I see that Debian
have this test disabled as it runs indefinitely on a single-core VM.
I'll look at disabling this test too.

Regards,
Ben

Message #14 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ben Sturmfels <ben <at> sturm.com.au>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Sat, 02 Sep 2017 00:48:34 +0200

Hi Ben,

Ben Sturmfels <ben <at> sturm.com.au> skribis:

> On Tue, 25 Apr 2017, Ricardo Wurmus wrote:
>
>> Hi Ben,
>>
>>> The attached patch upgrades fabric from 1.13.1 to 1.13.2. The new
>>> upstream version incorporates the patch that was previously required for
>>> tests to pass. Yay!
>>
>> I have tried your patch but the tests seem to time out at this point:
>>
>>     Alias expansion ... ok
>>     test_tasks.TestExecute.test_calls_task_function_objects
>>     should execute the passed-in function object ... ok
>>     test_tasks.TestExecute.test_nested_execution_with_explicit_ports
>>     nested executions should work with defined ports
>>     *crickets*
>>
>> After about an hour I aborted the build.  Is this test supposed to take
>> a very long time?
>
> Ow, that's a shame. The tests run fine for me, but I see that Debian
> have this test disabled as it runs indefinitely on a single-core VM.
> I'll look at disabling this test too.

Did you have a chance to look into this?
(See <https://bugs.gnu.org/26647> for context.)

Thanks,
Ludo’.

Message #17 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Wed, 06 Sep 2017 10:54:38 +1000

On Sat, 02 Sep 2017, Ludovic Courtès wrote:

> Did you have a chance to look into this?
> (See <https://bugs.gnu.org/26647> for context.)

Thanks for the reminder! I've been away for a bit, but this is still on
my to-do list.

Regards,
Ben

-- 
Ben Sturmfels

Sturm Software Engineering
www.sturm.com.au
(03) 9024 2467

Message #20 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26647 <at> debbugs.gnu.org,
 Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 07 Nov 2017 23:54:29 +1100

[Message part 1 (text/plain, inline)]

On Wed, 06 Sep 2017, Ben Sturmfels wrote:

> On Sat, 02 Sep 2017, Ludovic Courtès wrote:
>
>> Did you have a chance to look into this?
>> (See <https://bugs.gnu.org/26647> for context.)

It looks like Tobias beat me to the fabric 1.13.2 upgrade in f58be417 -
thanks Tobias! But the build hanging issue Ricardo mentioned still
remains. Should be fixed by the attached patch.

I've re-added the "Requires < X.X" comments as I think these will help
anyone trying to debug build problems if/when these dependencies are
upgraded.

If that's all ok, I can look at the upgrade to 0.14.0 in a separate patch.

Regards,
Ben

--
Ben Sturmfels

Sturm - Software Engineering
www.sturm.com.au
(03) 9024 2467

[0001-gnu-fabric-Disable-problematic-tests.patch (text/x-patch, inline)]

From 1a88d0aede4aee911617dc4ad5359d43a1193f22 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben <at> sturm.com.au>
Date: Tue, 7 Nov 2017 23:37:38 +1100
Subject: [PATCH] gnu: fabric: Disable problematic tests.

* gnu/packages/admin.scm (fabric): Add custom check phase to disable two tests.
---
 gnu/packages/admin.scm | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 7b8e41fce..dcc5ecbff 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2122,11 +2122,24 @@ Intel DRM Driver.")
          "0k944dxr41whw7ib6380q9x15wyskx7fqni656icdn8rzshn9bwq"))))
     (build-system python-build-system)
     (arguments
-     `(#:python ,python-2))             ; Python 2 only
+     `(#:python ,python-2               ; Python 2 only
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (zero?
+              (system*
+               "nosetests" "-v" "tests/"
+               ;; This test hangs indefinitely when run on a single core VM
+               ;; (see GNU bug #26647 and Debian bug #850230).
+               "--exclude=test_nested_execution_with_explicit_ports"
+               ;; This test randomly fails in certain environments causing too
+               ;; much noise to be useful (see Debian bug #854686).
+               "--exclude=test_should_use_sentinel_for_tasks_that_errored")))))))
     (native-inputs
-     `(("python2-fudge" ,python2-fudge)
-       ("python2-jinja2" ,python2-jinja2)
-       ("python2-nose" ,python2-nose)))
+     `(("python2-fudge" ,python2-fudge) ; Requires < 1.0
+       ("python2-jinja2" ,python2-jinja2) ; Requires < 3.0
+       ("python2-nose" ,python2-nose))) ; Requires < 2.0
     (propagated-inputs
      `(("python2-paramiko" ,python2-paramiko)))
     (home-page "http://fabfile.org")
-- 
2.14.2

Message #23 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Wed, 08 Nov 2017 00:21:33 +1100

By the way, can anyone tell me why the message I sent to Debbugs a
couple of minutes ago is hidden by default on the web interface, only
shown as an "Information forwarded" line when I click:

  "Toggle the display of automated, internal messages from the tracker."

Am I doing something wrong?

Regards,
Ben

Message #26 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Wed, 08 Nov 2017 00:24:12 +1100

Oh, I was just being too impatient. Now that I refresh 10 mins later,
the message shows up properly.

Regards,
Ben

Message #29 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ben Sturmfels <ben <at> sturm.com.au>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 07 Nov 2017 14:46:26 +0100

Ben Sturmfels <ben <at> sturm.com.au> writes:

> But the build hanging issue Ricardo mentioned still
> remains. Should be fixed by the attached patch.

Thanks.  The patch looks good to me.

> I've re-added the "Requires < X.X" comments as I think these will help
> anyone trying to debug build problems if/when these dependencies are
> upgraded.

Yes, that’s a good idea.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #32 received at 26647 <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 26647 <at> debbugs.gnu.org
Subject: Re: bug#26647: Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Sat, 02 Dec 2017 11:06:21 +1100

[Message part 1 (text/plain, inline)]

On Tue, 07 Nov 2017, Ricardo Wurmus wrote:

> Ben Sturmfels <ben <at> sturm.com.au> writes:
>
>> But the build hanging issue Ricardo mentioned still
>> remains. Should be fixed by the attached patch.
>
> Thanks.  The patch looks good to me.

I've attached an updated patch updating to Fabric 1.14.0. If it's
preferable to do the update separately to the test fix, feel free to
merge the previous patch in this thread and I’ll send the upgrade patch
separately.

(Ricardo: Sorry for the extra email - just learning emacs-debbugs!)

Regards,
Ben

[0001-gnu-fabric-Update-to-1.14.0-and-disable-problematic-.patch (text/x-patch, inline)]

From a5f28bdc67c4427cfcf213fb288c811ba3e0788c Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben <at> sturm.com.au>
Date: Tue, 7 Nov 2017 23:37:38 +1100
Subject: [PATCH] gnu: fabric: Update to 1.14.0 and disable problematic tests.

* gnu/packages/admin.scm (fabric): Update to 1.14.0 and add custom check phase to disable two tests.
---
 gnu/packages/admin.scm | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index d4215ead1..44884a0bb 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2115,21 +2115,34 @@ Intel DRM Driver.")
 (define-public fabric
   (package
     (name "fabric")
-    (version "1.13.2")
+    (version "1.14.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "Fabric" version))
        (sha256
         (base32
-         "0k944dxr41whw7ib6380q9x15wyskx7fqni656icdn8rzshn9bwq"))))
+         "13r0b0hllgf8j9rh6x1knmbgvingbdmx046aazv6vck2ll120mw1"))))
     (build-system python-build-system)
     (arguments
-     `(#:python ,python-2))             ; Python 2 only
+     `(#:python ,python-2               ; Python 2 only
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (zero?
+              (system*
+               "nosetests" "-v" "tests/"
+               ;; This test hangs indefinitely when run on a single core VM
+               ;; (see GNU bug #26647 and Debian bug #850230).
+               "--exclude=test_nested_execution_with_explicit_ports"
+               ;; This test randomly fails in certain environments causing too
+               ;; much noise to be useful (see Debian bug #854686).
+               "--exclude=test_should_use_sentinel_for_tasks_that_errored")))))))
     (native-inputs
-     `(("python2-fudge" ,python2-fudge)
-       ("python2-jinja2" ,python2-jinja2)
-       ("python2-nose" ,python2-nose)))
+     `(("python2-fudge" ,python2-fudge) ; Requires < 1.0
+       ("python2-jinja2" ,python2-jinja2) ; Requires < 3.0
+       ("python2-nose" ,python2-nose))) ; Requires < 2.0
     (propagated-inputs
      `(("python2-paramiko" ,python2-paramiko)))
     (home-page "http://fabfile.org")
-- 
2.15.0

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 26647-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Ben Sturmfels <ben <at> sturm.com.au>
Cc: 26647-done <at> debbugs.gnu.org
Subject: Re: [bug#26647] Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Sun, 10 Jun 2018 13:18:34 +0800

Ben Sturmfels <ben <at> sturm.com.au> writes:

> From a5f28bdc67c4427cfcf213fb288c811ba3e0788c Mon Sep 17 00:00:00 2001
> From: Ben Sturmfels <ben <at> sturm.com.au>
> Date: Tue, 7 Nov 2017 23:37:38 +1100
> Subject: [PATCH] gnu: fabric: Update to 1.14.0 and disable problematic tests.
>
> * gnu/packages/admin.scm (fabric): Update to 1.14.0 and add custom check phase to disable two tests.

Well, this patch no longer needed, as we already had fabric-1.14.0.

closing now, Thank you!

Message #42 received at 26647-done <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: 宋文武 <iyzsong <at> member.fsf.org>
Cc: 26647-done <at> debbugs.gnu.org
Subject: Re: [bug#26647] Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 12 Jun 2018 12:14:05 +1000

[Message part 1 (text/plain, inline)]

Hi 宋文武,



Ben Sturmfels

Sturm Software Engineering
www.sturm.com.au
(03) 9024 2467

On Sun, 10 Jun 2018, 宋文武 wrote:

> Ben Sturmfels <ben <at> sturm.com.au> writes:
>
>> From a5f28bdc67c4427cfcf213fb288c811ba3e0788c Mon Sep 17 00:00:00 2001
>> From: Ben Sturmfels <ben <at> sturm.com.au>
>> Date: Tue, 7 Nov 2017 23:37:38 +1100
>> Subject: [PATCH] gnu: fabric: Update to 1.14.0 and disable problematic tests.
>>
>> * gnu/packages/admin.scm (fabric): Update to 1.14.0 and add custom check phase to disable two tests.
>
> Well, this patch no longer needed, as we already had fabric-1.14.0.
>
> closing now, Thank you!

Thanks for following up on this. I believe that the patch to disable two
tests is still required though to address Ricardo's earlier issues with
tests timing out.

I've attached again without the upgrade to 0.14.0.

Regards,
Ben

[0002-gnu-fabric-Disable-problematic-tests.patch (text/x-patch, attachment)]

Message #49 received at 26647-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Ben Sturmfels <ben <at> sturm.com.au>
Cc: 26647-done <at> debbugs.gnu.org
Subject: Re: [bug#26647] Upgrade fabric to 1.13.2, remove upstreamed patch.
Date: Tue, 12 Jun 2018 19:51:00 +0800

Ben Sturmfels <ben <at> sturm.com.au> writes:

> On Sun, 10 Jun 2018, 宋文武 wrote:
>
>> Ben Sturmfels <ben <at> sturm.com.au> writes:
>>
>>> From a5f28bdc67c4427cfcf213fb288c811ba3e0788c Mon Sep 17 00:00:00 2001
>>> From: Ben Sturmfels <ben <at> sturm.com.au>
>>> Date: Tue, 7 Nov 2017 23:37:38 +1100
>>> Subject: [PATCH] gnu: fabric: Update to 1.14.0 and disable problematic tests.
>>>
>>> * gnu/packages/admin.scm (fabric): Update to 1.14.0 and add custom check phase to disable two tests.
>>
>> Well, this patch no longer needed, as we already had fabric-1.14.0.
>>
>> closing now, Thank you!
>
> Thanks for following up on this. I believe that the patch to disable two
> tests is still required though to address Ricardo's earlier issues with
> tests timing out.
>
> I've attached again without the upgrade to 0.14.0.
>

Oh, I think you're right, applied, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.