GNU bug report logs - #22443
new snapshot available: grep-2.22.29-83df

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22443 in the body.
You can then email your comments to 22443 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-grep <at> gnu.org
Cc: TP coordinator <coordinator <at> translationproject.org>,
 platform-testers <at> gnu.org
Subject: new snapshot available: grep-2.22.29-83df
Date: Sat, 23 Jan 2016 18:34:48 +0800

We would like to make a new bug-fix-only release of grep soon,
so here is a snapshot of the latest sources. Please build and
test on whatever systems you can find, and let us know how
that goes -- reports of success are welcome, too.

grep snapshot:
  http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
  http://meyering.net/grep/grep-ss.tar.xz.sig
  http://meyering.net/grep/grep-2.22.29-83df.tar.xz

Here are the NEWS entries:

** Bug fixes

  Binary files are now less likely to generate diagnostics and more
  likely to yield text matches.  grep now reports "Binary file FOO
  matches" and suppresses further output instead of outputting a line
  containing an encoding error; hence grep can now report matching text
  before a later binary match.  Formerly, grep reported FOO to be
  binary when it found an encoding error in FOO before generating
  output for FOO, which meant it never reported both matching text and
  matching binary data; this was less useful for searching text
  containing encoding errors in non-matching lines.
  [bug introduced in grep-2.21]

  grep -c no longer stops counting when finding binary data.
  [bug introduced in grep-2.21]

  grep no longer outputs encoding errors in unibyte locales.
  For example, if the byte '\x81' is not a valid character in a
  unibyte locale, grep treats the byte as binary data.
  [bug introduced in grep-2.21]

  grep -oP is no longer susceptible to an infinite loop when processing
  invalid UTF8 just before a match.
  [bug introduced in grep-2.22]

  --exclude and related options are now matched against trailing
  parts of command-line arguments, not against the entire arguments.
  This partly reverts the --exclude-related change in 2.22.
  [bug introduced in grep-2.22]

  --line-buffer is no longer ineffective when combined with -l.
  [bug introduced in grep-2.5]

  -xw is now equivalent to -x more consistently, with -P and with backrefs.
  [bug only partially fixed in grep-2.19]


More detailed changes in grep since v2.22:

Jim Meyering (9):
      maint: post-release administrivia
      tests: mark performance-related tests as expensive
      grep -oP: don't infloop when processing invalid UTF8 preceding a match
      maint: correct (make sorted) order of test file names
      maint: update copyright year, bootstrap, init.sh
      mb-non-UTF8-performance: avoid FP test failure on fast hardware
      tests: fix encoding-error test failure to use of printf '\xHH'
      tests: do use "yes" but via an AWK replacement
      maint: fix typo in NEWS: s/a/an/

Paul Eggert (20):
      grep: --exclude matches trailing parts of args
      grep: be less picky about encoding errors
      dfa: port to tinycc
      grep: -c should keep counting after binary data
      grep: report line-buffered write error right away
      grep: remove duplicate init
      grep: fix -l --line-buffer bug
      doc: minor clarifications
      doc: clarify text vs binary match output
      grep: fix bug with with invalid unibyte sequence
      Fix calculation of unibyte_mask
      grep: restore -P PCRE_NO_UTF8_CHECK optimization
      grep: restore -P optimization (followup fix)
      Improve on fix for Bug#22181
      grep: improve unibyte -P performance
      doc: mention unibyte encoding fix
      tests: port to other POSIXish platforms
      * tests/pcre-count: Don't assume the page size is 32kB.
      tests: omit update-copyright-tests
      grep: -x now supersedes -w more consistently


Changes in gnulib since v2.22:

* gnulib 956fa54...271dfe3 (45):
  > autoupdate
  > tests: for compare_(), use cmp -s where available
  > version-etc: new year
  > human: fix output buffer overrun by 1
  > autoupdate
  > maint: add missing ChangeLog entry for previous commit
  > maint: fix operator precedence in mbrtowc test
  > autoupdate
  > regexprops-generic: update from regex.h
  > strftime-tests: avoid false failure on OS X
  > update from texinfo
  > fts: ensure leaf optimization is used for NFS
  > fts: enable leaf optimization for XFS
  > non-recursive-gnulib-prefix-hack: preserve V_GPERF lines
  > intprops: comment fix
  > update from texinfo
  > intprops-test: work around GCC bug 68971
  > autoupdate
  > gnulib-tool: allow multiple --local-dir usage
  > fix freadptr to work with ungetc on all uClibc configs
  > update from texinfo
  > autoupdate
  > parse-datetime: relax license to LGPLv2+, for OSTree
  > update from texinfo
  > autoupdate
  > autoupdate
  > update from texinfo
  > xalloc-oversized: improve performance with GCC 5
  > intprops: new public macro EXPR_SIGNED
  > intprops: fix typo in clang port
  > test-timespec: fix typo in previous change
  > timespec-sub: fix overflow bug; add tests
  > intprops-test: suppress -Woverlength-strings
  > maint: add missing ChangeLog entry for previous commit
  > quotearg: add quotearg_n_style_colon()
  > intprops: revise _WRAPV macros, revert _OVERFLOW
  > intprops: add parentheses for when OP has precedence lower than "-"
  > quotearg: constify get_quoting_style parameters
  > quotearg: add support for $'' shell escaping
  > maint: use a more standard return from mbrtowc test
  > intprops: add WRAPV and const flavors for GCC 5
  > doc: use extended timezone format in iso-8601 example
  > update from texinfo
  > update from texinfo
  > update from texinfo

Message #8 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 22443 <at> debbugs.gnu.org
Cc: TP coordinator <coordinator <at> translationproject.org>,
 platform-testers <at> gnu.org
Subject: new snapshot available: grep-2.22.30-e07b
Date: Sun, 24 Jan 2016 12:42:37 +0800

On Sat, Jan 23, 2016 at 6:34 PM, Jim Meyering <jim <at> meyering.net> wrote:
> We would like to make a new bug-fix-only release of grep soon,
> so here is a snapshot of the latest sources. Please build and
> test on whatever systems you can find, and let us know how
> that goes -- reports of success are welcome, too.
> ...

That snapshot did not include a couple weeks worth of gnulib
changes, several of which matter to grep, so I've updated to pull
them and and made a new snapshot:

grep snapshot:
  http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
  http://meyering.net/grep/grep-ss.tar.xz.sig
  http://meyering.net/grep/grep-2.22.30-e07b.tar.xz

Changes in grep since 2.22.29-83df:

Jim Meyering (1):
      gnulib: update to latest


Changes in gnulib since 2.22.29-83df:

* gnulib 271dfe3...0fce642 (34):
  > @item needed inside @itemize
  > hash-pjw-bare: fix comment
  > wcwidth: Replace also on OpenBSD 5.8
  > update from texinfo
  > gnu-web-doc-update: fix addition of new files
  > utimens-tests: avoid pulling gettext .m4 files
  > regex: pacify static checkers
  > regex: fix [ diagnostic
  > regex: fix memory leaks
  > fts: don't unconditionally use leaf optimization for NFS
  > * gnulib-tool: fix stray debug line in previous patch
  > gnulib-tool: don't assume ln -s works
  > utimes: detect utimes() correctly on OS/2 kLIBC
  > openat_proc_name: port to OS/2 kLIBC
  > stdint: check _INTPTR_T_DECLARED for intptr_t etc.
  > doc: mention unfixed issues with unsupported localtime() values
  > Go back to gettext-0.19.7
  > opendir, closedir, dirfd, fdopendir: port to OS/2 kLIBC
  > dup, dup2, fcntl: support a directory fd on OS/2 kLIBC
  > pipe_filter_ii_execute: port to OS/2 kLIBC
  > wchar: fix "conflicting types" error for __wcwidth on OS/2 kLIBC
  > w32spawn: clear SHELL_SPECIAL_CHARS and SHELL_SPACE_CHAR on OS/2 kLIBC
  > pipe-filter-aux: undefine HAVE_SELECT on KLIBC
  > binary-io: don't put fd in binary mode if it is a console on EMX
  > doc: mention setlocale() issues on OpenBSD
  > sig2str: list all signals on FreeBSD >= 7
  > acl-permissions: port to USE_ACL==0 platforms
  > mktime: rename macro to avoid glibc clash
  > Port "$@" to OpenIndiana ksh93
  > autoupdate
  > Port Universal Time settings to strict POSIX
  > update from texinfo
  > update from texinfo
  > msvc-inval: fix problem with unset shell var

Message #11 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.30-e07b
Date: Sun, 24 Jan 2016 00:22:55 -0500

Hello,

> On Jan 23, 2016, at 23:42, Jim Meyering <jim <at> meyering.net> wrote:
> 
> grep snapshot:
>  http://meyering.net/grep/grep-2.22.30-e07b.tar.xz

One regression for 2.22.30 vs 2.22.29 on OpenSolaris 5.10, both x86pc and sun4v,
possibly related to this machine having an older shell:

   $ ./configure
   ...
   ...
   checking whether btowc(EOF) is correct... yes
   checking whether this system has an arbitrary file name length limit... yes
   checking for closedir... yes
   ./configure: bad substitution

Running diff on 'configure' between versions 2.22.29 and 2.22.30, this might be the culprit:
===
@@ -19138,6 +19140,11 @@ done
       fi
     fi
 
+    if test -z "${host_os##os2*}"; then
+    if test $HAVE_OPENDIR = 1; then
+      REPLACE_OPENDIR=1
+    fi
+  fi
 
   if test $HAVE_CLOSEDIR = 0 || test $REPLACE_CLOSEDIR = 1; then
===

Trying to isolate it, gives (on that OpenSolaris 5.10 i86pc machine):
===
  $ cat 1.sh                                           
  #!/bin/sh
  test -z "${host_os##os2*}"

  $ ./1.sh
  ./1.sh: bad substitution
===

Just a guess, but perhaps the recent OS/2 patches to gnulib are the source (since 29 vs 30's difference is updated gnulib).

=====


No failures on:
 Mac OS X 10.10.4
 Open Solaris 5.11 both i86pc and sun4v/u
 FreeBSD 10.1, 9.3 (amd64)
 OpenBSD 5.8, 5.7 (amd64)
 NetBD 7.0 (amd64)
 Various GNU/Linuxes on x86-66
  (Debian 7/8, CentOS 7,6.5, Ubuntu 14.04,15.04, Fedora 23,22,21, OpenSUSE 42.1)


regards,
 - assaf

Message #14 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Assaf Gordon <assafgordon <at> gmail.com>, Jim Meyering <jim <at> meyering.net>
Cc: 22443 <at> debbugs.gnu.org, KO Myung-Hun <komh <at> chollian.net>,
 Gnulib bugs <bug-gnulib <at> gnu.org>
Subject: Re: bug#22443: new snapshot available: grep-2.22.30-e07b
Date: Sun, 24 Jan 2016 00:31:45 -0800

[Message part 1 (text/plain, inline)]

Assaf Gordon wrote:
> Trying to isolate it, gives (on that OpenSolaris 5.10 i86pc machine):
> ===
>    $ cat 1.sh
>    #!/bin/sh
>    test -z "${host_os##os2*}"
>
>    $ ./1.sh
>    ./1.sh: bad substitution
> ===
>
> Just a guess, but perhaps the recent OS/2 patches to gnulib are the source

Thanks for the diagnosis; your guess is correct. Apparently OpenSolaris is still 
using the old SunOS /bin/sh, which doesn't support parameter substitution with # 
or % operators, and the test that 'configure' uses for shells (generated by 
Autoconf) doesn't catch this POSIX incompatibility.

I installed the attached patch into gnulib, which should fix this problem when 
grep gets the latest gnulib version. Using traditional 'case' is easier to read 
for this sort of thing anyway.

[0001-closedir-dirfd-opendir-port-to-OpenSolaris-5.10.patch (text/x-diff, attachment)]

Message #17 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22443 <at> debbugs.gnu.org, Assaf Gordon <assafgordon <at> gmail.com>,
 Gnulib bugs <bug-gnulib <at> gnu.org>, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#22443: new snapshot available: grep-2.22.30-e07b
Date: Sun, 24 Jan 2016 21:00:18 +0900

Hi/2.

Paul Eggert wrote:
> Assaf Gordon wrote:
>> Trying to isolate it, gives (on that OpenSolaris 5.10 i86pc machine):
>> ===
>>    $ cat 1.sh
>>    #!/bin/sh
>>    test -z "${host_os##os2*}"
>>
>>    $ ./1.sh
>>    ./1.sh: bad substitution
>> ===
>>
>> Just a guess, but perhaps the recent OS/2 patches to gnulib are the
>> source
> 
> Thanks for the diagnosis; your guess is correct. Apparently OpenSolaris
> is still using the old SunOS /bin/sh, which doesn't support parameter
> substitution with # or % operators, and the test that 'configure' uses
> for shells (generated by Autoconf) doesn't catch this POSIX
> incompatibility.
> 
> I installed the attached patch into gnulib, which should fix this
> problem when grep gets the latest gnulib version. Using traditional
> 'case' is easier to read for this sort of thing anyway.
> 
> 0001-closedir-dirfd-opendir-port-to-OpenSolaris-5.10.patch
> 
> 
> From a93faea3bd057b0ef6d2dfdc1a98e24b057a229e Mon Sep 17 00:00:00 2001
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Sun, 24 Jan 2016 00:28:19 -0800
> Subject: [PATCH] closedir, dirfd, opendir: port to OpenSolaris 5.10
> 
> * m4/closedir.m4 (gl_FUNC_CLOSEDIR):
> * m4/dirfd.m4 (gl_FUNC_DIRFD):
> * m4/opendir.m4 (gl_FUNC_OPENDIR):
> Don't use ${word##pat} substitution, as it doesn't work in
> OpenSolaris 5.10 /bin/sh.  Problem reported by Assaf Gordon in:
> http://bugs.gnu.org/22443#11
> ---
>  ChangeLog      | 10 ++++++++++
>  m4/closedir.m4 | 11 +++++------
>  m4/dirfd.m4    | 14 ++++++--------
>  m4/opendir.m4  | 11 +++++------
>  4 files changed, 26 insertions(+), 20 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 839c222..2da850c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,13 @@
> +2016-01-24  Paul Eggert  <eggert <at> cs.ucla.edu>
> +
> +	closedir, dirfd, opendir: port to OpenSolaris 5.10
> +	* m4/closedir.m4 (gl_FUNC_CLOSEDIR):
> +	* m4/dirfd.m4 (gl_FUNC_DIRFD):
> +	* m4/opendir.m4 (gl_FUNC_OPENDIR):
> +	Don't use ${word##pat} substitution, as it doesn't work in
> +	OpenSolaris 5.10 /bin/sh.  Problem reported by Assaf Gordon in:
> +	http://bugs.gnu.org/22443#11
> +
>  2016-01-23  Paul Eggert  <eggert <at> cs.ucla.edu>
>  
>  	bootstrap: use American spelling
> diff --git a/m4/closedir.m4 b/m4/closedir.m4
> index 15a5cc8..e679694 100644
> --- a/m4/closedir.m4
> +++ b/m4/closedir.m4
> @@ -1,4 +1,4 @@
> -# closedir.m4 serial 3
> +# closedir.m4 serial 4
>  dnl Copyright (C) 2011-2016 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -23,9 +23,8 @@ AC_DEFUN([gl_FUNC_CLOSEDIR],
>      fi
>    ])
>    dnl Replace closedir() for supporting the gnulib-defined dirfd() function.
> -  if test -z "${host_os##os2*}"; then
> -    if test $HAVE_OPENDIR = 1; then
> -      REPLACE_OPENDIR=1
> -    fi
> -  fi
> +  case $host_os,$HAVE_OPENDIR in
> +    os2,1)
> +      REPLACE_OPENDIR=1;;
> +  esac
>  ])

Ooops... typos at the beginning... s/OPENDIR/CLOSEDIR/g

And s/os2/os2*/, please...

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Message #20 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 22443 <at> debbugs.gnu.org, Assaf Gordon <assafgordon <at> gmail.com>,
 Gnulib bugs <bug-gnulib <at> gnu.org>, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#22443: new snapshot available: grep-2.22.30-e07b
Date: Sun, 24 Jan 2016 14:16:50 -0800

[Message part 1 (text/plain, inline)]

KO Myung-Hun wrote:
> Ooops... typos at the beginning... s/OPENDIR/CLOSEDIR/g
>
> And s/os2/os2*/, please...

Thanks, I installed the attached followup patch.

[0001-closedir-fix-OS-2-related-typos.patch (text/x-diff, attachment)]

Message #23 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22443 <at> debbugs.gnu.org, Assaf Gordon <assafgordon <at> gmail.com>,
 Gnulib bugs <bug-gnulib <at> gnu.org>, KO Myung-Hun <komh78 <at> gmail.com>
Subject: Subject: new snapshot available: grep-2.22.31-8b6a
Date: Fri, 29 Jan 2016 09:36:01 +0900

Thanks, Paul!

I am ready to make a release, hoping this is it.
The only change since the preceding snapshot is the update to latest gnulib:

grep snapshot:
  http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
  http://meyering.net/grep/grep-ss.tar.xz.sig
  http://meyering.net/grep/grep-2.22.31-8b6a.tar.xz

Changes in grep since 2.22.30-e07b:

Jim Meyering (1):
      gnulib: update to latest


Changes in gnulib since 2.22.30-e07b:

* gnulib 271dfe3...7757cc8 (42):
  > get-permissions, strftime: fix grammar in comments
  > gettext: mark as obsolete
  > gnulib-tool: don't give up on ln -s so easily
  > closedir: fix OS/2-related typos
  > openat_proc_name: fix that last '/' is overwritten on OS/2 kLIBC
  > regex: treat [x] as x if x is a unibyte encoding error
  > closedir, dirfd, opendir: port to OpenSolaris 5.10
  > bootstrap: use American spelling
  > @item needed inside @itemize
  > hash-pjw-bare: fix comment
  > wcwidth: Replace also on OpenBSD 5.8
  > update from texinfo
  > gnu-web-doc-update: fix addition of new files
  > utimens-tests: avoid pulling gettext .m4 files
  > regex: pacify static checkers
  > regex: fix [ diagnostic
  > regex: fix memory leaks
  > fts: don't unconditionally use leaf optimization for NFS
  > * gnulib-tool: fix stray debug line in previous patch
  > gnulib-tool: don't assume ln -s works
  > utimes: detect utimes() correctly on OS/2 kLIBC
  > openat_proc_name: port to OS/2 kLIBC
  > stdint: check _INTPTR_T_DECLARED for intptr_t etc.
  > doc: mention unfixed issues with unsupported localtime() values
  > Go back to gettext-0.19.7
  > opendir, closedir, dirfd, fdopendir: port to OS/2 kLIBC
  > dup, dup2, fcntl: support a directory fd on OS/2 kLIBC
  > pipe_filter_ii_execute: port to OS/2 kLIBC
  > wchar: fix "conflicting types" error for __wcwidth on OS/2 kLIBC
  > w32spawn: clear SHELL_SPECIAL_CHARS and SHELL_SPACE_CHAR on OS/2 kLIBC
  > pipe-filter-aux: undefine HAVE_SELECT on KLIBC
  > binary-io: don't put fd in binary mode if it is a console on EMX
  > doc: mention setlocale() issues on OpenBSD
  > sig2str: list all signals on FreeBSD >= 7
  > acl-permissions: port to USE_ACL==0 platforms
  > mktime: rename macro to avoid glibc clash
  > Port "$@" to OpenIndiana ksh93
  > autoupdate
  > Port Universal Time settings to strict POSIX
  > update from texinfo
  > update from texinfo
  > msvc-inval: fix problem with unset shell var

Message #26 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>
Cc: 22443 <at> debbugs.gnu.org, Gnulib bugs <bug-gnulib <at> gnu.org>,
 KO Myung-Hun <komh78 <at> gmail.com>
Subject: Re: bug#22443: Subject: new snapshot available: grep-2.22.31-8b6a
Date: Thu, 28 Jan 2016 17:33:48 -0800

My main qualm is Bug#22461. It'd be OK to issue 'grep' with that bug, I 
guess. I wish I had more time to look into it before the release, but on 
the other hand if I put in a bugfix now we'd have to test it. It's not a 
serious bug, just an annoyance (an extra "Binary file matches" line on 
input that does indeed contain binary data and a match, albeit a match 
that was in text and was properly reported as text).

Message #29 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: Subject: new snapshot available: grep-2.22.31-8b6a
Date: Thu, 28 Jan 2016 21:39:01 -0500

[Message part 1 (text/plain, inline)]

hello,

> On Jan 28, 2016, at 19:36, Jim Meyering <jim <at> meyering.net> wrote:
> 
>  http://meyering.net/grep/grep-2.22.31-8b6a.tar.xz


Testing from the above tarball, no test failures on the following systems:
   Fedora-21,ppc64le
   Fedora-20,ppc64
   Ubuntu-14,aarch64
   AIX 7.1,power7 
   OpenSolaris 5.10/5.11 on i86pc and suv4u/sub4v
   Mac OS X 10.10.4
   OpenBSD 5.8, 5.7, 5.6, amd64
   FreeBSD 10.1, 9.3, amd64
   NetBSD 6.1.4, amd64
   Debian-7/kFreeBSD-9,amd64

and also no test failures on various GNU/Linux on x86-64:
   Ubuntu-14.04 with gcc,clang,tcc
   Ubuntu-15.04 (also on i686)
   Debian 8.1, 7.6
   Fedora 23, 22, 21
   CentOS 7, 6.5
   openSUSE 42.1, 13.1

======


On NetBSD 7.0,amd64 - no grep tests failures, but one gnulib test failed to compile (test-localename).
log attached.

[NetBSD70-gnulib-test-error.log (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

On Minix-3.3.0,i386, one test failed ('symlink'). log attached.

[Minix330-test-suite.log (application/octet-stream, attachment)]

[Message part 5 (text/plain, inline)]

========

When building from GIT (not tarball), and "-Werror" is enabled,
building fails on Mac OS X 10.10.4 with:
====
$ make V=1
...
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
Making all in po
make[2]: Nothing to be done for `all'.
Making all in lib
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-am
depbase=`echo error.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
	gcc -DHAVE_CONFIG_H -I. -I..   -I/usr/local/include -W -Wabi -Waddress -Wall -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wcomment -Wcomments -Wdate-time -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wenum-compare -Wextra -Wformat-extra-args -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wformat-zero-length -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types -Winit-self -Wint-conversion -Wint-to-pointer-cast -Winvalid-pch -Wlogical-not-parentheses -Wmain -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wodr -Wold-style-definition -Woverflow -Woverlength-strings -Wpacked -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wreturn-type -Wsequence-point -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wsizeof-array-argument -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wswitch-bool -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvarargs -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wno-missing-field-initializers -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wno-format-nonliteral -Werror -g -O2 -MT error.o -MD -MP -MF $depbase.Tpo -c -o error.o error.c &&\
	mv -f $depbase.Tpo $depbase.Po
error.c:386:12: error: data argument not used by format string [-Werror,-Wformat-extra-args]
           file_name, line_number);
           ^
1 error generated.
make[3]: *** [error.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
===

The 'gcc' command on this Mac is actually clang:
==
$ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.4.0
Thread model: posix



regards,
 - assaf

Message #32 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22443 <at> debbugs.gnu.org, Gnulib bugs <bug-gnulib <at> gnu.org>,
 KO Myung-Hun <komh78 <at> gmail.com>
Subject: Re: bug#22443: Subject: new snapshot available: grep-2.22.31-8b6a
Date: Fri, 29 Jan 2016 16:21:12 +0900

On Fri, Jan 29, 2016 at 10:33 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> My main qualm is Bug#22461. It'd be OK to issue 'grep' with that bug, I
> guess. I wish I had more time to look into it before the release, but on the
> other hand if I put in a bugfix now we'd have to test it. It's not a serious
> bug, just an annoyance (an extra "Binary file matches" line on input that
> does indeed contain binary data and a match, albeit a match that was in text
> and was properly reported as text).

Oh! Somehow the email for that bug report did not reach me.
I agree that it is not a big deal, but I would rather fix it first, too.
Let's see who finds the time first.

Message #35 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: Subject: new snapshot available: grep-2.22.31-8b6a
Date: Sun, 31 Jan 2016 08:29:51 +0900

On Fri, Jan 29, 2016 at 11:39 AM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
[tests passed on many systems]

Thank you for all of that testing.

> error.c:386:12: error: data argument not used by format string [-Werror,-Wformat-extra-args]
>            file_name, line_number);

This is long-standing, and so far has not felt like it's worthwhile to
work around.

Regarding the minix-3.3.0 failure of the symlink test, the high-level
symptom is that grep -r mistakenly dereferences symlinks like "e"
and "c" in that test. Why? I don't have convenient shell access to
such a system, but it looks like its fstatat function may fail to honor
the AT_SYMLINK_NOFOLLOW flag.

Given that platform is far from mainstream, I'm not inclined to
spend any more time on it before the release.

Message #38 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 22443 <at> debbugs.gnu.org
Subject: new snapshot available: grep-2.22.33-43f6
Date: Tue, 2 Feb 2016 22:07:37 -0800

Part of preparing for a release is to ensure that "make distcheck"
works, and it did not: the post-build "make clean" failed to remove
one of the files the build had created. Fixing that required a
gnulib tweak, which in turn required a grep commit to update
to that latest gnulib commit, so I've made one more snapshot,
just in case. I expect to make the release tomorrow.

grep snapshot:
  http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
  http://meyering.net/grep/grep-ss.tar.xz.sig
  http://meyering.net/grep/grep-2.22.33-43f6.tar.xz

Changes in grep since 2.22.31-8b6a:

Jim Meyering (1):
      tests/null-byte: test another code path

Paul Eggert (1):
      Omit excess "Binary file ... matches"


Changes in gnulib since 2.22.31-8b6a:

* gnulib 0fce642...7757cc8 (8):
  > get-permissions, strftime: fix grammar in comments
  > gettext: mark as obsolete
  > gnulib-tool: don't give up on ln -s so easily
  > closedir: fix OS/2-related typos
  > openat_proc_name: fix that last '/' is overwritten on OS/2 kLIBC
  > regex: treat [x] as x if x is a unibyte encoding error
  > closedir, dirfd, opendir: port to OpenSolaris 5.10
  > bootstrap: use American spelling

Message #41 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: sur-behoffski <sur_behoffski <at> grouse.com.au>
To: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 14:56:59 +1030

On 02/03/16 16:37, Jim Meyering wrote:
> Part of preparing for a release is to ensure that "make distcheck"
> works, and it did not: the post-build "make clean" failed to remove
> one of the files the build had created. Fixing that required a
> gnulib tweak, which in turn required a grep commit to update
> to that latest gnulib commit, so I've made one more snapshot,
> just in case. I expect to make the release tomorrow.
>
> grep snapshot:
>    http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
>    http://meyering.net/grep/grep-ss.tar.xz.sig
>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz
> [...]

Have tried configure/make/make check on:

        http://meyering.net/grep/grep-ss.tar.xz

for an x86_64 Gentoo system:

        - gcc 4.9.3  p1.2;
        - GNU/Linux kernel 4.3.5-gentoo;
        - glibc 2.21-r1;

and there were no errors reported:

        ============================================================================
        Testsuite summary for GNU grep 2.22.33-43f6
        ============================================================================
        # TOTAL: 138
        # PASS:  132
        # SKIP:  6
        # XFAIL: 0
        # FAIL:  0
        # XPASS: 0
        # ERROR: 0
        ============================================================================

cheers,

sur-behoffski (Brenton Hoff)
Programmer, Grouse Software

Message #44 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: sur-behoffski <sur_behoffski <at> grouse.com.au>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Wed, 3 Feb 2016 23:07:03 -0800

On Wed, Feb 3, 2016 at 8:26 PM, sur-behoffski
<sur_behoffski <at> grouse.com.au> wrote:
> On 02/03/16 16:37, Jim Meyering wrote:
>>
>> Part of preparing for a release is to ensure that "make distcheck"
>> works, and it did not: the post-build "make clean" failed to remove
>> one of the files the build had created. Fixing that required a
>> gnulib tweak, which in turn required a grep commit to update
>> to that latest gnulib commit, so I've made one more snapshot,
>> just in case. I expect to make the release tomorrow.
>>
>> grep snapshot:
>>    http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
>>    http://meyering.net/grep/grep-ss.tar.xz.sig
>>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz
>> [...]
>
>
> Have tried configure/make/make check on:
>
>         http://meyering.net/grep/grep-ss.tar.xz
>
> for an x86_64 Gentoo system:
>
>         - gcc 4.9.3  p1.2;
>         - GNU/Linux kernel 4.3.5-gentoo;
>         - glibc 2.21-r1;
>
> and there were no errors reported:

Thanks for the testing and report.

Message #47 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Zev Weiss <zev <at> bewilderbeest.net>
To: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 03:27:31 -0600

On Wed, Feb 03, 2016 at 11:07:03PM -0800, Jim Meyering wrote:
>On Wed, Feb 3, 2016 at 8:26 PM, sur-behoffski
><sur_behoffski <at> grouse.com.au> wrote:
>> On 02/03/16 16:37, Jim Meyering wrote:
>>>
>>> Part of preparing for a release is to ensure that "make distcheck"
>>> works, and it did not: the post-build "make clean" failed to remove
>>> one of the files the build had created. Fixing that required a
>>> gnulib tweak, which in turn required a grep commit to update
>>> to that latest gnulib commit, so I've made one more snapshot,
>>> just in case. I expect to make the release tomorrow.
>>>
>>> grep snapshot:
>>>    http://meyering.net/grep/grep-ss.tar.xz      1.3 MB
>>>    http://meyering.net/grep/grep-ss.tar.xz.sig
>>>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz
>>> [...]
>>
>>
>> Have tried configure/make/make check on:
>>
>>         http://meyering.net/grep/grep-ss.tar.xz
>>
>> for an x86_64 Gentoo system:
>>
>>         - gcc 4.9.3  p1.2;
>>         - GNU/Linux kernel 4.3.5-gentoo;
>>         - glibc 2.21-r1;
>>
>> and there were no errors reported:
>
>Thanks for the testing and report.
>
>

I've run the 'make check-expensive' tests on Debian stretch (gcc 5.3.1, 
glibc 2.21, Linux 4.3) and found no failures.  I also tried running them 
with GCC's ASAN & UBSAN enabled -- tests for grep proper all passed in 
both cases, though ASAN still reported some memory leaks from the gnulib 
test suite (I didn't look closely at exactly what they were, but could 
provide logs if it's of interest).


Zev Weiss

Message #50 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Zev Weiss <zev <at> bewilderbeest.net>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 08:39:41 -0800

On Thu, Feb 4, 2016 at 1:27 AM, Zev Weiss <zev <at> bewilderbeest.net> wrote:
[...]
> I've run the 'make check-expensive' tests on Debian stretch (gcc 5.3.1,
> glibc 2.21, Linux 4.3) and found no failures.  I also tried running them
> with GCC's ASAN & UBSAN enabled -- tests for grep proper all passed in both
> cases, though ASAN still reported some memory leaks from the gnulib test
> suite (I didn't look closely at exactly what they were, but could provide
> logs if it's of interest).

Thank you for the testing and report.
Re gnulib-test leaks, sure, a report of leaks would be interesting,
but if you find some that appear easy/clean to fix, patches would
be even more interesting. Please send either to the
bug-gnulib <at> gnu.org mailing list.

Message #53 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Zev Weiss <zev <at> bewilderbeest.net>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 08:43:57 -0800

I tried the latest snapshot on Solaris 10 sparc (Oracle cc) and AIX 7.1 
POWER (IBM xlc) and the cheap tests all passed.

Message #56 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>, 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 11:57:03 -0500

On 02/03/2016 01:07 AM, Jim Meyering wrote:
>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz

No failures on:
  Mac OS X v10.11.3, v10.10.5, v10.9.5
  Ubuntu 14, aarch64
  Fedora 20, ppc64
  Fedora 21, ppc64le
  OpenSolaris 5.10/5.11 on i86pc, suv4u/sub4v
  

Message #59 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 09:29:00 -0800

On Thu, Feb 4, 2016 at 8:57 AM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> On 02/03/2016 01:07 AM, Jim Meyering wrote:
>>
>>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz
>
>
> No failures on:
>   Mac OS X v10.11.3, v10.10.5, v10.9.5
>   Ubuntu 14, aarch64
>   Fedora 20, ppc64
>   Fedora 21, ppc64le
>   OpenSolaris 5.10/5.11 on i86pc, suv4u/sub4v

Thank you Assaf and Paul for all the testing.
Nice to hear "no failures" everywhere.
I will start making the release shortly.

Message #62 received at 22443 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22443 <at> debbugs.gnu.org
Subject: Re: bug#22443: new snapshot available: grep-2.22.33-43f6
Date: Thu, 4 Feb 2016 19:18:55 -0800

On Thu, Feb 4, 2016 at 9:29 AM, Jim Meyering <jim <at> meyering.net> wrote:
> On Thu, Feb 4, 2016 at 8:57 AM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
>> On 02/03/2016 01:07 AM, Jim Meyering wrote:
>>>
>>>    http://meyering.net/grep/grep-2.22.33-43f6.tar.xz
>>
>>
>> No failures on:
>>   Mac OS X v10.11.3, v10.10.5, v10.9.5
>>   Ubuntu 14, aarch64
>>   Fedora 20, ppc64
>>   Fedora 21, ppc64le
>>   OpenSolaris 5.10/5.11 on i86pc, suv4u/sub4v
>
> Thank you Assaf and Paul for all the testing.
> Nice to hear "no failures" everywhere.
> I will start making the release shortly.

I released grep-2.23 and here's the announcement:
  https://savannah.gnu.org/forum/forum.php?forum_id=8451

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.