GNU bug report logs - #70869
[PATCH] gnu: Add emacs-casual-dired.

Previous Next

To reply to this bug, email your comments to 70869 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilko Meyer <w <at> wmeyer.eu>
To: guix-patches <at> gnu.org
Cc: Wilko Meyer <w <at> wmeyer.eu>
Subject: [PATCH] gnu: Add emacs-casual-dired.
Date: Sat, 11 May 2024 02:05:56 +0200

* gnu/packages/emacs-xyz.scm (emacs-casual-dired): New variable.

Change-Id: Idd6a0e49b740c72dabe2e069cc4fc67f4909b7e9
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 310c4e1587..54b2132251 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
 ;;; Copyright © 2023 Ian Eure <ian <at> retrospec.tv>
 ;;; Copyright © 2024 Suhail Singh <suhail <at> bayesians.ca>
 ;;; Copyright © 2024 dan <i <at> dan.games>
+;;; Copyright © 2024 Wilko Meyer <w <at> wmeyer.eu>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32693,6 +32694,31 @@ (define-public emacs-cascading-dir-locals
 all of your projects, then override or add variables on a per-project basis.")
       (license license:gpl3+))))
 
+(define-public emacs-casual-dired
+  (package
+    (name "emacs-casual-dired")
+    (version "20240509.108")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/kickingvegas/casual-dired.git")
+             (commit "9f65992e362c65a3023e4e2bc4853df9e92fa2d4")))
+       (sha256
+        (base32 "19h5m0nwhvbcfr5xsndin4hgqsqpj4jvdbpx8g4iyv79jdx7jvcf"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'chdir
+            (lambda _ (chdir "lisp"))))))
+    (home-page "https://github.com/kickingvegas/casual-dired")
+    (synopsis "Transient-based porcelain for dired")
+    (description
+     "Casual Dired is an opinionated Transient-based porcelain for Emacs Dired.")
+    (license license:gpl3)))
+
 (define-public emacs-calibredb
   (package
     (name "emacs-calibredb")

base-commit: da9f509b0300f1b6b979c68a52d8669f9bcb89a7
prerequisite-patch-id: 486a565e86a4b3205f40f0b708108271ee9274c3
-- 
2.41.0

Message #8 received at 70869 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Wilko Meyer <w <at> wmeyer.eu>, 70869 <at> debbugs.gnu.org
Cc: Wilko Meyer <w <at> wmeyer.eu>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#70869] [PATCH] gnu: Add emacs-casual-dired.
Date: Thu, 30 May 2024 23:35:10 +0200

Hi Wilko,

guix lint complains about two warnings :

> gnu/packages/emacs-xyz.scm:32831:5: emacs-casual-dired <at> 20240509.108: the
> source file name should contain the package name

Here you have to add
       (file-name (git-file-name name version))
after the uri field for it to stop complaining.

> gnu/packages/emacs-xyz.scm:32831:5: emacs-casual-dired <at> 20240509.108:
> permanent redirect from https://github.com/kickingvegas/casual-dired.git
> to https://github.com/kickingvegas/casual-dired

Here you can remove the .git suffix at the end of the url.

Moreover, there are releases on the github page available as tags, we
should probably rely on these rather than the melpa version you
provided, unless we have good reasons to do otherwise.

Can you make these changes and resend a patch? Thanks!

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.