GNU bug report logs - #69605
[PATCH] Query Eglot version via package.el

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Philip Kaludercic <philipk@HIDDEN>; Keywords: patch; Done: Philip Kaludercic <philipk@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 69605-done <at> debbugs.gnu.org:


Received: (at 69605-done) by debbugs.gnu.org; 18 May 2024 22:30:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 18:30:31 2024
Received: from localhost ([127.0.0.1]:35569 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8SZT-0006Kk-4n
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 18:30:31 -0400
Received: from mout02.posteo.de ([185.67.36.66]:40337)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1s8SZQ-0006Ke-W2
 for 69605-done <at> debbugs.gnu.org; Sat, 18 May 2024 18:30:30 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 2C853240101
 for <69605-done <at> debbugs.gnu.org>; Sun, 19 May 2024 00:30:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1716071419; bh=Uz1V1g2182R+4mxn5sP+rW96yoEFNnCJn1CFZCB8iFI=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=kHB0Abh0oSVVd1G+eykudY2Vvjru4O/f36XBlLWG3oldqYOqD99yfyvrJzK5mrg8y
 UQSWCqv3gRBdUrV+G04ME/GdP2rqK6yNvgh/z6NE7MPmyJkajJaGnsmK4D+BmolUJh
 TOm+jhELUTwBdDCF5LmVe9h/r3Ww05Ghc3rgho+CqD0nv4e66CXUnpFbG0SoEEzJuJ
 6xrS95cnwrEWgMF9229jAMkU8TfgjShfIhHWXf29mKQ592urPtoVoNJ/6tWiD8c7FC
 ZMLLo/7M3D6npfh5FcVKjb17vl/J8yZnMtCKZq8MRXAhRYySILnfkxWYbFdqgmvHeC
 J1v55SWh4u+aw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VhdnQ2PWbz6trs;
 Sun, 19 May 2024 00:30:17 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
In-Reply-To: <CADwFkmnhb1D2tQf4f+u9BzP1czeGJufQ0QWPcMXd3EGy=p6Vmw@HIDDEN>
 (Stefan Kangas's message of "Sat, 18 May 2024 22:27:18 +0000")
References: <87y1auo0nw.fsf@HIDDEN> <87seyz73bs.fsf@HIDDEN>
 <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@HIDDEN>
 <878r0q69wb.fsf@HIDDEN>
 <CADwFkmnhb1D2tQf4f+u9BzP1czeGJufQ0QWPcMXd3EGy=p6Vmw@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sat, 18 May 2024 22:30:17 +0000
Message-ID: <87zfsmu51i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69605-done
Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>,
 69605-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>> The three tested versions on GitHub all appear to pass the test.  I'll
>> push the changes to emacs.git for now.
>
> Is there more to do here, or should this bug closed?

No, the change have been part of emacs.git since
3d4918c2f1d10df4051ca7dc1d17decf157adb3f.  I'll close the report.


-- 
	Philip Kaludercic on peregrine
Notification sent to Philip Kaludercic <philipk@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Philip Kaludercic <philipk@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 69605 <at> debbugs.gnu.org:


Received: (at 69605) by debbugs.gnu.org; 18 May 2024 22:28:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 18:28:32 2024
Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8SXX-0006Gq-Lm
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 18:28:31 -0400
Received: from mail-ed1-f54.google.com ([209.85.208.54]:55786)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1s8SXV-0006Gi-84
 for 69605 <at> debbugs.gnu.org; Sat, 18 May 2024 18:28:30 -0400
Received: by mail-ed1-f54.google.com with SMTP id
 4fb4d7f45d1cf-56e69888a36so6122940a12.3
 for <69605 <at> debbugs.gnu.org>; Sat, 18 May 2024 15:28:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716071240; x=1716676040; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=9qaoRI2Z4E3TTgIZ/PtpGSubfznQRSZdVD+G7tBmYPA=;
 b=EMcreSsa55pxQSFGi+qbIU+CsH90izeRe/mQvo1++5Vz7X6SYK1vh/nmLeZHUNZ2dX
 WKKwtKVsmpwgfuJIdRMLHzYcIulqBwptOXs17yjS/saY8BiJ+7u+2ehPH2qM90AzSydx
 6EFTXqucuXuESAVpSgsd6Xak1BcC9bwWR+nyV7/tsVssWqBgGgjqi6gXPmK8N3D4pun4
 I1sFLilN97XjY8ej8S09HQodM5v5GBFH82N/ajvLiSwthqCWqo0Hys+eWeWM9DA4xBWE
 TTm9eswTfl1UCc43WxHhRarWMNHbu8BsndNM6wYnSyRNtBX/yGq4ZwZ/tb+g7/iayBOr
 lQ/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716071240; x=1716676040;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=9qaoRI2Z4E3TTgIZ/PtpGSubfznQRSZdVD+G7tBmYPA=;
 b=CkLOUtD7GDn/csbeMQBR6I5vtM672DIEE3Wqx3Cte0QkZCZVRwmggA60ZrlDIYPxlF
 30W6CFaGfXWd9DkYoHBUvpQBLaBdhVjW9L2Xagpx/XuqbhnbGCQ6QT0M23ohUwA2X0Ep
 3XaD+jm+xQ2hVpaxdAdYRBNb6FuMHA1zDfhqNkP81k9cGnr2VYYRYWRuT1REnL/gkJOC
 KgbXj3O2LWMHcaHRxxwL5b2AVC/BSgzHL73+UX5xSnejMUeJvbKVZC28e35D9rbe3iw5
 FaiXYv1rJvvhstW4uAFpCGuW7BD69jHnHrPrmiQR4oynxFMAFK9scc20o3lpjVG5ZTit
 rQaw==
X-Gm-Message-State: AOJu0Yw+DpWCSkVbjkcpZOC1ns2Szfyo3/Og8ZAnE66txjAxmIRPt3mG
 HYZtuUS1tWSMi/N5vPQd1Z76sJStBaympudvGslTyokxV2M200bpt8Gjc0vBrFEhLXHt7pCDYNr
 NsxsbglC0ZJ26xhNuVvSA/mXZZL+8Ed6X
X-Google-Smtp-Source: AGHT+IHg6QUfH/iXjVbg8tKgsQnYSWlw+vl+VUAvTfswvumC4tO1p63ptAoaCsA8crSA4WXHROF1oH/iTdxC1eM08qI=
X-Received: by 2002:a50:a45b:0:b0:568:32cc:f808 with SMTP id
 4fb4d7f45d1cf-5734d5cf9a5mr16631328a12.15.1716071239826; Sat, 18 May 2024
 15:27:19 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 18 May 2024 22:27:18 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <878r0q69wb.fsf@HIDDEN>
References: <87y1auo0nw.fsf@HIDDEN> <87seyz73bs.fsf@HIDDEN>
 <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@HIDDEN>
 <878r0q69wb.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 18 May 2024 22:27:18 +0000
Message-ID: <CADwFkmnhb1D2tQf4f+u9BzP1czeGJufQ0QWPcMXd3EGy=p6Vmw@HIDDEN>
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
To: Philip Kaludercic <philipk@HIDDEN>,
 =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69605
Cc: 69605 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

> The three tested versions on GitHub all appear to pass the test.  I'll
> push the changes to emacs.git for now.

Is there more to do here, or should this bug closed?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69605; Package emacs. Full text available.

Message received at 69605 <at> debbugs.gnu.org:


Received: (at 69605) by debbugs.gnu.org; 3 May 2024 18:14:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 14:14:35 2024
Received: from localhost ([127.0.0.1]:48041 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s2xQW-0005Tu-Ey
	for submit <at> debbugs.gnu.org; Fri, 03 May 2024 14:14:35 -0400
Received: from mout02.posteo.de ([185.67.36.66]:51727)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1s2xQQ-0005Tm-RC
 for 69605 <at> debbugs.gnu.org; Fri, 03 May 2024 14:14:31 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id E13A8240101
 for <69605 <at> debbugs.gnu.org>; Fri,  3 May 2024 20:13:57 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1714760037; bh=xyzTaxfjxld0oGAkSVlyTLf6/IQsCxHlJcK7+WFxULA=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=iH17bPObVyj+k/xbzXVh+KWcOijtEzwr22PnbdgCzqZv1yqPJlGVlrE/8k5gd80LC
 vHQAjecVWMmPaZPxaTnNsc6oMWMejEaBJRyq25Y1mLBv1ZmAYvEV7XeARtKa7imecu
 sPW1R2MFIxcYBk2kFSzlorMghC4Z5bqUxuYe+79sRioCPikjXFIr5S5XRprPSkcTO0
 2PNMPDCScw5ELQJFx1KjYIeYUz+AW6WRHBCpviaPlpk46VgRh/Fm0/GcC2K8iaYN7l
 iRdrhVfJLKRcAeNaO8ciOdht3l/7iqmSfLE38H3Nsz3aPZKoWyUiyMGL0FEUG10dJ9
 jNoOnCGRDGb7g==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VWJpY2559z6tm8;
 Fri,  3 May 2024 20:13:57 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
In-Reply-To: <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@HIDDEN>
 (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 3 May 2024
 12:54:05 +0100")
References: <87y1auo0nw.fsf@HIDDEN> <87seyz73bs.fsf@HIDDEN>
 <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Fri, 03 May 2024 18:13:56 +0000
Message-ID: <878r0q69wb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69605
Cc: 69605 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:

> On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic <philipk@posteo.=
net> wrote:
>
>> Ping?
>>
>
> Patch looks good to me, I'm generally in favour of things that replace
> Eglot-rolled facilities with standard ones.
>
> But I haven't tested it.  What will `package-get-version` say of a master
> build of Emacs where lisp/progmodes/eglot.el has changes that haven't
> been published to GNU Elpa yet?  Does it even matter?

It will just extract the value of the version header of the compiled
file.

> Anyway, I think the change is safe to install, just please make sure it
> doesn't trip the GitHub CI (it shouldn't).

The three tested versions on GitHub all appear to pass the test.  I'll
push the changes to emacs.git for now.

> Jo=C3=A3o

--=20
	Philip Kaludercic on peregrine
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69605; Package emacs. Full text available.

Message received at 69605 <at> debbugs.gnu.org:


Received: (at 69605) by debbugs.gnu.org; 3 May 2024 11:54:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 07:54:49 2024
Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s2rV3-0008Qq-Hb
	for submit <at> debbugs.gnu.org; Fri, 03 May 2024 07:54:49 -0400
Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:61783)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1s2rV0-0008Qg-J7
 for 69605 <at> debbugs.gnu.org; Fri, 03 May 2024 07:54:47 -0400
Received: by mail-lf1-x130.google.com with SMTP id
 2adb3069b0e04-51f4d2676d1so1874257e87.3
 for <69605 <at> debbugs.gnu.org>; Fri, 03 May 2024 04:54:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1714737258; x=1715342058; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=;
 b=hXicMpsto/pAmFATZ5nuVA8zn6oT0X0ZEtg40pdbaSQRe+hYQRfhzFRQW22yY3jR+T
 8YBiVUj2eTBu6k9FtRQBnrVwUy7EkE2jmqfjwiqyT4FXbFy+1BSq71Ihu8ewC/eIl4WN
 pperV/6xK+Ksti4hs80Hjj1/Ks0gweNRqeNcW2IIL1EPrFps1PwxCVVDZL+O8/vms0dy
 Ksghp1vjHzaUWglZWpcmSb8HNsLIut3V4Mn5JpnbcuY4cR7D643M7VHJDmY9tqQ0kUok
 piEULtfniC4lq7x2nrdCCY3zvl0BvvMPQ7eTKU568ynur/sRk5fBVFw7QTLTQJLbzNJl
 5gYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1714737258; x=1715342058;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=;
 b=CFv0apiGce/ujZYcy9NJ+ZJ9nWg9m9vb/5NQCdjA2a33bk/n+31RlzIbIcqiE2i9fG
 8/z2F0nOoEv1hiN4DQvkXrQQhsoXug/DzI7aYhH2oQLpV26YIBrxJIqFtDfh6XmTzwId
 Quy+JW9+9tkNW2qBYzSr07l0QeHHpWPWFl1P+owDLesYaDqk3E8kiZZd7MhDMrHvDp/P
 I6B0bF7G8aLXr5nvCSJHN96ZEAWBu/E22zacJTYKYTnL1l2+FyXVi+6GiG33bdVVknYM
 wN4rbghHVIzmRE4TfUdz0allxxEkEUnQqXfrEd5XbzpEZn7F7Ku4mVAiXgAiNQub0FkM
 58cQ==
X-Gm-Message-State: AOJu0Yy6odOXL45lgJEfL25M23igPbbL5za5J2bJAJ5I3ERV6UTrEtuF
 vz/DX6Utc27+R2tykATmsB7+XiMJK4tMcOxJKDipEUo5iVHExuz9cgdzZit8oTHcl2u9Z52ajbW
 qZa4x73yG9Z3qL9M1De3wEi1PxvY=
X-Google-Smtp-Source: AGHT+IEhvW4wC542mcmUiXL+N6nkVgkzJuLwFC9SvHSGums/sTbubWLHrzJiSEG8eoyzNqpn2qC504rIV9zrWEib8Cw=
X-Received: by 2002:ac2:4895:0:b0:51b:214c:5239 with SMTP id
 x21-20020ac24895000000b0051b214c5239mr1656908lfc.62.1714737257565; Fri, 03
 May 2024 04:54:17 -0700 (PDT)
MIME-Version: 1.0
References: <87y1auo0nw.fsf@HIDDEN> <87seyz73bs.fsf@HIDDEN>
In-Reply-To: <87seyz73bs.fsf@HIDDEN>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Fri, 3 May 2024 12:54:05 +0100
Message-ID: <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@HIDDEN>
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
To: Philip Kaludercic <philipk@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000001ed8cc06178b61df"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 69605
Cc: 69605 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000001ed8cc06178b61df
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic <philipk@HIDDEN=
t> wrote:

> Ping?
>

Patch looks good to me, I'm generally in favour of things that replace
Eglot-rolled facilities with standard ones.

But I haven't tested it.  What will `package-get-version` say of a master
build of Emacs where lisp/progmodes/eglot.el has changes that haven't
been published to GNU Elpa yet?  Does it even matter?

Anyway, I think the change is safe to install, just please make sure it
doesn't trip the GitHub CI (it shouldn't).

Jo=C3=A3o

--0000000000001ed8cc06178b61df
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><span style=3D"font-family:Arial,Helvetic=
a,sans-serif">On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic &lt;=
<a href=3D"mailto:philipk@HIDDEN">philipk@HIDDEN</a>&gt; wrote:</sp=
an><br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">Ping?<br></blockquote><div>=C2=A0</div><div>Patch looks good=
 to me, I&#39;m generally in favour of things that replace</div><div>Eglot-=
rolled facilities with standard ones.</div><div><br></div><div>But I haven&=
#39;t tested it.=C2=A0 What will `package-get-version` say of a master</div=
><div>build of Emacs where lisp/progmodes/eglot.el has changes that haven&#=
39;t</div><div>been published to GNU Elpa yet?=C2=A0 Does it even matter?</=
div><div><br></div><div>Anyway, I think the change is safe to install, just=
 please make sure it=C2=A0</div><div>doesn&#39;t trip the=C2=A0<span style=
=3D"font-family:Arial,Helvetica,sans-serif">GitHub CI (it shouldn&#39;t).</=
span></div><div><span style=3D"font-family:Arial,Helvetica,sans-serif"><br>=
</span></div><div><span style=3D"font-family:Arial,Helvetica,sans-serif">Jo=
=C3=A3o</span></div></div></div>

--0000000000001ed8cc06178b61df--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69605; Package emacs. Full text available.

Message received at 69605 <at> debbugs.gnu.org:


Received: (at 69605) by debbugs.gnu.org; 3 May 2024 07:38:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 03:38:46 2024
Received: from localhost ([127.0.0.1]:46225 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s2nVG-0003Lt-Ep
	for submit <at> debbugs.gnu.org; Fri, 03 May 2024 03:38:46 -0400
Received: from mout01.posteo.de ([185.67.36.65]:45099)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1s2nVE-0003Lf-EL
 for 69605 <at> debbugs.gnu.org; Fri, 03 May 2024 03:38:44 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 8B3F9240029
 for <69605 <at> debbugs.gnu.org>; Fri,  3 May 2024 09:38:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1714721896; bh=RT4KIh+2S3mmwIIlKJAuY9MI6IHDUIDDXFTFEKFbr+4=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=P0eqD0SQ9elgRehhNZLv8oWSf+IZ6GxciblqUvaGmzSAY/lUOaa8yabHJGKcCR/rt
 wEYsC4jrGVzkb9M9/zJjvIZSpdy89C4N46GyEOgnI4+HRRfGheT/9el2cjiRIZbPhY
 urCtFftU6oCJEIX6zcrc/8XCIps3HsQIIEEJw1pzLQgnLk+CPf0dfibzPAly0rQ4zb
 VDV5OnqO4d6ziea4dcv9yyWd9r+hTh6drkGH36Z8eW5N1UBJ2j3SA/8eeGBDEjuRgk
 ZX9iIqPVyIB5OntoIIeu7geK3BkxlO2nTR1ZTeQY1tdIWVZi2ZY9fyViBTOLZO+pnZ
 QQ09zXbjO4pQw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VW2j416Qtz9rxK;
 Fri,  3 May 2024 09:38:16 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: 69605 <at> debbugs.gnu.org
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
In-Reply-To: <87y1auo0nw.fsf@HIDDEN> (Philip Kaludercic's message of "Thu, 
 07 Mar 2024 09:23:47 +0000")
References: <87y1auo0nw.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Fri, 03 May 2024 07:38:15 +0000
Message-ID: <87seyz73bs.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69605
Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping?

Philip Kaludercic <philipk@HIDDEN> writes:

> It seems to me that 'package-get-version' should already implement the
> logic which is currently being reproduced when defining the constant
> 'eglot--version', so I suggest the following simplification:
>
>>From 7566857ae869eb4cf01bde527eaedb8a3353f035 Mon Sep 17 00:00:00 2001
> From: Philip Kaludercic <philipk@HIDDEN>
> Date: Thu, 7 Mar 2024 10:21:45 +0100
> Subject: [PATCH] Query Eglot version via package.el
>
> * lisp/progmodes/eglot.el (eglot--version): Remove constant.
> (eglot--connect): Use 'package-get-version'.
> ---
>  lisp/progmodes/eglot.el | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index f341428cac3..1ec186e75f8 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -545,13 +545,6 @@ eglot-withhold-process-id
>  
>  ;;; Constants
>  ;;;
> -(defconst eglot--version
> -  (eval-when-compile
> -    (when byte-compile-current-file
> -      (require 'lisp-mnt)
> -      (lm-version byte-compile-current-file)))
> -  "The version as a string of this version of Eglot.
> -It is nil if Eglot is not byte-complied.")
>  
>  (defconst eglot--symbol-kind-names
>    `((1 . "File") (2 . "Module")
> @@ -1585,8 +1578,10 @@ eglot--connect
>                                              'network))
>                                (emacs-pid))
>                              :clientInfo
> -                            `(:name "Eglot" ,@(when eglot--version
> -                                                `(:version ,eglot--version)))
> +                            (append
> +                             '(:name "Eglot")
> +                             (let ((v (package-get-version)))
> +                               (and v (list :version v))))
>                              ;; Maybe turn trampy `/ssh:foo@bar:/path/to/baz.py'
>                              ;; into `/path/to/baz.py', so LSP groks it.
>                              :rootPath (file-local-name
> -- 
> 2.44.0

-- 
	Philip Kaludercic on peregrine
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69605; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Mar 2024 09:24:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 07 04:24:27 2024
Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ri9zG-0004Lf-Rw
	for submit <at> debbugs.gnu.org; Thu, 07 Mar 2024 04:24:27 -0500
Received: from lists.gnu.org ([209.51.188.17]:53138)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1ri9zE-0004LV-Re
 for submit <at> debbugs.gnu.org; Thu, 07 Mar 2024 04:24:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
 id 1ri9yj-00056e-0Y
 for bug-gnu-emacs@HIDDEN; Thu, 07 Mar 2024 04:23:53 -0500
Received: from mout02.posteo.de ([185.67.36.66])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
 id 1ri9yh-0005GD-2b
 for bug-gnu-emacs@HIDDEN; Thu, 07 Mar 2024 04:23:52 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 06338240101
 for <bug-gnu-emacs@HIDDEN>; Thu,  7 Mar 2024 10:23:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1709803428; bh=GYhmCgvl2HspRjUWBFk68ZDqJk03IdeZ+Py5LQY0bEY=;
 h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type:
 From;
 b=AfktuM5RTOdmUyMaTqVhr6oZ8Xyqd6oQP+JdM2Exzr26+dnXFIQ/ld4N/cKFGKwzR
 s+VimgOaQGR3o3oER+FiyhVfl10RoKNLUT70KYMBFpRjBI2/8nmRSccvxIaQD3I/YQ
 upGlInjEg19bEdiKq40iberI729wAck+2UMjkY5PdjXueZH1SnhbV52gIWGANXBAWK
 kMFGjgykEjXQwwSi5Brq+B/wmivZQ9ce3anHHpAXP446b44cxssxSf6Hp2YbnSnx8u
 n9USzTed9nLFgy2OvogDnxzWfRV+kVEBBamcyNEuHjhn57OIoPp4OPsj/+REt+tMNf
 5x1/HTlei9htg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Tr3l74Fnsz9rxL
 for <bug-gnu-emacs@HIDDEN>; Thu,  7 Mar 2024 10:23:47 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Query Eglot version via package.el
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Thu, 07 Mar 2024 09:23:47 +0000
Message-ID: <87y1auo0nw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@HIDDEN;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

It seems to me that 'package-get-version' should already implement the
logic which is currently being reproduced when defining the constant
'eglot--version', so I suggest the following simplification:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Query-Eglot-version-via-package-el.patch
Content-Description: [PATCH] Query Eglot version via package.el

From 7566857ae869eb4cf01bde527eaedb8a3353f035 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@HIDDEN>
Date: Thu, 7 Mar 2024 10:21:45 +0100
Subject: [PATCH] Query Eglot version via package.el

* lisp/progmodes/eglot.el (eglot--version): Remove constant.
(eglot--connect): Use 'package-get-version'.
---
 lisp/progmodes/eglot.el | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index f341428cac3..1ec186e75f8 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -545,13 +545,6 @@ eglot-withhold-process-id
 
 ;;; Constants
 ;;;
-(defconst eglot--version
-  (eval-when-compile
-    (when byte-compile-current-file
-      (require 'lisp-mnt)
-      (lm-version byte-compile-current-file)))
-  "The version as a string of this version of Eglot.
-It is nil if Eglot is not byte-complied.")
 
 (defconst eglot--symbol-kind-names
   `((1 . "File") (2 . "Module")
@@ -1585,8 +1578,10 @@ eglot--connect
                                             'network))
                               (emacs-pid))
                             :clientInfo
-                            `(:name "Eglot" ,@(when eglot--version
-                                                `(:version ,eglot--version)))
+                            (append
+                             '(:name "Eglot")
+                             (let ((v (package-get-version)))
+                               (and v (list :version v))))
                             ;; Maybe turn trampy `/ssh:foo@bar:/path/to/baz.py'
                             ;; into `/path/to/baz.py', so LSP groks it.
                             :rootPath (file-local-name
-- 
2.44.0


--=-=-=
Content-Type: text/plain


-- 
	Philip Kaludercic on peregrine

--=-=-=--
Acknowledgement sent to Philip Kaludercic <philipk@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#69605; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 18 May 2024 22:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.