GNU bug report logs - #54911
Missing modules argument for coverage-data->lcov

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54911 in the body.
You can then email your comments to 54911 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jessica Tallon <tsyesika <at> tsyesika.se>
To: bug-guile <at> gnu.org
Subject: Missing modules argument for coverage-data->lcov
Date: Wed, 13 Apr 2022 16:01:27 +0200

[Message part 1 (text/plain, inline)]

Hello,

I noticed the documentation specify that the `coverage-data->lcov`
function should be able to take modules to limit the scope of the data
that's coverted to lcov. From the docs:

 -- Scheme Procedure: coverage-data->lcov data port #:key modules
     Traverse code coverage information DATA, as obtained with
     ‘with-code-coverage’, and write coverage information to port in the
     ‘.info’ format used by LCOV
     (http://ltp.sourceforge.net/coverage/lcov.php).  The report will
     include all of MODULES (or, by default, all the currently loaded
     modules) even if their code was not executed.

However I noticed that this didn't match the code. I've attached a patch
which implements the behavour described in the docs.

Thanks,
Jessica.

[0001-Fix-missing-modules-argument-for-coverage-data-lcov.patch (text/x-patch, attachment)]

Message #10 received at 54911-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jessica Tallon <tsyesika <at> tsyesika.se>
Cc: 54911-done <at> debbugs.gnu.org
Subject: Re: bug#54911: Missing modules argument for coverage-data->lcov
Date: Thu, 16 Jun 2022 10:03:26 +0200

Hi Jessica,

Jessica Tallon <tsyesika <at> tsyesika.se> skribis:

>>From 828daf200539d3a642fcf8210df7b58aa0d5fede Mon Sep 17 00:00:00 2001
> From: Jessica Tallon <tsyesika <at> tsyesika.se>
> Date: Wed, 13 Apr 2022 15:57:24 +0200
> Subject: [PATCH] Fix missing modules argument for coverage-data->lcov
>
> The code coverage function `coverage-data->lcov` has a documented
> `modules` argument, however that was missing from the source. I have
> added it so when supplied it only converts the coverage data for the
> supplied modules. If not supplied it defaults the old behavour of
> including all the modules currently loaded.

I added a ChangeLog-style entry and committed it.

Thanks for fixing this issue!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.