GNU bug report logs - #50714
OS X, one failure: tests/tail-2/pipe-f.sh

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50714 in the body.
You can then email your comments to 50714 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-coreutils <at> gnu.org
Subject: OS X, one failure: tests/tail-2/pipe-f.sh
Date: Mon, 20 Sep 2021 21:34:11 -0700

[Message part 1 (text/plain, inline)]

Uname -v reports this:
Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021;
root:xnu-7195.141.6~3/RELEASE_X86_64

Sorry, I don't have time to delve into this, but here's the log from
the sole test failure:

[pipe-f.log (application/octet-stream, attachment)]

Message #8 received at 50714 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 50714 <at> debbugs.gnu.org
Subject: Re: bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh
Date: Tue, 21 Sep 2021 14:08:36 +0100

[Message part 1 (text/plain, inline)]

On 21/09/2021 05:34, Jim Meyering wrote:
> Uname -v reports this:
> Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021;
> root:xnu-7195.141.6~3/RELEASE_X86_64
> 
> Sorry, I don't have time to delve into this, but here's the log from
> the sole test failure:

This looks to be an instance I was worried about in:
https://lists.gnu.org/archive/html/bug-coreutils/2021-06/msg00052.html

The attached fixes this on my testing on macOS.

cheers,
Pádraig

[tail-pipe-macos.patch (text/x-patch, attachment)]

Message #11 received at 50714 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 50714 <at> debbugs.gnu.org
Subject: Re: bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh
Date: Tue, 21 Sep 2021 08:50:37 -0700

On 9/21/21 6:08 AM, Pádraig Brady wrote:

> The attached fixes this on my testing on macOS.

Thanks fixing this portability bug that I introduced. I also suggest 
changing this:

>  #ifdef _AIX                                                                    
> -  /* select on AIX was seen to give a readable event immediately.  */          
> +  /* select on AIX was seen to give a readable event immediately.              
> +     Note poll doesn't work for this application on macOS.  */

to something like this:

  -#ifdef _AIX
  -  /* select on AIX was seen to give a readable event immediately.  */
  +  /* Use 'poll' on AIX (where 'select' was seen to give a readable
  +     event immediately) or if using inotify (which relies on 'poll'
  +     anyway).  Otherwise, use 'select' as it's more portable;
  +     'poll' doesn't work for this application on macOS.  */
  +#if defined _AIX || HAVE_INOTIFY

so that if the inotify code uses 'poll' it uses 'poll' uniformly rather 
than sometimes 'poll' and sometimes 'select'.

Message #16 received at 50714-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 50714-done <at> debbugs.gnu.org
Subject: Re: bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh
Date: Tue, 21 Sep 2021 17:53:39 +0100

On 21/09/2021 16:50, Paul Eggert wrote:
> On 9/21/21 6:08 AM, Pádraig Brady wrote:
> 
>> The attached fixes this on my testing on macOS.
> 
> Thanks fixing this portability bug that I introduced. I also suggest
> changing this:
> 
>>   #ifdef _AIX
>> -  /* select on AIX was seen to give a readable event immediately.  */
>> +  /* select on AIX was seen to give a readable event immediately.
>> +     Note poll doesn't work for this application on macOS.  */
> 
> to something like this:
> 
>     -#ifdef _AIX
>     -  /* select on AIX was seen to give a readable event immediately.  */
>     +  /* Use 'poll' on AIX (where 'select' was seen to give a readable
>     +     event immediately) or if using inotify (which relies on 'poll'
>     +     anyway).  Otherwise, use 'select' as it's more portable;
>     +     'poll' doesn't work for this application on macOS.  */
>     +#if defined _AIX || HAVE_INOTIFY
> 
> so that if the inotify code uses 'poll' it uses 'poll' uniformly rather
> than sometimes 'poll' and sometimes 'select'.
> 

Done, and pushed.

thanks for the review/improvement.

cheers,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.