GNU bug report logs - #49640
[PATCH core-updates] gnu: ghostscript: Improve reproducibility of PDF document generation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49640 in the body.
You can then email your comments to 49640 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] gnu: ghostscript: Improve reproducibility of
 PDF document generation
Date: Mon, 19 Jul 2021 11:45:07 +0000

[Message part 1 (text/plain, inline)]

Hi,

When trying to solve a reproducibility issue when generating the
PDF documentation of the txr software (see [1]), Paul Patience noticed
that ghostscript writes a creation date in the PDF even when the
GS_GENERATE_UUIDS environment variable is set to "0".

The attached patch updates 'ghostscript-no-header-creationdate.patch' to
fix this issue.

Given the amount of rebuilds caused by modifying ghostscript, this
should go to core-updates, but is core-updates in freeze state already,
or can I push this patch right now?

Note: Even with this patch, there are still some cases where PDF
generation by ghostscript is not reproducible (for reasons not related
to creation date), like groff-doc.

[1]: https://bugs.gnu.org/49517

[0001-gnu-ghostscript-Improve-reproducibility-of-PDF-docum.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49640 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 49640 <at> debbugs.gnu.org
Subject: Re: bug#49640: [PATCH core-updates] gnu: ghostscript: Improve
 reproducibility of PDF document generation
Date: Mon, 19 Jul 2021 16:35:18 +0200

Hi Guillaume,

Guillaume Le Vaillant <glv <at> posteo.net> skribis:

> When trying to solve a reproducibility issue when generating the
> PDF documentation of the txr software (see [1]), Paul Patience noticed
> that ghostscript writes a creation date in the PDF even when the
> GS_GENERATE_UUIDS environment variable is set to "0".
>
> The attached patch updates 'ghostscript-no-header-creationdate.patch' to
> fix this issue.
>
> Given the amount of rebuilds caused by modifying ghostscript, this
> should go to core-updates, but is core-updates in freeze state already,
> or can I push this patch right now?

[...]

> From db5962c68099f835350c24c8a3f889b9fa1f8a8e Mon Sep 17 00:00:00 2001
> From: Guillaume Le Vaillant <glv <at> posteo.net>
> Date: Mon, 19 Jul 2021 11:48:12 +0200
> Subject: [PATCH] gnu: ghostscript: Improve reproducibility of PDF document
>  generation
>
> * gnu/packages/patches/ghostscript-no-header-creationdate.patch: Disable
>   writing "xmp:ModifyDate" and "xmp:CreateDate" if GS_GENERATE_UUIDS is set to
>   "0" or "no".

LGTM, you can push to ‘core-updates’.  Was this submitted upstream?

Note: when ‘core-updates’ is frozen, we’ll fork ‘core-updates-frozen’ so
that people can happily keeping messing up on ‘core-updates’.  This was
suggested some months ago during the Guix Days and I think it can make
things smoother!

Thanks,
Ludo’.

Message #13 received at 49640-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49640-done <at> debbugs.gnu.org
Subject: Re: bug#49640: [PATCH core-updates] gnu: ghostscript: Improve
 reproducibility of PDF document generation
Date: Mon, 19 Jul 2021 15:23:57 +0000

Ludovic Courtès <ludo <at> gnu.org> skribis:

> LGTM, you can push to ‘core-updates’.

Done in db5962c68099f835350c24c8a3f889b9fa1f8a8e.
Thanks for the review.

> Was this submitted upstream?

No, in [1] upstream indicates explicitly that they don't want to
implement reproducible builds.

[1] https://bugs.ghostscript.com/show_bug.cgi?id=698208

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.