GNU bug report logs - #47693
[PATCH]: Use 'cc-for-target'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47693 in the body.
You can then email your comments to 47693 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH]: Use 'cc-for-target'.
Date: Sat, 10 Apr 2021 20:03:40 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

This patch series addressed some warnings generated by the linter defined
in #47676.  There will (presumably) be more patches along these lines
later.

These patches do *not* cause any rebuilds (except when cross-compiling),
as (string-append "CC=" (cc-for-target)) evaluates to "CC=gcc" when not
cross-compiling (this is evaluated from within Guix, not from in the build
container, so this doesn't cause a derivation change).

An exception is xssproxy, which needs to be rebuilt, due to nested usage of
quasiquote / unquote.  It can probably be worked-around but I don't think
it's worth it for a single package.

./pre-inst-env guix build guix still succeeds, and the derivation for guix
isn't even changed:

$./pre-inst-env guix weather guix
> computing 1 package derivations for x86_64-linux...
> looking for 1 store items on https://ci.guix.gnu.org...
> https://ci.guix.gnu.org
>   100.0% substitutes available (1 out of 1)
> [...]

Now running "./pre-inst-env guix pull --url=$PWD --profile=tmp-prof --disable-authentication --allow-downgrades --banch=BRANCH";
I'll let you know if this fails.

Greetings,
Maxime

[0016-gnu-emacs-xyz-Use-cc-for-target.patch (text/x-patch, attachment)]

[0015-gnu-endlessh-Use-cc-for-target.patch (text/x-patch, attachment)]

[0014-gnu-miniupnpc-Use-cc-for-target.patch (text/x-patch, attachment)]

[0013-gnu-nyancat-Use-cc-for-target.patch (text/x-patch, attachment)]

[0012-gnu-image-Use-cc-for-target.patch (text/x-patch, attachment)]

[0011-gnu-networking-Use-cc-for-target.patch (text/x-patch, attachment)]

[0010-gnu-image-viewers-Use-cc-for-target.patch (text/x-patch, attachment)]

[0009-gnu-cbatticon-Use-cc-for-target.patch (text/x-patch, attachment)]

[0008-gnu-xdisorg-Use-cc-for-target.patch (text/x-patch, attachment)]

[0007-gnu-pgpdump-Use-cc-for-target.patch (text/x-patch, attachment)]

[0006-gnu-fbida-Use-cc-for-target.patch (text/x-patch, attachment)]

[0005-gnu-cd-discid-Use-cc-for-target.patch (text/x-patch, attachment)]

[0004-gnu-lua-Use-cc-for-target.patch (text/x-patch, attachment)]

[0003-gnu-crypto-Use-cc-for-target.patch (text/x-patch, attachment)]

[0002-gnu-dev86-Use-cc-for-target.patch (text/x-patch, attachment)]

[0001-gnu-irc-Use-cc-for-target.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 47693 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 47693 <at> debbugs.gnu.org
Subject: [PATCH]: Use 'cc-for-target'.
Date: Thu, 22 Apr 2021 01:40:17 +0200

[Message part 1 (text/plain, inline)]

Maxime,

Thanks for this series!

I applied it by downloading from the first top-right ‘Download’ 
link and using ‘git am --patch-format mbox /tmp/47693-0.mbox’.  It 
works to apply all changes, but combines them all into a single 
commit.

If anyone knows how to apply whole mboxes from the archives, as 
separate commits, please let me know.  I'll push it as soon as I 
learn how!

One very minor correction:

> An exception is xssproxy, which needs to be rebuilt,
> due to nested usage ofquasiquote / unquote.

There are two: ‘nethogs’ is the other.

Both are cheap (C <3 U) leaf packages.  I don't think it worth 
working around either.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47693 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 47693 <at> debbugs.gnu.org
Subject: Re: [bug#47693] [PATCH]: Use 'cc-for-target'.
Date: Thu, 22 Apr 2021 18:44:27 +0200

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice via Guix-patches via schreef op do 22-04-2021 om 01:40 [+0200]:
> Maxime,
> 
> Thanks for this series!
> 
> I applied it by downloading from the first top-right ‘Download’ 
> link and using ‘git am --patch-format mbox /tmp/47693-0.mbox’.  It 
> works to apply all changes, but combines them all into a single 
> commit.

Can you download each patch separately, say as

  download-dir/0001-first.patch
  download-dir/0001-second.patch
  ...

and run "git am download-dir/*.patch"?
Ideally, "git am --patch-format mbox ..." would ‘just work’ though ...

> If anyone knows how to apply whole mboxes from the archives, as 
> separate commits, please let me know.  I'll push it as soon as I 
> learn how!

Alternatively, you could fetch from my public repo
(branch: cc-for-target, current latest commit: 49ac49daca37f975527f2c2f756f719bd55d47ff,
url: https://notabug.org/mdevos/guix).  (You'll need to rebase and sign the commits
yourself instead of doing a mergo, I am not in .guix-authorizations.)

IIRC, I have not yet sent the latest commits to the latest mailing list though,
and it also contains a separate commit ‘lint: Add 'compiler-for-target' checker.’.

> One very minor correction:
> 
> > An exception is xssproxy, which needs to be rebuilt,
> > due to nested usage ofquasiquote / unquote.
> 
> There are two: ‘nethogs’ is the other.
Ok.

> Both are cheap (C <3 U) leaf packages.  I don't think it worth 
> working around either.
Agreed.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 47693 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 47693 <at> debbugs.gnu.org
Subject: Re: [bug#47693] [PATCH]: Use 'cc-for-target'.
Date: Thu, 22 Apr 2021 18:51:34 +0200

[Message part 1 (text/plain, inline)]

> Alternatively, you could fetch from my public repo
> (branch: cc-for-target, current latest commit: 49ac49daca37f975527f2c2f756f719bd55d47ff,
> url: https://notabug.org/mdevos/guix).

Oops this should have been
<https://notabug.org/mdevos/guix-gnunet/>.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 47693-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 47693-done <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: bug#47693: [PATCH]: Use 'cc-for-target'.
Date: Thu, 08 Jul 2021 16:34:37 +0200

Hey,

It appears that this has been pushed, so closing.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.