GNU bug report logs - #47107
libtiff/fixed uses wrong version number in 'doc' output

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47107 in the body.
You can then email your comments to 47107 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: libtiff/fixed uses wrong version number in 'doc' output
Date: Fri, 12 Mar 2021 13:55:17 -0500

The grafted replacement of libtiff, libtiff/fixed, updates the package
from version 4.1.0 to 4.2.0.

However, the it does not adjust the #:configure-flags of the inherited
package, which rely on the version number. 

The result is directories named 'share/doc/libtiff-4.1.0' in the "doc"
output of libtiff-4.2.0.

Message #10 received at 47107-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 47107-done <at> debbugs.gnu.org
Subject: Re: libtiff/fixed uses wrong version number in 'doc' output
Date: Fri, 12 Mar 2021 14:11:07 -0500

Fixed in 35b3ab8e5748d9911ae7a0189065d0c25392895b

Message #13 received at 47107 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 47107 <at> debbugs.gnu.org
Subject: Re: bug#47107: libtiff/fixed uses wrong version number in 'doc' output
Date: Sat, 13 Mar 2021 11:44:27 +0100

[Message part 1 (text/plain, inline)]

Hi Leo,

Leo Famulari <leo <at> famulari.name> skribis:

> The grafted replacement of libtiff, libtiff/fixed, updates the package
> from version 4.1.0 to 4.2.0.
>
> However, the it does not adjust the #:configure-flags of the inherited
> package, which rely on the version number. 
>
> The result is directories named 'share/doc/libtiff-4.1.0' in the "doc"
> output of libtiff-4.2.0.

Instead of duplicating the ‘name’ and ‘arguments’ fields as done in
35b3ab8e5748d9911ae7a0189065d0c25392895b, one possibility is to change
the initial ‘libtiff’ like so:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 4f249b7622..44d2cac0fe 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -599,7 +599,8 @@ extracting icontainer icon files.")
     `(#:configure-flags (list (string-append "--with-docdir="
                                              (assoc-ref %outputs "doc")
                                              "/share/doc/"
-                                             ,name "-" ,version)
+                                             ,name "-"
+                                             ,(package-version this-package))
                               "--disable-static")))
    (inputs `(("zlib" ,zlib)
              ("libjpeg" ,libjpeg-turbo)))

[Message part 3 (text/plain, inline)]

WDTY?

Would it make sense to adopt this style also for
<https://issues.guix.gnu.org/47108> and
<https://issues.guix.gnu.org/47110>?

(Changing to this style should not trigger any rebuild because it
expands to the exact same thing.)

Thanks,
Ludo’.

Message #16 received at 47107 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 47107 <at> debbugs.gnu.org
Subject: Re: bug#47107: libtiff/fixed uses wrong version number in 'doc' output
Date: Sat, 13 Mar 2021 15:15:03 -0500

On Sat, Mar 13, 2021 at 11:44:27AM +0100, Ludovic Courtès wrote:
> Instead of duplicating the ‘name’ and ‘arguments’ fields as done in
> 35b3ab8e5748d9911ae7a0189065d0c25392895b, one possibility is to change
> the initial ‘libtiff’ like so:
> 

> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
> index 4f249b7622..44d2cac0fe 100644
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -599,7 +599,8 @@ extracting icontainer icon files.")
>      `(#:configure-flags (list (string-append "--with-docdir="
>                                               (assoc-ref %outputs "doc")
>                                               "/share/doc/"
> -                                             ,name "-" ,version)
> +                                             ,name "-"
> +                                             ,(package-version this-package))
>                                "--disable-static")))

That is great, thanks. I will make the adjustments.

Message #19 received at 47107-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 47107-done <at> debbugs.gnu.org
Subject: Re: bug#47107: libtiff/fixed uses wrong version number in 'doc' output
Date: Sun, 14 Mar 2021 16:34:08 -0400

On Sat, Mar 13, 2021 at 11:44:27AM +0100, Ludovic Courtès wrote:
> Instead of duplicating the ‘name’ and ‘arguments’ fields as done in
> 35b3ab8e5748d9911ae7a0189065d0c25392895b, one possibility is to change
> the initial ‘libtiff’ like so:
> 

> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
> index 4f249b7622..44d2cac0fe 100644
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -599,7 +599,8 @@ extracting icontainer icon files.")
>      `(#:configure-flags (list (string-append "--with-docdir="
>                                               (assoc-ref %outputs "doc")
>                                               "/share/doc/"
> -                                             ,name "-" ,version)
> +                                             ,name "-"
> +                                             ,(package-version this-package))
>                                "--disable-static")))
>     (inputs `(("zlib" ,zlib)
>               ("libjpeg" ,libjpeg-turbo)))

> 
> WDTY?
> 
> Would it make sense to adopt this style also for
> <https://issues.guix.gnu.org/47108> and
> <https://issues.guix.gnu.org/47110>?

Done as b082ea9406f19f0d0c296227510256b87fe11e3c

Thanks for the suggestion!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.