GNU bug report logs - #45494
f2fs-tools-static doesn't find uuid.h

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45494 in the body.
You can then email your comments to 45494 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Guix Bugs <bug-guix <at> gnu.org>
Subject: f2fs-tools-static doesn't find uuid.h
Date: Sun, 27 Dec 2020 17:11:45 +0100

According to `git bisect` (which I used for the first time today, so i
might be wrong) the recent f2fs-tools upgrade broke f2fs-tools-static.
I tried debugging it a bit today and so far didn't run across any
obvious causes. I'll take a look again soon-ish.

Message #10 received at 45494-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 45494-done <at> debbugs.gnu.org
Subject: Re: bug#45494: f2fs-tools-static doesn't find uuid.h
Date: Mon, 28 Dec 2020 15:03:50 +0100

[Message part 1 (text/plain, inline)]

Hi,

thanks for the report!

fixed in guix master commit a099d833af3afe69c50dbd016e9ed117462ca7ef.

Analysis:

According to https://linux.die.net/man/3/uuid users of the uuid lib should do:

>#include <uuid/uuid.h>

however, "man uuid" in Guix says to do

(that's from util-linux-2.35.1/libuuid/man/uuid.3)
> #include <uuid.h>

and f2fs-tools does (in mkfs/f2fs_format_main.c:21):

> #include <uuid.h>

I've also checked their git repository at
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/tree/mkfs/f2fs_format_main.c
and they still do:

> #include <uuid.h>

Then I tried

 guix environment --pure f2fs-tools-static --ad-hoc gcc-toolchain

and we have:

echo $C_INCLUDE_PATH
>/gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include

But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid.h does not exist.
But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid/uuid.h does exist.

cat /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/lib/pkgconfig/uuid.pc 

>Cflags: -I${includedir}/uuid

So I'd say that pkg-config is missing.

And indeed I had already worked around that in gnu/packages/linux.scm :

>#:configure-flags
>       (let ((libuuid-static (assoc-ref %build-inputs "libuuid:static"))
>             (libuuid (assoc-ref %build-inputs "libuuid")))
>         (list
>          (string-append "libuuid_CFLAGS=-I" libuuid "/include")

Here, suffix "/uuid" is missing.

>          (string-append "libuuid_LIBS=-L" libuuid-static "/lib -luuid")
>          (string-append "libblkid_CFLAGS=-I" libuuid "/include")

Here, suffix "/uuid" is missing.

Similarly for "/blkid".

>          (string-append "libblkid_LIBS=-L" libuuid-static "/lib -lblkid")

Ok

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.