GNU bug report logs - #44825
Error in reporting guix deploy error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44825 in the body.
You can then email your comments to 44825 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: bug-guix <at> gnu.org
Subject: Error in reporting guix deploy error
Date: Mon, 23 Nov 2020 13:09:42 -0500

Seems strange... the message I get:

  guix deploy: error: failed to deploy tulsi: ~A: ~S

Errors upon errors!  Formatting this time, apparently. :)

Looking at the relevant code:

(define (deploy-machine* store machine)
  "Deploy MACHINE, taking care of error handling."
  (info (G_ "deploying to ~a...~%")
        (machine-display-name machine))

  (guard (c ((message-condition? c)
             (report-error (G_ "failed to deploy ~a: ~a~%")
                           (machine-display-name machine)
                           (condition-message c)))
            ((deploy-error? c)
             (when (deploy-error-should-roll-back c)
               (info (G_ "rolling back ~a...~%")
                     (machine-display-name machine))
               (run-with-store store (roll-back-machine machine)))
             (apply throw (deploy-error-captured-args c))))
    (run-with-store store (deploy-machine machine))

    (info (G_ "successfully deployed ~a~%")
          (machine-display-name machine))))

I looked at other examples of report-error, they seemed similar.. can't
see why this one wouldn't be formatting correctly.  Any idea?

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: bug-guix <at> gnu.org, 44825 <at> debbugs.gnu.org
Subject: Re: bug#44825: Error in reporting guix deploy error
Date: Mon, 23 Nov 2020 13:45:52 -0500

By the way, I did pinpoint out what caused the failure in *deploying*,
but not what caused the error message to not format correctly.

The mistake was:

(modify-services  %desktop-services
        (guix-service-type config =>
                          (guix-configuration
                           (inherit config)
                           (authorized-keys
-                           (append (list (local-file "twig-guix-signing-key.pub"))
+                           (append (list (local-file "../keys/twig-guix-signing-key.pub"))
                                    %default-authorized-guix-keys)))))

So basically I referenced a file that doesn't exist with local-file.

But why would that cause the string formatting to fail?  Dunno...

Christopher Lemmer Webber writes:

> Seems strange... the message I get:
>
>   guix deploy: error: failed to deploy tulsi: ~A: ~S
>
> Errors upon errors!  Formatting this time, apparently. :)
>
> Looking at the relevant code:
>
> (define (deploy-machine* store machine)
>   "Deploy MACHINE, taking care of error handling."
>   (info (G_ "deploying to ~a...~%")
>         (machine-display-name machine))
>
>   (guard (c ((message-condition? c)
>              (report-error (G_ "failed to deploy ~a: ~a~%")
>                            (machine-display-name machine)
>                            (condition-message c)))
>             ((deploy-error? c)
>              (when (deploy-error-should-roll-back c)
>                (info (G_ "rolling back ~a...~%")
>                      (machine-display-name machine))
>                (run-with-store store (roll-back-machine machine)))
>              (apply throw (deploy-error-captured-args c))))
>     (run-with-store store (deploy-machine machine))
>
>     (info (G_ "successfully deployed ~a~%")
>           (machine-display-name machine))))
>
> I looked at other examples of report-error, they seemed similar.. can't
> see why this one wouldn't be formatting correctly.  Any idea?

Message #16 received at 44825-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: 44825-done <at> debbugs.gnu.org
Subject: Re: bug#44825: Error in reporting guix deploy error
Date: Thu, 26 Nov 2020 23:41:31 +0100

Hi Chris,

Christopher Lemmer Webber <cwebber <at> dustycloud.org> skribis:

> Seems strange... the message I get:
>
>   guix deploy: error: failed to deploy tulsi: ~A: ~S
>
> Errors upon errors!  Formatting this time, apparently. :)
>
> Looking at the relevant code:
>
> (define (deploy-machine* store machine)
>   "Deploy MACHINE, taking care of error handling."
>   (info (G_ "deploying to ~a...~%")
>         (machine-display-name machine))
>
>   (guard (c ((message-condition? c)
>              (report-error (G_ "failed to deploy ~a: ~a~%")
>                            (machine-display-name machine)
>                            (condition-message c)))

[...]

I believe this is fixed by 5842239a66683b2f5e36e95da8225e2ab7f7dac3.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.