GNU bug report logs - #44535
grep-3.6 released [stable]

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44535 in the body.
You can then email your comments to 44535 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: bug-grep <at> gnu.org
Subject: Re: grep-3.6 released [stable]
Date: Mon, 09 Nov 2020 17:12:54 +0100

grep 3.6 fails to build:

test-nl_langinfo-mt.c: In function 'threadN_func':
test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type]
  185 | }
      | ^
cc1: some warnings being treated as errors
make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #8 received at 44535 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 44535 <at> debbugs.gnu.org
Subject: Re: bug#44535: grep-3.6 released [stable]
Date: Mon, 9 Nov 2020 08:45:06 -0800

On Mon, Nov 9, 2020 at 8:14 AM Andreas Schwab <schwab <at> suse.de> wrote:
> grep 3.6 fails to build:
>
> test-nl_langinfo-mt.c: In function 'threadN_func':
> test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type]
>   185 | }
>       | ^
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1

Thanks for the report.
Please also tell us which compiler you're using.
Note that for most this would only be a warning.
In order to make it a build-blocking error, you must have run
configure with --enable-gcc-warnings.

Message #11 received at 44535 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: 44535 <at> debbugs.gnu.org
Subject: Re: bug#44535: grep-3.6 released [stable]
Date: Tue, 10 Nov 2020 12:02:49 +0100

https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #14 received at 44535 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 44535 <at> debbugs.gnu.org
Subject: Re: bug#44535: grep-3.6 released [stable]
Date: Thu, 12 Nov 2020 23:39:36 -0800

On 11/9/20 8:12 AM, Andreas Schwab wrote:
> grep 3.6 fails to build:
> 
> test-nl_langinfo-mt.c: In function 'threadN_func':
> test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type]
>    185 | }
>        | ^
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1

We have dueling compilers here, as Sun C complains if the return statements are 
present[1], whereas gcc -Wreturn-type complains if they're absent. Since the 
return statements are clearly bogus and unnecessary I'm inclined to continue to 
omit them.

> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64

This says you're configuring with CFLAGS='... -Werror=return-type ...'. If you 
omit the "-Werror=return-type" option the problem should go away. For 'grep', 
that option is more trouble than it's worth. (Perhaps someone should file a GCC 
bug report....)

For the recommended set of warning options for compiling 'grep', you can use 
'./configure --enable-gcc-warnings' instead.

[1] 
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=bd90572c031a25e559907ae0c2b9fd3aa632893b

Message #17 received at 44535 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Andreas Schwab <schwab <at> suse.de>, 44535 <at> debbugs.gnu.org
Subject: Re: bug#44535: grep-3.6 released [stable]
Date: Fri, 13 Nov 2020 10:27:03 -0800

On Thu, Nov 12, 2020 at 11:40 PM Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> On 11/9/20 8:12 AM, Andreas Schwab wrote:
> > grep 3.6 fails to build:
> >
> > test-nl_langinfo-mt.c: In function 'threadN_func':
> > test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type]
> >    185 | }
> >        | ^
> > cc1: some warnings being treated as errors
> > make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1
>
> We have dueling compilers here, as Sun C complains if the return statements are
> present[1], whereas gcc -Wreturn-type complains if they're absent. Since the
> return statements are clearly bogus and unnecessary I'm inclined to continue to
> omit them.
>
> > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64
>
> This says you're configuring with CFLAGS='... -Werror=return-type ...'. If you
> omit the "-Werror=return-type" option the problem should go away. For 'grep',
> that option is more trouble than it's worth. (Perhaps someone should file a GCC
> bug report....)
>
> For the recommended set of warning options for compiling 'grep', you can use
> './configure --enable-gcc-warnings' instead.
>
> [1]
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=bd90572c031a25e559907ae0c2b9fd3aa632893b

This led me to realize that grep had not enabled warnings on its
compilation of gnulib-tests/.
I've begun to fix that, which has including filing this gcc bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97817

Message #22 received at 44535-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Andreas Schwab <schwab <at> suse.de>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, 44535-done <at> debbugs.gnu.org
Subject: Re: bug#44535: grep-3.6 released [stable]
Date: Sat, 21 Nov 2020 18:15:20 -0800

[Message part 1 (text/plain, inline)]

On 11/12/20 11:39 PM, Paul Eggert wrote:
> We have dueling compilers here, as Sun C complains if the return statements are 
> present[1], whereas gcc -Wreturn-type complains if they're absent. Since the 
> return statements are clearly bogus and unnecessary I'm inclined to continue to 
> omit them.

I looked into this some more, and found out that it's a known GCC bug. I 
installed the attached patch into Gnulib to work around the bug. Thanks for 
reporting the problem.

[0001-nl_langinfo-tests-work-around-GCC-bug-44511.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.