GNU bug report logs - #44458
Regenerating testsuite-part.am when a new test case is added

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44458 in the body.
You can then email your comments to 44458 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-automake <bug-automake <at> gnu.org>
Subject: Regenerating testsuite-part.am when a new test case is added
Date: Thu, 5 Nov 2020 01:39:47 +0000

[Message part 1 (text/plain, inline)]

Or, bug #11347 again.

I just spent quite a while chasing down a test failure that was due to
testsuite-part.am not being remade when new tests were added.

I duly found bug #11347, which contains a rationale for not having
testsuite-part.am depend on all the tests.

However, the rationale doesn't seem to explain the reason for removing the
dependency on the *list* of tests. In particular, without depending on
list-of-tests.mk, the dependencies of new tests are not extracted
automatically, and so tests that depend on other tests can be run in the
wrong order (this was exactly my case: I had two new tests that both
depended on pkg-config).

Could the dependency of testsuite-part.am on list-of-tests.mk be reinstated?
-- 
https://rrt.sc3d.org

[Message part 2 (text/html, inline)]

Message #8 received at 44458 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: rrt <at> sc3d.org
Cc: 44458 <at> debbugs.gnu.org
Subject: Re: bug#44458: Regenerating testsuite-part.am when a new test case is
 added
Date: Sat, 7 Nov 2020 19:13:10 -0700

[Message part 1 (text/plain, inline)]

    without depending on list-of-tests.mk, the dependencies of new tests
    are not extracted automatically, and so tests that depend on other
    tests can be run in the wrong order

Indeed. For the record (as Reuben already knows :), I was seeing the
same unpredictable behavior wrt the new vala tests (in #13002) not
finding pkg-config.

Thus I have pushed the following change to try to revert that part of
the #11347 change. Fingers crossed.

Thanks much. -k

[testsuite-dependencies.diff (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.