GNU bug report logs - #43683
make install-exec does not trigger make $(BUILT_SOURCES)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43683 in the body.
You can then email your comments to 43683 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: madmurphy <madmurphy333 <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: make install-exec does not trigger make $(BUILT_SOURCES)
Date: Mon, 28 Sep 2020 23:34:54 +0100

[Message part 1 (text/plain, inline)]

I have a project that relies on automatically-built sources, therefore I
have created a BUILT_SOURCES variable in my src/Makefile.am file (see GNU
Automake § 9.4 Built Sources
<https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html>).
Everything works perfectly, however I have noticed that if I launch make
install before launching make all the sources are correctly built, but the
same does not happen if I launch make install-exec before launching make all.
So I have examined the generated src/Makefile, and I have found the reason.

Currently src/Makefile.am generates the following code in src/Makefile:

install: $(BUILT_SOURCES)
        $(MAKE) $(AM_MAKEFLAGS) install-am

install-exec: install-exec-am

Evidently install and install-exec are treated differently, and the second
one does not build any source. I believe that the correct generated code
for src/Makefile should be instead:

install: $(BUILT_SOURCES)
        $(MAKE) $(AM_MAKEFLAGS) install-am

install-exec: $(BUILT_SOURCES)
        $(MAKE) $(AM_MAKEFLAGS) install-exec-am

Cheers and thanks, GNU folks, for your incredible work.

--madmurphy

[Message part 2 (text/html, inline)]

Message #8 received at 43683 <at> debbugs.gnu.org (full text, mbox):

From: madmurphy <madmurphy333 <at> gmail.com>
To: 43683 <at> debbugs.gnu.org
Subject: Re: make install-exec does not trigger make $(BUILT_SOURCES)
Date: Tue, 29 Sep 2020 01:19:55 +0100

[Message part 1 (text/plain, inline)]

Please find attached a patch that solves the problem.

--madmurphy

Il giorno lun 28 set 2020 alle ore 23:34 madmurphy <madmurphy333 <at> gmail.com>
ha scritto:

> I have a project that relies on automatically-built sources, therefore I
> have created a BUILT_SOURCES variable in my src/Makefile.am file (see GNU
> Automake § 9.4 Built Sources
> <https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html>).
> Everything works perfectly, however I have noticed that if I launch make
> install before launching make all the sources are correctly built, but
> the same does not happen if I launch make install-exec before launching make
> all. So I have examined the generated src/Makefile, and I have found the
> reason.
>
> Currently src/Makefile.am generates the following code in src/Makefile:
>
> install: $(BUILT_SOURCES)
>         $(MAKE) $(AM_MAKEFLAGS) install-am
>
> install-exec: install-exec-am
>
> Evidently install and install-exec are treated differently, and the
> second one does not build any source. I believe that the correct generated
> code for src/Makefile should be instead:
>
> install: $(BUILT_SOURCES)
>         $(MAKE) $(AM_MAKEFLAGS) install-am
>
> install-exec: $(BUILT_SOURCES)
>         $(MAKE) $(AM_MAKEFLAGS) install-exec-am
>
> Cheers and thanks, GNU folks, for your incredible work.
>
> --madmurphy
>

[Message part 2 (text/html, inline)]

[patch.tar.xz (application/x-xz, attachment)]

Message #11 received at 43683 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: madmurphy333 <at> gmail.com
Cc: automake-patches <at> gnu.org, 43683 <at> debbugs.gnu.org
Subject: Re: bug#43683: make install-exec does not trigger make
 $(BUILT_SOURCES)
Date: Tue, 6 Oct 2020 19:18:55 -0600

Hi madmurphy,

    install-exec: $(BUILT_SOURCES)
            $(MAKE) $(AM_MAKEFLAGS) install-exec-am

Thanks very much for the bug report, patch, and test case. I just
applied and pushed it, with small modifications. Please report back if
problems persist. Meanwhile, closing this bug. Thanks again! --karl

Message #19 received at 43683 <at> debbugs.gnu.org (full text, mbox):

From: madmurphy <madmurphy333 <at> gmail.com>
To: Karl Berry <karl <at> freefriends.org>
Cc: automake-patches <at> gnu.org, 43683 <at> debbugs.gnu.org
Subject: Re: bug#43683: make install-exec does not trigger make
 $(BUILT_SOURCES)
Date: Fri, 9 Oct 2020 16:07:22 +0100

[Message part 1 (text/plain, inline)]

Thank you Karl!

Il giorno mer 7 ott 2020 alle ore 02:18 Karl Berry <karl <at> freefriends.org>
ha scritto:

> Hi madmurphy,
>
>     install-exec: $(BUILT_SOURCES)
>             $(MAKE) $(AM_MAKEFLAGS) install-exec-am
>
> Thanks very much for the bug report, patch, and test case. I just
> applied and pushed it, with small modifications. Please report back if
> problems persist. Meanwhile, closing this bug. Thanks again! --karl
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.