GNU bug report logs - #42789
Linux-libre 'deblob-check' file-names do not include a version number

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42789 in the body.
You can then email your comments to 42789 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, bug-guix <at> gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Sun, 9 Aug 2020 21:59:31 -0400

On Sun, Aug 09, 2020 at 06:17:48PM -0400, Mark H Weaver wrote:
> If the file name and hash matches a previously downloaded file in your
> store, the guix daemon uses that one and skips the download, regardless
> of the URL.  That's why no error was reported.  There's no version
> number in the file name of the 'deblob-check' file.

We should try to make these files include the version number to avoid
this kind of mistake in the future.

I've CC-ed bug-guix so that we don't forget.

Message #10 received at 42789 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 42789 <at> debbugs.gnu.org
Subject: Re: Linux-libre 'deblob-check' file-names do not include a version
 number
Date: Mon, 10 Aug 2020 13:16:36 -0400

[Message part 1 (text/plain, inline)]

I've attached a patch that should prevent this kind of mistake in the
future.

We should queue it up to be pushed with the next kernel updates (on the
kernel-updates branch).

[0001-gnu-Use-a-descriptive-file-name-for-linux-libre-debl.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 42789 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 42789 <at> debbugs.gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Mon, 10 Aug 2020 23:46:34 -0400

Hi Leo,

Leo Famulari <leo <at> famulari.name> wrote:
> On Sun, Aug 09, 2020 at 06:17:48PM -0400, Mark H Weaver wrote:
>> If the file name and hash matches a previously downloaded file in your
>> store, the guix daemon uses that one and skips the download, regardless
>> of the URL.  That's why no error was reported.  There's no version
>> number in the file name of the 'deblob-check' file.
>
> We should try to make these files include the version number to avoid
> this kind of mistake in the future.

That's a good idea.  In a later message you posted a proposed patch:

> From e9ca6405e351baf4356a7300aa252d25056a322c Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo <at> famulari.name>
> Date: Mon, 10 Aug 2020 12:40:49 -0400
> Subject: [PATCH] gnu: Use a descriptive file-name for linux-libre
>  'deblob-check' scripts.
> 
> Fixes <https://bugs.gnu.org/42789>.
> 
> * gnu/packages/linux.scm (linux-libre-deblob-scripts): Use file-name for
> the deblob-check script.
> ---
>  gnu/packages/linux.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index a2d6d384ee..9d553e7772 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -200,6 +200,7 @@ defconfig.  Return the appropriate make target if applicable, otherwise return
>            (uri (string-append "https://linux-libre.fsfla.org"
>                                "/pub/linux-libre/releases/" version "-gnu/"
>                                "deblob-check"))
> +          (file-name (string-append "linux-libre-" version "-deblob-check"))
>            (sha256 deblob-check-hash))))
>  
>  (define deblob-scripts-5.8

If we're going to prefix "linux-libre-" to the name, which I agree is a
good idea, maybe we should add the same prefix to the other 'deblob'
script, for consistency.  Also for consistency, I think the version
number should be at the end, after "deblob-check", as is the case for
the other deblob script.

There's also the question of whether the micro version number should be
included in the file name.  In practice, these deblob scripts almost
never change from one micro version to the next.  Also, I suspect
(although I've not yet confirmed it) that these deblob scripts likely
work for older kernels in the same stable series.

For those reasons, at present the micro version number appears only in
the URLs, and not in either the file names or in the version number as
recorded in the first element of the triplet returned by
'linux-libre-deblob-scripts'.  I'd personally be inclined to keep it
that way, although I don't feel strongly about it.

What do you think?

      Thanks,
        Mark

Message #16 received at 42789 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 42789 <at> debbugs.gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Tue, 11 Aug 2020 18:46:01 -0400

[Message part 1 (text/plain, inline)]

On Mon, Aug 10, 2020 at 11:46:34PM -0400, Mark H Weaver wrote:
> If we're going to prefix "linux-libre-" to the name, which I agree is a
> good idea, maybe we should add the same prefix to the other 'deblob'
> script, for consistency.  Also for consistency, I think the version
> number should be at the end, after "deblob-check", as is the case for
> the other deblob script.
>
> There's also the question of whether the micro version number should be
> included in the file name.  In practice, these deblob scripts almost
> never change from one micro version to the next.  Also, I suspect
> (although I've not yet confirmed it) that these deblob scripts likely
> work for older kernels in the same stable series.
> 
> For those reasons, at present the micro version number appears only in
> the URLs, and not in either the file names or in the version number as
> recorded in the first element of the triplet returned by
> 'linux-libre-deblob-scripts'.  I'd personally be inclined to keep it
> that way, although I don't feel strongly about it.

Good ideas. I've taken them into account on my local branch while I test
building the final tarballs. I'll push to the kernel-updates branch once
I am satisfied with the result.

Thanks for your feedback!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 42789 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 42789 <at> debbugs.gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Tue, 11 Aug 2020 23:24:40 -0400

[Message part 1 (text/plain, inline)]

On Tue, Aug 11, 2020 at 06:46:01PM -0400, Leo Famulari wrote:
> Good ideas. I've taken them into account on my local branch while I test
> building the final tarballs. I'll push to the kernel-updates branch once
> I am satisfied with the result.

I've pushed an updated patch to the kernel-updates branch:

https://git.savannah.gnu.org/cgit/guix.git/commit/?h=kernel-updates&id=387446c93261868bd4c4188687b508aa0a2da7e8

It will be built on the build farm here, based on commit b1f5568b1:

https://ci.guix.gnu.org/jobset/kernel-updates

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 42789 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 42789 <at> debbugs.gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Wed, 12 Aug 2020 17:34:21 -0400

Leo Famulari <leo <at> famulari.name> wrote:

> I've pushed an updated patch to the kernel-updates branch:
> 
> https://git.savannah.gnu.org/cgit/guix.git/commit/?h=kernel-updates&id=387446c93261868bd4c4188687b508aa0a2da7e8

Looks good to me.  Thank you!

       Mark

Message #27 received at 42789-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 42789-done <at> debbugs.gnu.org
Subject: Re: Linux-libre 5.8 and beyond
Date: Fri, 21 Aug 2020 18:02:19 -0400

On Wed, Aug 12, 2020 at 05:34:21PM -0400, Mark H Weaver wrote:
> Leo Famulari <leo <at> famulari.name> wrote:
> 
> > I've pushed an updated patch to the kernel-updates branch:
> > 
> > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=kernel-updates&id=387446c93261868bd4c4188687b508aa0a2da7e8
> 
> Looks good to me.  Thank you!

Pushed as 1bc275034fe8070c720ca341db2d9588480aa044

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.