GNU bug report logs - #41620
[PATCH] gnu: python-astroid: Update to 2.4.1.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Sat, 30 May 2020 20:39:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41620 in the body.
You can then email your comments to 41620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41620; Package guix-patches. (Sat, 30 May 2020 20:39:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Michael Rohleder <mike <at> rohleder.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 30 May 2020 20:39:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-astroid: Update to 2.4.1.
Date: Sat, 30 May 2020 22:37:53 +0200
[Message part 1 (text/plain, inline)]
on current (8e3a1a62ae) master, gnome doesnt build, because totem tests
fail.
in order to fix this, i tried adding python-toml and python-astroid to
native-inputs of totem.
then the tests fail, because python-astroid seems to old, so here is a
patch for that.
now, the tests still fail, but we might be a small step closer... ;)

I only tested this lightly with building the other 3 deps:
"python-language-server rtv tuir" and python2-astroid.

[0001-gnu-python-astroid-Update-to-2.4.1.patch (text/x-patch, inline)]
From 7b4e21f9709b642f20695c9ea6a8e512baa808da Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sat, 30 May 2020 21:27:49 +0200
Subject: [PATCH] gnu: python-astroid: Update to 2.4.1.

* gnu/packages/python-xyz.scm (python-astroid): Update to 2.4.1.
---
 gnu/packages/python-xyz.scm | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index baec999247..79816ddc2f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -80,6 +80,7 @@
 ;;; Copyright © 2020 Ryan Prior <rprior <at> protonmail.com>
 ;;; Copyright © 2020 Josh Holland <josh <at> inv.alid.pw>
 ;;; Copyright © 2020 Yuval Kogman <nothingmuch <at> woobling.org>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13905,13 +13906,13 @@ clone, while other processes access the original tree.")
 (define-public python-astroid
   (package
     (name "python-astroid")
-    (version "2.3.3")
+    (version "2.4.1")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "astroid" version))
        (sha256
-        (base32 "0fnibsl2cb5mvzbfm7sycj85smx48f8w8m7ks1sqlmpr9ps0gski"))))
+        (base32 "1h99jal7ax07xna1djw5z7hpgb8vjrl3hrrg49p1phljwniww5sc"))))
     (build-system python-build-system)
     (propagated-inputs
      `(("python-lazy-object-proxy" ,python-lazy-object-proxy)
@@ -13923,19 +13924,6 @@ clone, while other processes access the original tree.")
        ("python-nose" ,python-nose)
        ("python-pytest" ,python-pytest)
        ("python-pytest-runner" ,python-pytest-runner)))
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'remove-spurious-test
-           (lambda _
-             ;; This can be removed after upgrading from python-3.7
-             ;; https://github.com/PyCQA/astroid/issues/593
-             ;; https://bugs.python.org/issue34056
-             (delete-file "astroid/tests/unittest_modutils.py")
-             #t))
-         (replace 'check
-           (lambda _
-             (invoke "pytest" "astroid"))))))
     (home-page "https://github.com/PyCQA/astroid")
     (synopsis "Common base representation of python source code for pylint and
 other projects")
-- 
2.26.2

[Message part 3 (text/plain, inline)]
-- 
Life's too short to do DOS support.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Marius Bakke <marius <at> gnu.org>:
You have taken responsibility. (Sat, 30 May 2020 21:16:02 GMT) Full text and rfc822 format available.

Notification sent to Michael Rohleder <mike <at> rohleder.de>:
bug acknowledged by developer. (Sat, 30 May 2020 21:16:02 GMT) Full text and rfc822 format available.

Message #10 received at 41620-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>, 41620-done <at> debbugs.gnu.org
Subject: Re: [bug#41620] [PATCH] gnu: python-astroid: Update to 2.4.1.
Date: Sat, 30 May 2020 23:15:37 +0200
[Message part 1 (text/plain, inline)]
Michael Rohleder <mike <at> rohleder.de> writes:

> on current (8e3a1a62ae) master, gnome doesnt build, because totem tests
> fail.
> in order to fix this, i tried adding python-toml and python-astroid to
> native-inputs of totem.
> then the tests fail, because python-astroid seems to old, so here is a
> patch for that.
> now, the tests still fail, but we might be a small step closer... ;)

Uff, thanks for the heads-up, I have reverted the pylint update.

> I only tested this lightly with building the other 3 deps:
> "python-language-server rtv tuir" and python2-astroid.

Heh, that's what I did too because I did not have WebKitGTK readily
available for testing the Totem build.  ;-)

However now I do, and can confirm that Totem still builds with this
patch.

I also added a follow-up patch to remove the unused nose and typing-ast
inputs.

Applied!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 28 Jun 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.