GNU bug report logs - #41282
doc: dot graphs display square glyphs instead of letters

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41282 in the body.
You can then email your comments to 41282 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: bug-guix <at> gnu.org
Subject: doc: dot graphs display square glyphs instead of letters
Date: Fri, 15 May 2020 12:23:33 +0200

[Message part 1 (text/plain, inline)]

See for instance "12.1 The Reduced Binary Seed Bootstrap".
Commit 7bba5425473b5d193946e537de77c631ae6c3667.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, 41282 <at> debbugs.gnu.org
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 12:50:58 +0200

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> See for instance "12.1 The Reduced Binary Seed Bootstrap".
> Commit 7bba5425473b5d193946e537de77c631ae6c3667.

I can not reproduce this.  What is the exact command you are running?

Do you have any fonts installed?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Marius Bakke <mbakke <at> fastmail.com>, 41282 <at> debbugs.gnu.org
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 13:48:14 +0200

[Message part 1 (text/plain, inline)]

Recipe in Emacs:

- C-h i
- m Guix RET
- i bootstrap RET
- m Reduced Binary Seed Bootstrap

> Do you have any fonts installed?

I have font-dejavu, that's it.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 15:53:20 +0200

Hi Pierre,

I do not see an issue a Marius.  "I have font-dejavu, that's it", too.
But I am not sure to understand which manual built with which commit
you are talking about.

Cheers,
simon

Message #17 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 16:13:52 +0200

[Message part 1 (text/plain, inline)]

The Guix manual from commit 7bba5425473b5d193946e537de77c631ae6c3667.

I can reproduce the issue with

--8<---------------cut here---------------start------------->8---
env INFOPATH=$HOME/.config/guix/current/share/info emacs
--8<---------------cut here---------------end--------------->8---

The dot figures are generated during the Guix build I guess.  Something
odd is happening.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 16:45:12 +0200

[Message part 1 (text/plain, inline)]

Sorry, I wrong commit.  Guix commit is
afc46f22672eb3218fbd1e567f85fc6367286461.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 17:02:51 +0200

On Fri, 15 May 2020 at 16:45, Pierre Neidhardt <mail <at> ambrevar.xyz> wrote:

> Sorry, I wrong commit.  Guix commit is
> afc46f22672eb3218fbd1e567f85fc6367286461.

Now I see it! :-)

 guix pull --commit=afc46f2 -p /tmp/pierre
 emacs -q
 C-u C-h i /tmp/pierre/share/info/guix.info.gz RET
 i bootstrap RET
 m Reduced Binary Seed Bootstrap RET

With font-dejavu.


Cheers,
simon

Message #26 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 17:32:28 +0200

[Message part 1 (text/plain, inline)]

Are you saying you can reproduce the issue?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 17:36:22 +0200

On Fri, 15 May 2020 at 17:32, Pierre Neidhardt <mail <at> ambrevar.xyz> wrote:
>
> Are you saying you can reproduce the issue?

Yes. It is between 2c8305d and afc46f2.

Message #32 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 41282 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#41282: doc: dot graphs display square glyphs instead of
 letters
Date: Fri, 15 May 2020 20:13:30 +0200

     guix pull --commit=afc46f2 -p /tmp/broken

then /tmp/broken/share/info/images/bootstrap-graph.png does not
contains the right font.


Reproduced with a local checkout even if the
/path/to/checkout/doc/images/*.png are right.  However, it is not when
it is pulled:

   ./pre-env-inst guix pull --branch=master --url=$PWD -p /tmp/test

then /tmp/test/share/info/images/bootstrap-graph.png does not have the
right font.

I do not know where it comes from and my machine is not enough
powerful to bisect.

Message #35 received at 41282 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41282 <at> debbugs.gnu.org, Pierre Neidhardt <mail <at> ambrevar.xyz>
Subject: bug#41282: share/info/images/*.png broken
Date: Sat, 16 May 2020 16:03:35 +0200

Dear Marius,

I do not know if it is a bug or if I misconfigured something but some
images under 'share/info/images' are "broken" for some commits, as if
the font is missing.  Because it is 'png' files, it is not related on
the presence or absence of such fonts on my machine, I guess.  Or do I
misunderstand something?  And if it is, why for some commits it
displays nicely and other not.


When I run:

  guix pull --commit=2c8305d -p /tmp/good

then 'display /tmp/good/share/info/images/bootstrap-graph.png'
displays nicely.  However, when I run:

  guix pull --commit=afc46f2 -p /tmp/bad

'display /tmp/bad/share/info/images/bootstrap-graph.png' is not nice,
as if the font is missing.


Well, I suspect it comes from something related to the recent
'core-updates'.  To underline my point, I run this script:

--8<---------------cut here---------------start------------->8---
SRC=/tmp/guix/

MERGE=/tmp/check/merge
LEFT=/tmp/check/left
RIGHT=/tmp/check/right

mkdir -p $MERGE
mkdir -p $LEFT
mkdir -p $RIGHT

for merge in $(git -C $SRC \
                log 2c8305d..afc46f2 \
                --ancestry-path --merges \
                --format="%h")
do
    left=$(git -C $SRC log $merge --format="%p" -n1 | cut -f1 -d' ')
    right=$(git -C $SRC log $merge --format="%p" -n1 | cut -f2 -d' ')

    echo $merge
    guix pull --commit=$merge -p${MERGE}/$merge

    echo $left
    guix pull --commit=$left -p${LEFT}/$left

    echo $right
    guix pull --commit=$right -p${RIGHT}/$right
done
--8<---------------cut here---------------end--------------->8---

which basically pull all the commits corresponding to merges between
the "working" commit and the "broken" commit.  And pull the two parent
commits too.

Based on that, all the merged commits are "broken".  The image
'share/info/images/bootstrap-graph.png' displays uglily for the
commits:

4bdf4182fe
50e6c1bf2e
87a40d7203
8bf8cd9b85
c263cfdcde
f589cbc4dc

Then the "left" are all broken too, except the commit c81457a588.
All the "right" are ok, except the commit 23a59b180b.

Note that these two corresponds to the last core-updates merge:

    git log 4bdf4182fe --format="%h %p %n %s" -n1

as if they were switched.


Last, I have checked the commits:

35c43fcdbb
4ba425060a
45c137e30f
7b07852ddb
2676579dc8

which are the ones just next after the core-updates merge ones and
they appear displaying ugly.


If I misunderstand or misconfigure something, please tell me and I
could correct why I am seeing good images and bad images.
Otherwise, I do not have an idea why it should come from.


Best regards,
simon

Message #42 received at 41282-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: guix-devel <at> gnu.org
Subject: Re: [PATCH] gnu: fontconfig: Add replacement with font-dejavu instead
 of gs-fonts.
Date: Thu, 21 May 2020 00:00:39 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sun, May 17, 2020 at 04:50:12PM +0200, Marius Bakke wrote:
>> This is a hack to make (some) fonts working when users don't have fonts
>> specified in their system configuration, and (crucially) places where
>> the fontconfig cache may be unavailable such as 'guix pack's.
>> 
>> I'm not sure whether font-dejavu is a good replacement here.  Another
>> approach could be to convert gs-fonts to TrueType or OpenType format.
>> 
>> Thoughts?  I don't know much about fonts and would appreciate feedback.
>
> I think you should push right away, assuming that it helps and doesn't
> rebuild the world.

I pushed the patch as ab9de8cfb0525ef43668712ac898707f97f9a620.

I verified that it fixes the immediate problem with fonts in the Guix
manual (#41282) as well as 'guix pack' (#41344).  It should also provide
a decent fallback for cases where the user did not explicitly install
any fonts such as in #41241.

Hoping for angry reports now about why such a poor replacement font was
chosen.  ;-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.