GNU bug report logs - #40806
xorg-configuration->file doesn't honor xorg-configuration-server

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40806 in the body.
You can then email your comments to 40806 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: bug-guix <at> gnu.org
Subject: xorg-configuration->file doesn't honor xorg-configuration-server
Date: Thu, 23 Apr 2020 20:14:51 -0500

Suppose that one specifies a custom xorg-server package to use in an
<xorg-configuration> record, like so:

(xorg-configuration
 (server xorg-server-for-debugging))

the correct bin/X will be run, but the wrong modules will be specified
in xserver.conf - the default xorg-server will always be used for
these. This is because in gnu/services/xorg.scm, in
xorg-configuration->file, we simply hard-code xorg-server to refer to
the one from (gnu packages xorg) and ignore the one specified in the
configuration entirely.

We shouldn't do this. It should be enough to just wrap the current
contents with

(let ((xorg-server (xorg-configuration-server config)))
  ...)

to make it work.

Then I can improve my xorg bug report :-)

- reepca

Message #8 received at 40806 <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: 40806 <at> debbugs.gnu.org
Subject: Re: bug#40806: xorg-configuration->file doesn't honor
 xorg-configuration-server
Date: Tue, 02 Jun 2020 07:01:04 -0500

[Message part 1 (text/plain, inline)]

If it helps, here's a patch that makes the trivial change.

- reepca

[0001-xorg-honor-xorg-configuration-server-in-xorg-configu.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40806 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
Cc: 40806 <at> debbugs.gnu.org
Subject: Re: bug#40806: xorg-configuration->file doesn't honor
 xorg-configuration-server
Date: Thu, 04 Jun 2020 14:11:36 +0200

Hi,

Caleb Ristvedt <caleb.ristvedt <at> cune.org> skribis:

> From e1071c830ce511eecd57617a3f188740fd49d703 Mon Sep 17 00:00:00 2001
> From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
> Date: Tue, 2 Jun 2020 06:28:46 -0500
> Subject: [PATCH] xorg: honor xorg-configuration-server in
>  xorg-configuration->file

Please add “Fixes <https://bugs.gnu.org/40806>.”

> Previously the xorg-server package specified in the configuration was ignored
> entirely in xorg-configuration->file.  This had the effect that while the X
> program of the configured package would be executed, the modules of the
> configured package would be ignored in favor of the default xorg-server
> package's modules.  This fixes that.
>
> * gnu/services/xorg.scm (xorg-configuration->file): honor
>   xorg-configuration-server.

LGTM, thanks!

Ludo’.

Message #14 received at 40806 <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40806 <at> debbugs.gnu.org
Subject: Re: bug#40806: xorg-configuration->file doesn't honor
 xorg-configuration-server
Date: Thu, 04 Jun 2020 07:33:33 -0500

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Caleb Ristvedt <caleb.ristvedt <at> cune.org> skribis:
>
>> From e1071c830ce511eecd57617a3f188740fd49d703 Mon Sep 17 00:00:00 2001
>> From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
>> Date: Tue, 2 Jun 2020 06:28:46 -0500
>> Subject: [PATCH] xorg: honor xorg-configuration-server in
>>  xorg-configuration->file
>
> Please add “Fixes <https://bugs.gnu.org/40806>.”

Done.

>> Previously the xorg-server package specified in the configuration was ignored
>> entirely in xorg-configuration->file.  This had the effect that while the X
>> program of the configured package would be executed, the modules of the
>> configured package would be ignored in favor of the default xorg-server
>> package's modules.  This fixes that.
>>
>> * gnu/services/xorg.scm (xorg-configuration->file): honor
>>   xorg-configuration-server.
>
> LGTM, thanks!

Pushed as 8b158e8b2cd0293eeebe73f5a71f0c513a89d606.

- reepca

Message #19 received at 40806-done <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: 40806-done <at> debbugs.gnu.org
Subject: done
Date: Thu, 04 Jun 2020 07:34:06 -0500

done

Message #22 received at 40806-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
Cc: 40806-done <at> debbugs.gnu.org
Subject: Re: bug#40806: xorg-configuration->file doesn't honor
 xorg-configuration-server
Date: Fri, 05 Jun 2020 18:10:47 +0200

Caleb Ristvedt <caleb.ristvedt <at> cune.org> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hi,
>>
>> Caleb Ristvedt <caleb.ristvedt <at> cune.org> skribis:
>>
>>> From e1071c830ce511eecd57617a3f188740fd49d703 Mon Sep 17 00:00:00 2001
>>> From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
>>> Date: Tue, 2 Jun 2020 06:28:46 -0500
>>> Subject: [PATCH] xorg: honor xorg-configuration-server in
>>>  xorg-configuration->file
>>
>> Please add “Fixes <https://bugs.gnu.org/40806>.”
>
> Done.
>
>>> Previously the xorg-server package specified in the configuration was ignored
>>> entirely in xorg-configuration->file.  This had the effect that while the X
>>> program of the configured package would be executed, the modules of the
>>> configured package would be ignored in favor of the default xorg-server
>>> package's modules.  This fixes that.
>>>
>>> * gnu/services/xorg.scm (xorg-configuration->file): honor
>>>   xorg-configuration-server.
>>
>> LGTM, thanks!
>
> Pushed as 8b158e8b2cd0293eeebe73f5a71f0c513a89d606.

Great, closing!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.