GNU bug report logs - #40604
http-parser 2.9.4 fails to build on armhf-linux

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40604 in the body.
You can then email your comments to 40604 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: bug-guix <at> gnu.org
Subject: http-parser 2.9.4 fails to build on armhf-linux
Date: Mon, 13 Apr 2020 20:16:11 +0200

[Message part 1 (text/plain, inline)]

The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
causes a test failure armhf-linux:

--8<---------------cut here---------------start------------->8---
starting phase `check'
gcc  -I. -DHTTP_PARSER_STRICT=1  -Wall -Wextra -Werror -O0 -g  -c http_parser.c -o http_parser_g.o
gcc  -I. -DHTTP_PARSER_STRICT=1  -Wall -Wextra -Werror -O0 -g  -c test.c -o test_g.o
gcc  -I. -DHTTP_PARSER_STRICT=0  -Wall -Wextra -Werror -O3  -c http_parser.c
gcc  -I. -DHTTP_PARSER_STRICT=0  -Wall -Wextra -Werror -O3  -c test.c -o test.o
gcc  -shared -Wl,-soname=libhttp_parser.so.2.9 -o libhttp_parser.so.2.9.4 libhttp_parser.o
gcc -Wall -Wextra -Werror -O0 -g   http_parser_g.o test_g.o -o test_g
gcc -Wall -Wextra -Werror -O3   http_parser.o test.o -o test_fast
./test_g
test_g: test.c:4237: main: Assertion `sizeof(http_parser) == 4 + 4 + 8 + 2 + 2 + 4 + sizeof(void *)' failed.
make: *** [Makefile:76: test] Aborted

Test suite failed, dumping logs.
command "make" "test" "-j" "4" "PREFIX=/gnu/store/qlis9jzgcdk1m48hjdzag6gij244cwvz-http-parser-2.9.4" "CC=gcc" "library" failed with status 2
builder for `/gnu/store/gzywh6bmn10ip49yklmiagsjfcr2jflf-http-parser-2.9.4.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

The assert is new in 2.9.4 (one of two commits since 2.9.3):

https://github.com/nodejs/http-parser/commit/714cbb2dfbea9a521960b82b6239a991a64e3b9a

I can't tell what causes the size difference on armhf and don't
currently have access to hardware or QEMU for testing.  Any takers?

Meanwhile I've reverted the commit on 'master' as this is a dependency
of libgit2 which is needed for 'guix pull'.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40604 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 40604 <at> debbugs.gnu.org
Subject: Re: bug#40604: http-parser 2.9.4 fails to build on armhf-linux
Date: Mon, 13 Apr 2020 20:25:55 +0200

[Message part 1 (text/plain, inline)]

Marius,

Marius Bakke 写道：
> The update to http-parser in 
> 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

[…]

> Meanwhile I've reverted the commit on 'master' as this is a 
> dependency
> of libgit2 which is needed for 'guix pull'.

Thank you!

> I can't tell what causes the size difference on armhf and don't
> currently have access to hardware or QEMU for testing.  Any 
> takers?

No access to Qemu?  That's no fun.

I'm going to punt: debugging an arch I know nothing about is an 
inefficient of time.  I only waste my time efficiently.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40604 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40604 <at> debbugs.gnu.org
Subject: Re: bug#40604: http-parser 2.9.4 fails to build on armhf-linux
Date: Thu, 21 May 2020 12:53:04 +0200

Marius Bakke <mbakke <at> fastmail.com> writes:

> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

The same test failure happens on i686-linux.

-- 
Ricardo

Message #14 received at 40604 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40604 <at> debbugs.gnu.org
Subject: Re: bug#40604: http-parser 2.9.4 fails to build on armhf-linux
Date: Thu, 21 May 2020 12:54:54 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
>> causes a test failure armhf-linux:
>
> The same test failure happens on i686-linux.

Actually, this might be a different failure:

    test_g: test.c:4240: main: Assertion `sizeof(http_parser) == 32' failed.

This prevents me from running “guix pull” on my i686 machines.

-- 
Ricardo

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 40604-done <at> debbugs.gnu.org,
 bug-guix <at> gnu.org
Subject: Re: bug#40604: http-parser 2.9.4 fails to build on armhf-linux
Date: Thu, 21 May 2020 16:45:37 +0200

[Message part 1 (text/plain, inline)]

Ricardo, Marius,

Ricardo Wurmus 写道：
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>>> The update to http-parser in 
>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>> causes a test failure armhf-linux:
>>
>> The same test failure happens on i686-linux.
>
> Actually, this might be a different failure:
>
>     test_g: test.c:4240: main: Assertion `sizeof(http_parser) == 
>     32' failed.

Neither, or both, or whatever.  It's the fix for the armhf failure 
(5c30eb61) that in turn causes a failure on i686 because there the 
struct *is* a mere 28 bytes.

Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the 
fix only on armhf.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 40604-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 40604-done <at> debbugs.gnu.org
Subject: Re: bug#40604: http-parser 2.9.4 fails to build on armhf-linux
Date: Thu, 21 May 2020 22:07:41 +0200

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Ricardo, Marius,
>
> Ricardo Wurmus 写道：
>>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>>
>>>> The update to http-parser in
>>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>>> causes a test failure armhf-linux:
>>>
>>> The same test failure happens on i686-linux.
>>
>> Actually, this might be a different failure:
>>
>>     test_g: test.c:4240: main: Assertion `sizeof(http_parser) ==
>> 32' failed.
>
> Neither, or both, or whatever.  It's the fix for the armhf failure
> (5c30eb61) that in turn causes a failure on i686 because there the
> struct *is* a mere 28 bytes.
>
> Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the fix
> only on armhf.

Thank you!  That got me past “guix pull” on my i686-linux netbook.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.