GNU bug report logs - #39737
[PATCH] gnu: qemu-minimal-2.10: Use minimal dependencies from qemu-minimal.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39737 in the body.
You can then email your comments to 39737 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: qemu-minimal-2.10: Use minimal dependencies from
 qemu-minimal.
Date: Sat, 22 Feb 2020 15:35:25 +0100

Without this patch qemu-minimal-2.10 is not really minimal; it depends on
cups, ffmpeg, ghostscript, gstreamer, gtk, spice, ...

* gnu/packages/virtualization.scm (qemu-minimal-2.10): Use minimal
dependencies from qemu-minimal.
---
 gnu/packages/virtualization.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index d3f474d17a..b8d85e03a4 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -303,10 +303,10 @@ server and embedded PowerPC, and S390 guests.")
               (search-patches "qemu-glibc-2.27.patch"))))
     ;; qemu-minimal-2.10 needs Python 2. Remove below once no longer necessary.
     (native-inputs `(("python-2" ,python-2)
-                     ,@(fold alist-delete (package-native-inputs qemu)
+                     ,@(fold alist-delete (package-native-inputs qemu-minimal)
                              '("python-wrapper" "python-sphinx"))))
     (inputs
-     (fold alist-delete (package-inputs qemu)
+     (fold alist-delete (package-inputs qemu-minimal)
            ;; Disable seccomp support, because it's not required for the GRUB
            ;; test suite, and because it fails with libseccomp 2.4.2 and later.
            '("libseccomp"))))))
-- 
2.24.0

Message #8 received at 39737 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>, 39737 <at> debbugs.gnu.org
Subject: Re: [bug#39737] [PATCH] gnu: qemu-minimal-2.10: Use minimal
 dependencies from qemu-minimal.
Date: Mon, 24 Feb 2020 21:27:35 +0100

[Message part 1 (text/plain, inline)]

Jan Nieuwenhuizen <janneke <at> gnu.org> writes:

> Without this patch qemu-minimal-2.10 is not really minimal; it depends on
> cups, ffmpeg, ghostscript, gstreamer, gtk, spice, ...

Good catch, LGTM ...

>
> * gnu/packages/virtualization.scm (qemu-minimal-2.10): Use minimal
> dependencies from qemu-minimal.

... though I'd write this as

[native-inputs]: Inherit from QEMU-MINIMAL instead of QEMU.
[inputs]: Likewise.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 39737-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 39737-done <at> debbugs.gnu.org, mbakke <at> fastmail.com
Subject: Re: [PATCH] gnu: qemu-minimal-2.10: Use minimal dependencies from
 qemu-minimal.
Date: Sun, 1 Mar 2020 21:51:35 +0100

[Message part 1 (text/plain, inline)]

On Sat, Feb 22, 2020 at 03:35:25PM +0100, Jan Nieuwenhuizen wrote:
> Without this patch qemu-minimal-2.10 is not really minimal; it depends on
> cups, ffmpeg, ghostscript, gstreamer, gtk, spice, ...
> 
> * gnu/packages/virtualization.scm (qemu-minimal-2.10): Use minimal
> dependencies from qemu-minimal.
> ---
>  gnu/packages/virtualization.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, pushed as 97d491a902d294af79c1f0e997029d6872517d5b after
applying Marius's commit message suggestion.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 39737 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 39737 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: qemu-minimal-2.10: Use minimal dependencies from
 qemu-minimal.
Date: Sun, 1 Mar 2020 21:53:37 +0100

[Message part 1 (text/plain, inline)]

It seems I have encountered a race condition in my workflow. The proper
commit ID is 2d79250d1aa32fbff5aae0b1d00fcb44cab453e1.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.