GNU bug report logs - #39694
[SHEPHERD] [PATCH] build: Adjust clean targets.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39694 in the body.
You can then email your comments to 39694 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [SHEPHERD] [PATCH] build: Adjust clean targets.
Date: Thu, 20 Feb 2020 17:42:21 +0200

Makefile.am: Add man pages to the 'make clean' target.
---
Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
to the 'make clean' list and are deleted. The manpage creation works as
expected.

---
 Makefile.am | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index 9a1f019..8cf98d6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,6 +2,7 @@
 # Copyright © 2002, 2003 Wolfgang Jährling <wolfgang <at> pro-linux.de>
 # Copyright © 2013, 2014, 2015, 2016, 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
 # Copyright © 2018 Carlo Zancanaro <carlo <at> zancanaro.id.au>
+# Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
 #
 # This file is part of the GNU Shepherd.
 #
@@ -122,6 +123,8 @@ doc/%.8: modules/shepherd/scripts/%.scm
 dist_man1_MANS = doc/shepherd.1 doc/herd.1
 dist_man8_MANS = doc/halt.8 doc/reboot.8
 
+CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)
+
 # Things not automatically included in the distribution.
 EXTRA_DIST +=					\
   build-aux/config.rpath			\
-- 
2.25.1

Message #10 received at 39694-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 39694-done <at> debbugs.gnu.org
Subject: Re: [bug#39694] [SHEPHERD] [PATCH] build: Adjust clean targets.
Date: Fri, 06 Mar 2020 12:10:52 +0100

Hi Efraim,

Efraim Flashner <efraim <at> flashner.co.il> skribis:

> Makefile.am: Add man pages to the 'make clean' target.
> ---
> Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
> halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
> to the 'make clean' list and are deleted. The manpage creation works as
> expected.

[...]

> +CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)

This would remove man pages upon “make clean”, whereas they should only
be removed upon “make distclean”, per GNU conventions.

I went with a different fix in Shepherd commit
f32a2ff8ad329f224b2f693ad7e9fefac142a459.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.