GNU bug report logs - #39183
Missing ‘scm_sym_’ symbols in libguile-3.0.so

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39183 in the body.
You can then email your comments to 39183 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-Guile <at> gnu.org
Subject: Missing ‘scm_sym_’ symbols in libguile-3.0.so
Date: Sat, 18 Jan 2020 23:20:27 +0100

[Message part 1 (text/plain, inline)]

Hello,

Libguile in 3.0.0 lacks all the C exports for variables created with
‘SCM_GLOBAL_SYMBOL’ in ‘expand.c’:

--8<---------------cut here---------------start------------->8---
$ objdump -T /gnu/store/b9xkl8vbxbyblzkwp7xzwwmharswkbgy-guile-2.2.6-1/lib/libguile-2.2.so |grep scm_sym_lambda
000000000012c298 g    DO .bss	0000000000000008  GUILE_2.0   scm_sym_lambda
$ objdump -T /gnu/store/7z0zzqbchcjmc1krwhy0jd5hsny5y77w-guile-next-3.0.0/lib/libguile-3.0.so |grep scm_sym_lambda
--8<---------------cut here---------------end--------------->8---

That’s because they accidentally ended up having the “hidden”
visibility, which is fixed by the patch below.

This will obviously augment the ABI.  Should we push?

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/libguile/expand.c b/libguile/expand.c
index 11e43c2b9..6ba65ffa2 100644
--- a/libguile/expand.c
+++ b/libguile/expand.c
@@ -1,4 +1,4 @@
-/* Copyright 1995-2014,2016,2018-2019
+/* Copyright 1995-2014,2016,2018-2020
      Free Software Foundation, Inc.
 
    This file is part of Guile.
@@ -32,6 +32,7 @@
 #include "keywords.h"
 #include "list.h"
 #include "macros.h"
+#include "memoize.h"    /* for the SCM_API declarations of 'scm_sym_' */
 #include "modules.h"
 #include "pairs.h"
 #include "ports.h"

Message #10 received at 39183-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 39183-done <at> debbugs.gnu.org,  wingo <at> pobox.com
Subject: Re: bug#39183: Missing ‘scm_sym_’ symbols in
 libguile-3.0.so
Date: Mon, 20 Jan 2020 11:47:15 +0100

Hi,

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Libguile in 3.0.0 lacks all the C exports for variables created with
> ‘SCM_GLOBAL_SYMBOL’ in ‘expand.c’:
>
> $ objdump -T /gnu/store/b9xkl8vbxbyblzkwp7xzwwmharswkbgy-guile-2.2.6-1/lib/libguile-2.2.so |grep scm_sym_lambda
> 000000000012c298 g    DO .bss	0000000000000008  GUILE_2.0   scm_sym_lambda
> $ objdump -T /gnu/store/7z0zzqbchcjmc1krwhy0jd5hsny5y77w-guile-next-3.0.0/lib/libguile-3.0.so |grep scm_sym_lambda
>
> That’s because they accidentally ended up having the “hidden”
> visibility, which is fixed by the patch below.
>
> This will obviously augment the ABI.  Should we push?

Pushed in 228ae549ca651d9e9e7a7b02d282d0408bd6c9e6.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.