GNU bug report logs - #38326
[PATCH 2/2] gnu: Add emacs-telega.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38326 in the body.
You can then email your comments to 38326 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 2/2] gnu: Add emacs-telega.
Date: Fri, 22 Nov 2019 12:56:15 -0600

[0002-gnu-Add-emacs-telega.patch (text/x-patch, inline)]

From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Fri, 22 Nov 2019 12:54:44 -0600
Subject: [PATCH 2/2] gnu: Add emacs-telega.

* gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
---
 gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0caf12a423..7ff53ecf1e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -114,6 +114,7 @@
   #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
+  #:use-module (gnu packages messaging)
   #:use-module (gnu packages music)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages imagemagick)
@@ -19943,3 +19944,60 @@ Google guidelines.")
       (description "Helm Fish Completion is a Helm interface for Emacs
 fish-completion.  It can be used in both Eshell and M-x shell.")
       (license license:gpl3+))))
+
+(define-public emacs-telega
+  (let ((commit "019e923f933370d75dbe0a8473a18eb66fe94c0e")
+	(revision "1")
+	(version "0.4.4"))
+    (package
+      (name "emacs-telega")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/zevlg/telega.el.git")
+               (commit commit)))
+         (sha256
+          (base32
+           "058814agkq8mp9ajpj8sz51rm9nigs2xpsdij05wjkxhfq30kqva"))
+         (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f
+         #:modules ((guix build gnu-build-system)
+                    ((guix build emacs-build-system) #:prefix emacs:)
+                    (guix build utils)
+                    (guix build emacs-utils))
+         #:imported-modules (,@%gnu-build-system-modules
+                             (guix build emacs-build-system)
+                             (guix build emacs-utils))
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'unpack-patch
+             (lambda _
+               (substitute* "server/Makefile"
+                 (("CC=cc")
+                  "CC=gcc")
+                 (("INSTALL_PREFIX=\\$\\(HOME\\)/.telega")
+                  (string-append "INSTALL_PREFIX=" (assoc-ref %outputs "out") "/bin")))))
+           (delete 'configure)
+           
+           ;; Build emacs-side using `emacs-build-system'
+           (add-after 'compress-documentation 'emacs-add-source-to-load-path
+             (assoc-ref emacs:%standard-phases 'add-source-to-load-path))
+           (add-after 'emacs-set-emacs-load-path 'emacs-install
+             (assoc-ref emacs:%standard-phases 'install))
+           (add-after 'emacs-install 'emacs-build
+             (assoc-ref emacs:%standard-phases 'build))
+           (add-after 'emacs-install 'emacs-make-autoloads
+             (assoc-ref emacs:%standard-phases 'make-autoloads)))))
+      (propagated-inputs
+       `(("emacs-visual-fill-column" ,emacs-visual-fill-column)))
+      (native-inputs
+       `(("tdlib" ,tdlib)
+         ("emacs" ,emacs-minimal)))
+      (synopsis "GNU Emacs telegram client")
+      (description "Telega is full-featured, unofficial client for Telegram platform for GNU Emacs.")
+      (home-page "https://github.com/zevlg/telega.el")
+      (license license:gpl3+))))
-- 
2.24.0

Message #8 received at 38326 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38326 <at> debbugs.gnu.org
Subject: Re: [bug#38326] [PATCH 2/2] gnu: Add emacs-telega.
Date: Fri, 29 Nov 2019 18:11:14 +0100

Hi Brett,

Brett Gilio <brettg <at> posteo.net> skribis:

>>From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Fri, 22 Nov 2019 12:54:44 -0600
> Subject: [PATCH 2/2] gnu: Add emacs-telega.
>
> * gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 0caf12a423..7ff53ecf1e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -114,6 +114,7 @@
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages messaging)
>    #:use-module (gnu packages music)

We have a problem (not your fault!): applying this hunk on top of
current master breaks it all, due to circular top-level references in
the modules.

I haven’t been able to spend much time investigating, but we first need
to find out where that comes from.

Ludo’.

Message #11 received at 38326 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38326 <at> debbugs.gnu.org
Subject: Re: [bug#38326] [PATCH 2/2] gnu: Add emacs-telega.
Date: Fri, 29 Nov 2019 13:21:59 -0600

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Brett,
>
> Brett Gilio <brettg <at> posteo.net> skribis:
>
>>>From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg <at> posteo.net>
>> Date: Fri, 22 Nov 2019 12:54:44 -0600
>> Subject: [PATCH 2/2] gnu: Add emacs-telega.
>>
>> * gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
>> ---
>>  gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 58 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index 0caf12a423..7ff53ecf1e 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -114,6 +114,7 @@
>>    #:use-module (gnu packages image)
>>    #:use-module (gnu packages linux)
>>    #:use-module (gnu packages libevent)
>> +  #:use-module (gnu packages messaging)
>>    #:use-module (gnu packages music)
>
> We have a problem (not your fault!): applying this hunk on top of
> current master breaks it all, due to circular top-level references in
> the modules.
>
> I haven’t been able to spend much time investigating, but we first need
> to find out where that comes from.
>
> Ludo’.

Ludo,

That is perfectly okay. I have some revisions I will be sharing to this
patch soon anyways.

Regarding the circular top-level references. That is interesting. I was
not familiar with this issue. Is there an open bug report for this? I'd
be willing to investigate it a bit.

It is particularly interesting, because emacs-xyz is not used in the
messaging module, so the circular reference logic is indeed obscured
somewhere.

Best!

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #16 received at 38326-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38326-done <at> debbugs.gnu.org
Subject: Re: [bug#38326] [PATCH 2/2] gnu: Add emacs-telega.
Date: Mon, 02 Dec 2019 12:26:20 +0100

Hi Brett,

I fixed the circularity issue in commit
abad22dd4a3083498263cc5d6817dd7c01df4da1, and finally pushed
‘emacs-telega’.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.