GNU bug report logs - #36709
Likely bug in scm_port_poll

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36709 in the body.
You can then email your comments to 36709 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: bug-guile <at> gnu.org
Subject: Likely bug in scm_port_poll
Date: Wed, 17 Jul 2019 15:25:15 -0400

I sent the following message about a month ago, and now am forwarding to
bug-guile so that we do not forget about it.

       Mark


From: Mark H Weaver <mhw <at> netris.org>
Subject: Likely bug in scm_port_poll
Date: Tue, 18 Jun 2019 00:40:27 -0400
Message-ID: <87a7ef1p61.fsf <at> netris.org>
Cc: guile-devel <at> gnu.org
To: Andy Wingo <wingo <at> pobox.com>

Hi Andy,

If you'd be willing to take a quick look at this, I'd be grateful.
Probably a bug, but I feel uneasy that I might be overlooking something.

scm_port_poll contains the following code:

  if (scm_i_string_contains_char (events, 'r'))
    c_events |= POLLIN;
  if (scm_i_string_contains_char (events, '!'))
    c_events |= POLLPRI;
  if (scm_i_string_contains_char (events, 'w'))
    c_events |= POLLIN;

That second POLLIN should be POLLOUT, right?

      Thanks,
        Mark

https://git.savannah.gnu.org/cgit/guile.git/tree/libguile/ports.c?h=stable-2.2&id=420c2632bb1f48e492a035c1d216f209734f45e6#n1423

Message #10 received at 36709-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 36709-done <at> debbugs.gnu.org
Subject: Re: bug#36709: Likely bug in scm_port_poll
Date: Mon, 18 Nov 2019 15:17:29 +0100

Hi Mark,

Mark H Weaver <mhw <at> netris.org> skribis:

> If you'd be willing to take a quick look at this, I'd be grateful.
> Probably a bug, but I feel uneasy that I might be overlooking something.
>
> scm_port_poll contains the following code:
>
>   if (scm_i_string_contains_char (events, 'r'))
>     c_events |= POLLIN;
>   if (scm_i_string_contains_char (events, '!'))
>     c_events |= POLLPRI;
>   if (scm_i_string_contains_char (events, 'w'))
>     c_events |= POLLIN;
>
> That second POLLIN should be POLLOUT, right?

I agree.  Clearly it must be a typo, so I’ve pushed the fix as
659526d33b2db1b0924b2769b6a0b824709860cc.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.