GNU bug report logs - #36371
'--with-commit' does not support tags

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36371 in the body.
You can then email your comments to 36371 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: bug-guix <at> gnu.org
Subject: guix build --with-git-reference=…
Date: Tue, 25 Jun 2019 11:24:33 +0200

[Message part 1 (text/plain, inline)]

Guix,

bricewge on #guix informed me that there's no way to pass a git 
tag as source transformation option.  Indeed:

 ‘--with-commit=PACKAGE=COMMIT’
    This is similar to ‘--with-branch’, except that it builds 
    from
    COMMIT rather than the tip of a branch.  COMMIT must be a 
    valid Git
    commit SHA1 identifier.

is quite different from (guix git-download)'s pleasantly liberal 
notion of commit:

 (git reference
   (url "git://foo.org/fizbo")
   (commit "fizbo-4.5"))      ; tag yay

bricewge suggested that a single ‘--with-git-ref[erence]=’ could 
replace both ‘--with-branch’ and a new ‘--with-tag’, and I agree. 
(Although I prefer the full spelling, of course :-)

Two questions:
- Is this really not supported yet, or am I missing the obvious?
- Why is the (extremely) git-specific ‘--with-commit=’ option not 
 called ‘--with-git-commit=’?  Was it intended to be more generic 
 than it is now?  Should the new option be ‘--with-reference=’ as 
 well?  That's pushing it a little far.  And three questions in 
 one; I'm cheating.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 36371 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36371 <at> debbugs.gnu.org
Subject: Re: bug#36371: guix build --with-git-reference=…
Date: Tue, 25 Jun 2019 14:38:44 +0200

Hi!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> bricewge on #guix informed me that there's no way to pass a git tag as
> source transformation option.  Indeed:
>
>  ‘--with-commit=PACKAGE=COMMIT’
>     This is similar to ‘--with-branch’, except that it builds   from
>     COMMIT rather than the tip of a branch.  COMMIT must be a   valid
> Git
>     commit SHA1 identifier.

Indeed:

--8<---------------cut here---------------start------------->8---
$ guix build guile-gcrypt --with-commit=guile-gcrypt=v1.0.0
updating checkout of 'https://notabug.org/cwebber/guile-gcrypt.git'...
guix build: error: cannot fetch commit v1.0.0 from https://notabug.org/cwebber/guile-gcrypt.git: unable to parse OID - contains invalid characters
--8<---------------cut here---------------end--------------->8---

Internally, that uses the ‘git-checkout’ record type defined in (guix
git).

What I would propose is to change ‘git-checkout-compiler’ so that it can
determine with a simple heuristic like that of (@@ (guix swh) commit-id?)
whether the string denotes a commit ID or a tag.

WDYT?

> - Why is the (extremely) git-specific ‘--with-commit=’ option not
> called ‘--with-git-commit=’?  Was it intended to be more generic than
> it is now?  Should the new option be ‘--with-reference=’ as well?
> That's pushing it a little far.  And three questions in one; I'm
> cheating.

Things are named this way for simplicity; the only exception is
‘--with-git-url’ because ‘--with-url’ would have been too vague.

Ludo’.

Message #15 received at 36371-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36371-done <at> debbugs.gnu.org
Subject: Re: bug#36371: guix build --with-git-reference=…
Date: Fri, 26 Jul 2019 12:38:25 +0200

Hello!

Ludovic Courtès <ludo <at> gnu.org> skribis:

> $ guix build guile-gcrypt --with-commit=guile-gcrypt=v1.0.0
> updating checkout of 'https://notabug.org/cwebber/guile-gcrypt.git'...
> guix build: error: cannot fetch commit v1.0.0 from https://notabug.org/cwebber/guile-gcrypt.git: unable to parse OID - contains invalid characters
>
> Internally, that uses the ‘git-checkout’ record type defined in (guix
> git).
>
> What I would propose is to change ‘git-checkout-compiler’ so that it can
> determine with a simple heuristic like that of (@@ (guix swh) commit-id?)
> whether the string denotes a commit ID or a tag.

Done in 177fecb57c0c9e15249bf6a49244c9dc6eb8439c.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.