GNU bug report logs - #36339
generated .pc files leaks build-time LDFLAGS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36339 in the body.
You can then email your comments to 36339 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cyprien Nicolas <cyprien <at> nicolas.tf>
To: bug-guile <at> gnu.org
Subject: generated .pc files leaks build-time LDFLAGS
Date: Sun, 23 Jun 2019 11:19:52 +0200

Hello,

According to the pkgconfig generated files, Libs.private contains the 
build-time LDFLAGS (-Wl,-O1 -Wl,--as-needed).

These flags are private to the way I built guile, and should not affect 
packages using guile later.

I have observed this behavior in guile-2.0, 2.2.5 and 2.9.2.

-----8<-----8<-----8<-----8<-----8<-----
Name: GNU Guile
Description: GNU's Ubiquitous Intelligent Language for Extension
Version: 2.0.14
Libs: -L${libdir} -lguile-2.0 -lgc
Libs.private:  -lgmp -lltdl -L/usr/lib64/../lib64 -lffi	\
  -lunistring -Wl,-O1 -Wl,--as-needed  -lcrypt  -lm   		\
     		\

Cflags: -I${pkgincludedir}/2.0 -pthread
----->8----->8----->8----->8----->8-----


Gentoo Bug: https://bugs.gentoo.org/590904
The (1) part seems resolved somehow.

Thanks,
Cyprien

Message #8 received at 36339 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cyprien Nicolas <cyprien <at> nicolas.tf>
Cc: 36339 <at> debbugs.gnu.org
Subject: Re: bug#36339: generated .pc files leaks build-time LDFLAGS
Date: Mon, 24 Jun 2019 15:17:44 +0200

[Message part 1 (text/plain, inline)]

Hello,

Cyprien Nicolas <cyprien <at> nicolas.tf> skribis:

> These flags are private to the way I built guile, and should not
> affect packages using guile later.
>
> I have observed this behavior in guile-2.0, 2.2.5 and 2.9.2.
>
> -----8<-----8<-----8<-----8<-----8<-----
> Name: GNU Guile
> Description: GNU's Ubiquitous Intelligent Language for Extension
> Version: 2.0.14
> Libs: -L${libdir} -lguile-2.0 -lgc
> Libs.private:  -lgmp -lltdl -L/usr/lib64/../lib64 -lffi	\
>   -lunistring -Wl,-O1 -Wl,--as-needed  -lcrypt  -lm   		\
>      		\
>
> Cflags: -I${pkgincludedir}/2.0 -pthread
> ----->8----->8----->8----->8----->8-----

I believe the attached patch should fix it.  Could you confirm?

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/configure.ac b/configure.ac
index 9073deba0..92966ce34 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1688,7 +1688,7 @@ do
 done
 
 GUILE_CFLAGS="$GUILE_CFLAGS $PTHREAD_CFLAGS"
-GUILE_LIBS="$LDFLAGS $LIBS"
+GUILE_LIBS="$LIBS"
 
 AC_SUBST(GUILE_LIBS)
 AC_SUBST(GUILE_CFLAGS)
 

Message #11 received at 36339 <at> debbugs.gnu.org (full text, mbox):

From: Cyprien Nicolas <cyprien <at> nicolas.tf>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36339 <at> debbugs.gnu.org
Subject: Re: bug#36339: generated .pc files leaks build-time LDFLAGS
Date: Sun, 7 Jul 2019 14:45:14 +0200

Hi Ludo,

On 24/06/2019 15:17, Ludovic Courtès wrote:
> 
> I believe the attached patch should fix it.  Could you confirm?

Yes it does, tested on 2.2.6 and 2.9.2. All arch-dependent binaries have
been built with the right LDFLAGS, and the pkgconfig file looks clean.

Thanks,
Cyprien

Message #16 received at 36339-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cyprien Nicolas <cyprien <at> nicolas.tf>
Cc: 36339-done <at> debbugs.gnu.org
Subject: Re: bug#36339: generated .pc files leaks build-time LDFLAGS
Date: Sun, 07 Jul 2019 15:09:29 +0200

Hi Cyprien,

Cyprien Nicolas <cyprien <at> nicolas.tf> skribis:

> On 24/06/2019 15:17, Ludovic Courtès wrote:
>>
>> I believe the attached patch should fix it.  Could you confirm?
>
> Yes it does, tested on 2.2.6 and 2.9.2. All arch-dependent binaries have
> been built with the right LDFLAGS, and the pkgconfig file looks clean.

Awesome.  Pushed as a69b567d97f7c9193924c775e1dd86e43a35b8bd to the
‘stable-2.2’ branch.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.