GNU bug report logs - #36207
Circular dependency in gnu/services: mcron -> base -> admin -> mcron

Previous Next

Package: guix;

Reported by: Jack Hill <jackhill <at> jackhill.us>

Date: Fri, 14 Jun 2019 15:50:01 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36207 in the body.
You can then email your comments to 36207 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#36207; Package guix. (Fri, 14 Jun 2019 15:50:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jack Hill <jackhill <at> jackhill.us>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Fri, 14 Jun 2019 15:50:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: bug-guix <at> gnu.org
Subject: Circular dependency in gnu/services: mcron -> base -> admin -> mcron
Date: Fri, 14 Jun 2019 11:49:16 -0400 (EDT)
[Message part 1 (text/plain, inline)]
Hi Guix,

As discussed on IRC with Ludo’ and Ricardo, 
4252dace19945f56192477e8cb07973c20a526ba introduced a circular dependency 
among gnu/services modules, by adding a dependency between from base -> 
admin, resulting in the full dependency chain:

 mcron -> base -> admin -> mcron

I ran into this when building a channel. The error reported by guix pull 
was:

```
(repl-version 0 0)
(exception misc-error (value #f) (value "Unbound variable: ~s") (value (mcron-service-type)) (value #f))
```

Ludo’ determined the full error was:

```
gnu/services/admin.scm:161:21: Unbound variable: mcron-service-type
```

by running the repl directly:

```
echo '(primitive-load "/gnu/store/vf892np8mnh2zx9dppcv9k25xk648n2d-inferior-script.scm")' \
| "/gnu/store/j7vxgnaqwimrzsnd8zhq9x1jdp7afl0s-guix-ca45da9fc/bin/guix" "repl"
```

Options for solving this problem include moving the guix-publish service 
into another module. However, this would break the API of (gnu service base),
so we should be careful when doing that.

It doesn't look like guix-publish is used elsewhere in the Guix code 
proper currently.

For now, we might want to revert 4252dace19945f56192477e8cb07973c20a526ba.

Best,
Jack

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 15 Jun 2019 16:43:01 GMT) Full text and rfc822 format available.

Notification sent to Jack Hill <jackhill <at> jackhill.us>:
bug acknowledged by developer. (Sat, 15 Jun 2019 16:43:01 GMT) Full text and rfc822 format available.

Message #10 received at 36207-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 36207-done <at> debbugs.gnu.org
Subject: Re: bug#36207: Circular dependency in gnu/services: mcron -> base ->
 admin -> mcron
Date: Sat, 15 Jun 2019 18:42:15 +0200
Hi Jack,

Jack Hill <jackhill <at> jackhill.us> skribis:

> As discussed on IRC with Ludo’ and Ricardo,
> 4252dace19945f56192477e8cb07973c20a526ba introduced a circular
> dependency among gnu/services modules, by adding a dependency between
> from base -> 
> admin, resulting in the full dependency chain:
>
>  mcron -> base -> admin -> mcron
>
> I ran into this when building a channel. The error reported by guix
> pull was:
>
> ```
> (repl-version 0 0)
> (exception misc-error (value #f) (value "Unbound variable: ~s") (value (mcron-service-type)) (value #f))
> ```

This is fixed (surprisingly easily!) by commit
f3d797005374e5333c7596fe86b4a524ab1b9b11.

Let me know if you notice anything wrong!

Thanks for the bug report,
Ludo’.




Information forwarded to bug-guix <at> gnu.org:
bug#36207; Package guix. (Sat, 15 Jun 2019 20:22:02 GMT) Full text and rfc822 format available.

Message #13 received at 36207-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36207-done <at> debbugs.gnu.org
Subject: Re: bug#36207: Circular dependency in gnu/services: mcron -> base
 -> admin -> mcron
Date: Sat, 15 Jun 2019 16:21:15 -0400 (EDT)
[Message part 1 (text/plain, inline)]
On Sat, 15 Jun 2019, Ludovic Courtès wrote:

> This is fixed (surprisingly easily!) by commit
> f3d797005374e5333c7596fe86b4a524ab1b9b11.

Neat!

> Let me know if you notice anything wrong!

Everything looks good and works well for me.

> Thanks for the bug report,

Thanks for the quick fix.

Best,
Jack

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 14 Jul 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 259 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.