GNU bug report logs - #35923
Minification of Javascript for r-shiny fails

Previous Next

Package: guix;

Reported by: Roel Janssen <roel <at> gnu.org>

Date: Mon, 27 May 2019 10:25:02 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35923 in the body.
You can then email your comments to 35923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#35923; Package guix. (Mon, 27 May 2019 10:25:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Roel Janssen <roel <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 27 May 2019 10:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: Minification of Javascript for r-shiny fails
Date: Mon, 27 May 2019 12:24:22 +0200
Dear guix,

It seems that the r-shiny package is not functioning correctly due to empty minified Javascript
files.

This is empty:
$ ls -lh ./site-library/shiny/www/shared/shiny.min.js
-r--r--r-- 6658 root root 0 Jan  1  1970 ./site-library/shiny/www/shared/shiny.min.js

While its unminified equivalent is definitely not empty:
$ ls -lh ./site-library/shiny/www/shared/shiny.js
-r--r--r-- 3 root root 229K Jan  1  1970 ./site-library/shiny/www/shared/shiny.js

Symlinking the unminified files to the minified files solves the problem.  But for production use
I'd like to get the minification to work.

Is it a trivial thing to fix for someone more familiar with the minify-build-system?

Kind regards,
Roel Janssen




Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Mon, 27 May 2019 20:13:02 GMT) Full text and rfc822 format available.

Notification sent to Roel Janssen <roel <at> gnu.org>:
bug acknowledged by developer. (Mon, 27 May 2019 20:13:02 GMT) Full text and rfc822 format available.

Message #10 received at 35923-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Roel Janssen <roel <at> gnu.org>
Cc: 35923-done <at> debbugs.gnu.org
Subject: Re: bug#35923: Minification of Javascript for r-shiny fails
Date: Mon, 27 May 2019 22:11:03 +0200
Hi Roel,

> It seems that the r-shiny package is not functioning correctly due to empty minified Javascript
> files.
>
> This is empty:
> $ ls -lh ./site-library/shiny/www/shared/shiny.min.js
> -r--r--r-- 6658 root root 0 Jan  1  1970 ./site-library/shiny/www/shared/shiny.min.js

Oh.  This is now fixed with commit 8916034a34.
Problem was that uglify-js wasn’t available during minification.  It
would have been nicer had the build phase failed.

-- 
Ricardo





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 25 Jun 2019 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 324 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.