GNU bug report logs - #32539
Cuirass: a commit that updates doc will produce 86 tests

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32539 in the body.
You can then email your comments to 32539 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: bug-guix <at> gnu.org
Subject: Cuirass: a commit that updates doc will produce 86 tests
Date: Mon, 27 Aug 2018 10:57:55 +0200

Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
the documentation.  This evaluation produces 86 useless tests:
test.mcron.i686-linux, test.opensmtpd.i686-linux, etc.  I believe those
tests are triggered at each evaluation (almost), and it's a considerable
waste of resources.

[1]: https://berlin.guixsd.org/eval/338
[2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1d8d69c863ae88d5fc20e52e49a22f68c531c1db

Message #8 received at 32539 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 32539 <at> debbugs.gnu.org
Subject: Re: bug#32539: Cuirass: a commit that updates doc will produce 86
 tests
Date: Wed, 29 Aug 2018 23:21:25 +0200

Hi Clément,

Clément Lassieur <clement <at> lassieur.org> skribis:

> Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
> the documentation.  This evaluation produces 86 useless tests:
> test.mcron.i686-linux, test.opensmtpd.i686-linux, etc.  I believe those
> tests are triggered at each evaluation (almost), and it's a considerable
> waste of resources.

I claim that these tests are useful and that having them under CI is a
good thing!

AFAICS the result of test.basic.*, test.mcron.*, etc. should be
unchanged when doc/*.texi are modified; if that’s not the case, we have
a bug. :-)   So there’s no waste of resources in this case.

However the tests in (gnu tests install) do entail a full build of Guix
from the checkout, among other things, at every commit, so they are
expensive.  They are useful though, so I’d rather keep it this way if
our build farm can keep up.

Thoughts?

Ludo’.

Message #11 received at 32539 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32539 <at> debbugs.gnu.org
Subject: Re: bug#32539: Cuirass: a commit that updates doc will produce 86
 tests
Date: Thu, 30 Aug 2018 00:07:08 +0200

Heya!

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Clément,
>
> Clément Lassieur <clement <at> lassieur.org> skribis:
>
>> Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates
>> the documentation.  This evaluation produces 86 useless tests:
>> test.mcron.i686-linux, test.opensmtpd.i686-linux, etc.  I believe those
>> tests are triggered at each evaluation (almost), and it's a considerable
>> waste of resources.
>
> I claim that these tests are useful and that having them under CI is a
> good thing!
>
> AFAICS the result of test.basic.*, test.mcron.*, etc. should be
> unchanged when doc/*.texi are modified; if that’s not the case, we have
> a bug. :-)   So there’s no waste of resources in this case.

My point is that the derivations files are different at each commit,
despite the changes being only about documentation.  It seems to me that
documentation is not an input of the tests, therefore the inputs didn't
change and the test derivations shouldn't change.

> However the tests in (gnu tests install) do entail a full build of Guix
> from the checkout, among other things, at every commit, so they are
> expensive.  They are useful though, so I’d rather keep it this way if
> our build farm can keep up.
>
> Thoughts?
>
> Ludo’.

Message #16 received at 32539-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 32539-done <at> debbugs.gnu.org
Subject: Re: bug#32539: Cuirass: a commit that updates doc will produce 86
 tests
Date: Thu, 25 Mar 2021 14:12:56 +0100

Hello,

The tests are now evaluated periodically (every 24 hours) which largely
mitigates this issue. Closing this one.

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.