GNU bug report logs - #32467
Upgrade of libraw to 0.19 makes krita build fail

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32467 in the body.
You can then email your comments to 32467 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <bug-guix <at> gnu.org>
Subject: Upgrade of libraw to 0.19 makes krita build fail
Date: Fri, 17 Aug 2018 18:04:34 +0200

[Message part 1 (text/plain, inline)]

Commit 290532870e3c9ea832e62701ec8784a78d6c6714 updated libraw:

-    (version "0.18.12")
+    (version "0.19.0")

This makes the build of krita fail:

/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp: In member function ?bool KDcrawIface::KDcraw::Private::load
FromLibraw(const QString&, QByteArray&, int&, int&, int&)?:
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp:381:32: error: ?struct libraw_output_params_t? has no member
 named ?linenoise?
             raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.N
RThreshold * 2.11E-5 + 0.00111111;
                                ^
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp:382:32: error: ?struct libraw_output_params_t? has no member
 named ?cfaline?
             raw.imgdata.params.cfaline      = true;
                                ^
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:389:32: error: ?struct libraw_output_params_t? has no member named ?lclean?
             raw.imgdata.params.lclean       = m_parent->m_rawDecodingSettings.NRThreshold     * 5E-5;

The problem is already known upstream but not yet solved:

https://bugs.kde.org/show_bug.cgi?id=396121
https://bugs.gentoo.org/659904

Note that this problem is currently hidden by kxmlgui not building:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32013

I fixed #32013 quick and dirty, reverted the libraw-update and then
krita built again.


We should also check the build status of the other dependencies of
libraw as well:

./pre-inst-env  guix refresh -l libraw

Building the following 17 packages would ensure 22 dependent packages are rebuilt: econnman <at> 1.1 lekha <at> 0.2.1 terminology <at> 1.2.1 edi <at> 0.6.0 enlightenment <at> 0.22.3 python-efl <at> 1.20.0 rage <at> 0.3.0 dbus-c++@0.9.0 shotwell <at> 0.28.0 luminance-hdr <at> 2.4.0 emulation-station <at> 2.0.1 openmw <at> 0.43-1.5bc0736 guile-sly <at> 0.1 perceptualdiff <at> 1.3 darktable <at> 2.4.4 krita <at> 3.3.3 krita <at> 4.1.1


Björn

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 32467-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 32467-done <at> debbugs.gnu.org
Subject: Re: bug#32467: Upgrade of libraw to 0.19 makes krita build fail
Date: Sat, 1 Sep 2018 02:13:17 -0400

[Message part 1 (text/plain, inline)]

Thanks for looking into this!

Fixed in commit fd67d793c27f4f675708862df59336cb1133ade1

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.