GNU bug report logs - #32448
commit fac39b9 (update libx264) broke VLC

Previous Next

Package: guix;

Reported by: Clément Lassieur <clement <at> lassieur.org>

Date: Wed, 15 Aug 2018 17:07:01 UTC

Severity: normal

Fixed in version 5f9a9945b5747e5ec284f8b116b2e8cc1b9064d7

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32448 in the body.
You can then email your comments to 32448 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to mbakke <at> fastmail.com, bug-guix <at> gnu.org:
bug#32448; Package guix. (Wed, 15 Aug 2018 17:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Clément Lassieur <clement <at> lassieur.org>:
New bug report received and forwarded. Copy sent to mbakke <at> fastmail.com, bug-guix <at> gnu.org. (Wed, 15 Aug 2018 17:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: bug-guix <at> gnu.org
Subject: commit fac39b9 (update libx264) broke VLC
Date: Wed, 15 Aug 2018 18:52:07 +0200
Hi,

Commit fac39b9 (update libx264) broke VLC.

Clément




Information forwarded to bug-guix <at> gnu.org:
bug#32448; Package guix. (Thu, 16 Aug 2018 14:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 32448 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: 32448 <at> debbugs.gnu.org
Subject: Re: bug#32448: commit fac39b9 (update libx264) broke VLC
Date: Thu, 16 Aug 2018 16:43:22 +0200
Clément Lassieur <clement <at> lassieur.org> writes:

> Hi,
>
> Commit fac39b9 (update libx264) broke VLC.
>
> Clément

The end of the log:

--8<---------------cut here---------------start------------->8---
audio_output/pulse.c: In function ‘stream_start_now’:
audio_output/pulse.c:174:60: warning: unused parameter ‘aout’ [-Wunused-parameter]
 static void stream_start_now(pa_stream *s, audio_output_t *aout)
                                                            ^
codec/oggspots.c: In function ‘DecodePacket’:
codec/oggspots.c:385:5: warning: ignoring return value of ‘decoder_UpdateVideoFormat’, declared with attribute warn_unused_result [-Wunused-result]
     decoder_UpdateVideoFormat(p_dec);
     ^
codec/x264.c: In function ‘Open’:
codec/x264.c:849:26: error: ‘x264_bit_depth’ undeclared (first use in this function)
         const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
                          ^
codec/x264.c:849:26: note: each undeclared identifier is reported only once for each function it appears in
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/vaapi.c:47:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/vaapi.c:47:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/vaapi.c:47:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/vaapi.c:44:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/subtitle.c:39:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/subtitle.c:39:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/subtitle.c:39:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/subtitle.c:36:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
codec/avcodec/subtitle.c: In function ‘InitSubtitleDec’:
codec/avcodec/subtitle.c:94:5: warning: ‘av_codec_set_pkt_timebase’ is deprecated [-Wdeprecated-declarations]
     av_codec_set_pkt_timebase(context, AV_TIME_BASE_Q);
     ^
In file included from codec/avcodec/subtitle.c:36:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:3310:12: note: declared here
 void       av_codec_set_pkt_timebase         (AVCodecContext *avctx, AVRational val);
            ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/avcodec.c:41:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/avcodec.c:41:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/avcodec.c:41:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/avcodec.c:39:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/video.c:46:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/video.c:46:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/fourcc.c:33:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/video.c:46:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/fourcc.c:33:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/encoder.c:48:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/fourcc.c:33:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/chroma.c:34:0:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/video.c:39:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/encoder.c:48:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/encoder.c:48:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
In file included from codec/avcodec/fourcc.c:32:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/chroma.c:34:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/chroma.c:34:0:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:31:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/chroma.c:34:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
In file included from codec/avcodec/encoder.c:45:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
make[4]: *** [Makefile:22482: codec/libx264_plugin_la-x264.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/audio.c:39:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
codec/avcodec/encoder.c: In function ‘InitVideoEnc’:
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/audio.c:39:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/audio.c:39:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/encoder.c:582:37: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
             p_context->intra_matrix = mpeg4_default_intra_matrix;
                                     ^
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
codec/avcodec/encoder.c:583:37: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
             p_context->inter_matrix = mpeg4_default_non_intra_matrix;
                                     ^
In file included from codec/avcodec/avcommon_compat.h:31:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/audio.c:39:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
codec/avcodec/audio.c: In function ‘SetupOutputFormat’:
codec/avcodec/audio.c:595:77: warning: signed and unsigned type in conditional expression [-Wsign-compare]
         p_sys->p_context->channel_layout ? p_sys->p_context->channel_layout :
                                                                             ^
codec/avcodec/encoder.c: In function ‘EncodeVideo’:
codec/avcodec/encoder.c:1236:8: warning: ‘coded_frame’ is deprecated [-Wdeprecated-declarations]
        switch ( p_sys->p_context->coded_frame->pict_type )
        ^
In file included from codec/avcodec/encoder.c:45:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:2760:35: note: declared here
     attribute_deprecated AVFrame *coded_frame;
                                   ^
codec/avcodec/vaapi.c: At top level:
codec/avcodec/vaapi.c:54:12: warning: ‘vaapi_context’ is deprecated [-Wdeprecated-declarations]
     struct vaapi_context hw_ctx;
            ^
In file included from codec/avcodec/vaapi.c:45:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/vaapi.h:56:29: note: declared here
 struct attribute_deprecated vaapi_context {
                             ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/vaapi.c:47:
codec/avcodec/avcommon.h: In function ‘vlc_init_avformat’:
codec/avcodec/avcommon.h:105:5: warning: ‘av_register_all’ is deprecated [-Wdeprecated-declarations]
     av_register_all();
     ^
In file included from codec/avcodec/avcommon_compat.h:110:0,
                 from codec/avcodec/avcommon.h:38,
                 from codec/avcodec/avcodec.h:25,
                 from codec/avcodec/vaapi.c:47:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavformat/avformat.h:2025:6: note: declared here
 void av_register_all(void);
      ^
In file included from codec/avcodec/avcodec.h:25:0,
                 from codec/avcodec/vaapi.c:47:
codec/avcodec/avcommon.h: In function ‘vlc_init_avcodec’:
codec/avcodec/avcommon.h:119:5: warning: ‘avcodec_register_all’ is deprecated [-Wdeprecated-declarations]
     avcodec_register_all();
     ^
In file included from codec/avcodec/vaapi.c:44:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/avcodec.h:4086:6: note: declared here
 void avcodec_register_all(void);
      ^
codec/avcodec/vaapi.c: At top level:
codec/avcodec/vaapi.c:54:12: warning: ‘vaapi_context’ is deprecated [-Wdeprecated-declarations]
     struct vaapi_context hw_ctx;
            ^
In file included from codec/avcodec/vaapi.c:45:0:
/gnu/store/xri7an06q2ls585in8f4l39ksgalxxjx-ffmpeg-4.0.2/include/libavcodec/vaapi.h:56:29: note: declared here
 struct attribute_deprecated vaapi_context {
                             ^
In file included from ../include/vlc_common.h:409:0,
                 from audio_output/pulse.c:30:
audio_output/pulse.c: In function ‘Flush’:
../include/vlc_threads.h:860:12: warning: call to ‘harmful_delay’ declared with attribute warning: use proper event handling instead of short delay
            : d))
            ^
../include/vlc_threads.h:878:26: note: in expansion of macro ‘check_delay’
 #define msleep(d) msleep(check_delay(d))
                          ^
audio_output/pulse.c:570:13: note: in expansion of macro ‘msleep’
             msleep(delay);
             ^
make[4]: Leaving directory '/tmp/guix-build-vlc-3.0.3-1.drv-0/vlc-3.0.3/modules'
make[3]: *** [Makefile:26145: all-recursive] Error 1
make[3]: Leaving directory '/tmp/guix-build-vlc-3.0.3-1.drv-0/vlc-3.0.3/modules'
make[2]: *** [Makefile:11238: all] Error 2
make[2]: Leaving directory '/tmp/guix-build-vlc-3.0.3-1.drv-0/vlc-3.0.3/modules'
make[1]: *** [Makefile:1531: all-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-vlc-3.0.3-1.drv-0/vlc-3.0.3'
make: *** [Makefile:1416: all] Error 2
Backtrace:
           4 (primitive-load "/gnu/store/dk4wgqbss5srzqdvrb58a2vryn8…")
In ice-9/eval.scm:
   191:35  3 (_ _)
In srfi/srfi-1.scm:
    640:9  2 (for-each #<procedure b7bc40 at /gnu/store/f95ghy8mx00…> …)
In /gnu/store/f95ghy8mx00fc22nrvswvnpqlfdkf2nk-module-import/guix/build/gnu-build-system.scm:
   799:31  1 (_ _)
In /gnu/store/f95ghy8mx00fc22nrvswvnpqlfdkf2nk-module-import/guix/build/utils.scm:
    616:6  0 (invoke _ . _)

/gnu/store/f95ghy8mx00fc22nrvswvnpqlfdkf2nk-module-import/guix/build/utils.scm:616:6: In procedure invoke:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "make" arguments: ("-j" "32") exit-status: 2 term-signal: #f stop-signal: #f] 81e900>)'.
--8<---------------cut here---------------end--------------->8---




Information forwarded to bug-guix <at> gnu.org:
bug#32448; Package guix. (Thu, 16 Aug 2018 14:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 32448 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 32448 <at> debbugs.gnu.org
Subject: Re: bug#32448: commit fac39b9 (update libx264) broke VLC
Date: Thu, 16 Aug 2018 16:55:05 +0200
Clément Lassieur <clement <at> lassieur.org> writes:

> codec/x264.c: In function ‘Open’:
> codec/x264.c:849:26: error: ‘x264_bit_depth’ undeclared (first use in this function)
>          const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;

Looks like an API change.  Is there an upstream patch we can apply to
fix the VLC build?  I’d prefer that over re-introducing and older
version of libx264.

-- 
Ricardo





bug marked as fixed in version 5f9a9945b5747e5ec284f8b116b2e8cc1b9064d7, send any further explanations to 32448 <at> debbugs.gnu.org and Clément Lassieur <clement <at> lassieur.org> Request was from Marius Bakke <mbakke <at> fastmail.com> to control <at> debbugs.gnu.org. (Thu, 16 Aug 2018 15:09:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 14 Sep 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 229 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.