GNU bug report logs - #31700
Make clean deletes french manuals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31700 in the body.
You can then email your comments to 31700 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: bug-guix <at> gnu.org, Julien Lepiller <julien <at> lepiller.eu>
Subject: Make clean deletes french manuals
Date: Sun, 3 Jun 2018 23:13:22 +0200

[Message part 1 (text/plain, inline)]

Make clean removes:
doc/contributing.fr.texi
doc/guix.fr.texi

We had a discussion on #guix with roptat, and a few others.
I have found out, that after removing $(TRANSLATED_INFO)
from $(BUILT_SOURCES) in doc/local.mk these files are not
deleted any more. I have doubts that this is a correct fix, as
this might break dependency resolution.

I also noticed, that after running make these two files end up with
different content.

If you think this fix is ok, I will send a patch.

[Message part 2 (text/html, inline)]

Message #8 received at 31700 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: 31700 <at> debbugs.gnu.org, julien <at> lepiller.eu
Subject: Re: bug#31700: Make clean deletes french manuals
Date: Mon, 04 Jun 2018 13:45:33 +0200

[Message part 1 (text/plain, inline)]

Hi Gábor,

Gábor Boskovits <boskovits <at> gmail.com> skribis:

> Make clean removes:
> doc/contributing.fr.texi
> doc/guix.fr.texi
>
> We had a discussion on #guix with roptat, and a few others.
> I have found out, that after removing $(TRANSLATED_INFO)
> from $(BUILT_SOURCES) in doc/local.mk these files are not
> deleted any more. I have doubts that this is a correct fix, as
> this might break dependency resolution.
>
> I also noticed, that after running make these two files end up with
> different content.

But they do get re-generated, right?

I think the issue is fixed with this patch:

[Message part 2 (text/x-patch, inline)]

diff --git a/nix/local.mk b/nix/local.mk
index 4452301c6..39717711f 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -22,7 +22,7 @@
 #
 
 BUILT_SOURCES += %D%/libstore/schema.sql.hh
-CLEANFILES += $(BUILT_SOURCES)
+CLEANFILES += %D%/libstore/schema.sql.hh
 
 noinst_LIBRARIES = libformat.a libutil.a libstore.a
 

[Message part 3 (text/plain, inline)]

I’ll push it if it works for you.

Thanks,
Ludo’.

Message #11 received at 31700 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31700 <at> debbugs.gnu.org, Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: bug#31700: Make clean deletes french manuals
Date: Mon, 4 Jun 2018 20:30:49 +0200

[Message part 1 (text/plain, inline)]

2018-06-04 13:45 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:

> Hi Gábor,
>
> Gábor Boskovits <boskovits <at> gmail.com> skribis:
>
> > Make clean removes:
> > doc/contributing.fr.texi
> > doc/guix.fr.texi
> >
> > We had a discussion on #guix with roptat, and a few others.
> > I have found out, that after removing $(TRANSLATED_INFO)
> > from $(BUILT_SOURCES) in doc/local.mk these files are not
> > deleted any more. I have doubts that this is a correct fix, as
> > this might break dependency resolution.
> >
> > I also noticed, that after running make these two files end up with
> > different content.
>
> But they do get re-generated, right?
>
> I think the issue is fixed with this patch:
>
>
>
> I’ll push it if it works for you.
>
>
Thanks, Ludo, this seems to be the correct fix. Thanks for the additional
insight.
Please push it.


> Thanks,
> Ludo’.
>
>

[Message part 2 (text/html, inline)]

Message #16 received at 31700-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: 31700-done <at> debbugs.gnu.org, Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: bug#31700: Make clean deletes french manuals
Date: Fri, 08 Jun 2018 15:24:31 +0200

Gábor Boskovits <boskovits <at> gmail.com> skribis:

> Thanks, Ludo, this seems to be the correct fix. Thanks for the additional
> insight.
> Please push it.

Pushed as 751164bca1030dfd14f9fa7508c03eb4b41173e4, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.