GNU bug report logs - #30667
'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30667 in the body.
You can then email your comments to 30667 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <bug-guix <at> gnu.org>
Subject: 'guix system vm' must keep mount_tag-length limited below 32 bytes
 for --expose and --share
Date: Thu, 1 Mar 2018 19:05:50 +0100

[Message part 1 (text/plain, inline)]

I prepared a QEMU VM with:

./pre-inst-env  guix system vm \
--expose=/home/bjoern/digikam-testpool/=/image-pool \
../guix-systems/digikam-test.scm

Starting the VM it complained:

$> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh 
qemu-system-x86_64: -virtfs local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_: mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer than maximum (31 bytes)

I haven't looked into the Guix code, but I suppose there is somewhere
a place where the command line and the '/etc/fstab' file is filled
with the mount tags.

Here we should check the tag-length and shrink it (uniquely) if
it is more than 31 bytes in size.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 30667-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 30667-done <at> debbugs.gnu.org
Subject: Re: bug#30667: 'guix system vm' must keep mount_tag-length limited
 below 32 bytes for --expose and --share
Date: Thu, 08 Mar 2018 11:56:57 +0100

Hi Björn,

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:

> I prepared a QEMU VM with:
>
> ./pre-inst-env  guix system vm \
> --expose=/home/bjoern/digikam-testpool/=/image-pool \
> ../guix-systems/digikam-test.scm
>
> Starting the VM it complained:
>
> $> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh 
> qemu-system-x86_64: -virtfs local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_: mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer than maximum (31 bytes)

Fixed in dffc5ab5e47e45b94188828205c8d567994926ad, thanks!

Ludo’.

Message #13 received at 30667-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 30667-done <at> debbugs.gnu.org
Subject: Re: bug#30667: 'guix system vm' must keep mount_tag-length limited
 below 32 bytes for --expose and --share
Date: Sat, 10 Mar 2018 15:46:16 +0100

[Message part 1 (text/plain, inline)]

On Thu, 08 Mar 2018 11:56:57 +0100
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hi Björn,
> 
> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:
> 
> > I prepared a QEMU VM with:
> >
> > ./pre-inst-env  guix system vm \
> > --expose=/home/bjoern/digikam-testpool/=/image-pool \
> > ../guix-systems/digikam-test.scm
> >
> > Starting the VM it complained:
> >  
> > $> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh   
> > qemu-system-x86_64: -virtfs
> > local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_:
> > mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer
> > than maximum (31 bytes)  
> 
> Fixed in dffc5ab5e47e45b94188828205c8d567994926ad, thanks!
> 
> Ludo’.

Tested. Works. Thanks for fixing it!

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.