GNU bug report logs - #30649
shepherd services with #:log-file overwrite their log file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30649 in the body.
You can then email your comments to 30649 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: bug-guix <at> gnu.org
Subject: Cuirass service does not rotate its logs
Date: Wed, 28 Feb 2018 15:50:39 +0100

Hello,

while testing the cuirass service on bayfront, I see the following:

$ ll /var/log/c*
-rw-r--r-- 1 root root 2003521 Feb 28 15:38 /var/log/cuirass.log

I am sure this 2MB file was about 14MB big this morning, and indeed
any information dating from before this morning, when I rebooted the
machine and thus restarted the service, has gone.

Notice also that there are no numbered files cuirass.log.1 etc..

Andreas

Message #8 received at 30649 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 30649 <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Wed, 28 Feb 2018 17:48:23 +0100

Hi Andreas,

On Wed, 28 Feb 2018 15:50:39 +0100
Andreas Enge <andreas <at> enge.fr> wrote:

> $ ll /var/log/c*
> -rw-r--r-- 1 root root 2003521 Feb 28 15:38 /var/log/cuirass.log
> 
> I am sure this 2MB file was about 14MB big this morning, and indeed
> any information dating from before this morning, when I rebooted the
> machine and thus restarted the service, has gone.
> 
> Notice also that there are no numbered files cuirass.log.1 etc..

The simplest and best way to fix that is to make cuirass use syslog.

Not every program has to have its own private logging implementation,
log rotator, log filterting, log rate limiter, kitchen sink etc.

src/cuirass/logging.scm is prepared somewhat for this possiblity[2], but it
doesn't yet log to syslog.

There are guile syslog bindings[1] and we should use them and then apply a
two-line patch to src/cuirass/logging.scm .

[1] http://puszcza.gnu.org.ua/software/gamma/manual/html_section/Syslog.html
[2] Replace current-logging-procedure

Message #11 received at 30649 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Andreas Enge <andreas <at> enge.fr>, 30649 <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Thu, 01 Mar 2018 17:35:09 +0100

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> Hi Andreas,
>
> On Wed, 28 Feb 2018 15:50:39 +0100
> Andreas Enge <andreas <at> enge.fr> wrote:
>
>> $ ll /var/log/c*
>> -rw-r--r-- 1 root root 2003521 Feb 28 15:38 /var/log/cuirass.log
>> 
>> I am sure this 2MB file was about 14MB big this morning, and indeed
>> any information dating from before this morning, when I rebooted the
>> machine and thus restarted the service, has gone.
>> 
>> Notice also that there are no numbered files cuirass.log.1 etc..
>
> The simplest and best way to fix that is to make cuirass use syslog.
>
> Not every program has to have its own private logging implementation,
> log rotator, log filterting, log rate limiter, kitchen sink etc.
>
> src/cuirass/logging.scm is prepared somewhat for this possiblity[2], but it
> doesn't yet log to syslog.
>
> There are guile syslog bindings[1] and we should use them and then apply a
> two-line patch to src/cuirass/logging.scm .

Indeed.  I wonder why we don’t have a Gamma package yet!

Ludo’.

Message #14 received at 30649 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 30649 <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Thu, 01 Mar 2018 17:35:54 +0100

Andreas Enge <andreas <at> enge.fr> skribis:

> while testing the cuirass service on bayfront, I see the following:
>
> $ ll /var/log/c*
> -rw-r--r-- 1 root root 2003521 Feb 28 15:38 /var/log/cuirass.log

The cuirass service in GuixSD explicitly extends rottlog so that this
file is rotated on a weekly basis.  Perhaps you just need to wait a
little longer?

Ludo’.

Message #17 received at 30649 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 30649 <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Thu, 01 Mar 2018 17:36:45 +0100

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Andreas Enge <andreas <at> enge.fr> skribis:
>
>> while testing the cuirass service on bayfront, I see the following:
>>
>> $ ll /var/log/c*
>> -rw-r--r-- 1 root root 2003521 Feb 28 15:38 /var/log/cuirass.log
>
> The cuirass service in GuixSD explicitly extends rottlog so that this
> file is rotated on a weekly basis.  Perhaps you just need to wait a
> little longer?

I confirm that rotation works as expected on berlin.

Ludo’.

Message #20 received at 30649 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30649 <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Thu, 1 Mar 2018 17:43:10 +0100

On Thu, Mar 01, 2018 at 05:35:54PM +0100, Ludovic Courtès wrote:
> The cuirass service in GuixSD explicitly extends rottlog so that this
> file is rotated on a weekly basis.  Perhaps you just need to wait a
> little longer?

The problem is not that the file grows too large.

The problem was that after rebooting the server, the file was *replaced*
with newly written content. Maybe the problem is not rotation, but opening
a file in "write" instead of "append" mode...

Andreas

Message #27 received at 30649-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 30649-done <at> debbugs.gnu.org
Subject: Re: bug#30649: Cuirass service does not rotate its logs
Date: Fri, 02 Mar 2018 00:47:55 +0100

Andreas Enge <andreas <at> enge.fr> skribis:

> On Thu, Mar 01, 2018 at 05:35:54PM +0100, Ludovic Courtès wrote:
>> The cuirass service in GuixSD explicitly extends rottlog so that this
>> file is rotated on a weekly basis.  Perhaps you just need to wait a
>> little longer?
>
> The problem is not that the file grows too large.
>
> The problem was that after rebooting the server, the file was *replaced*
> with newly written content. Maybe the problem is not rotation, but opening
> a file in "write" instead of "append" mode...

Oh indeed, that’s a different thing.

This is fixed by Shepherd commit
7b4c88bac70f0bad82ef70fd5b682a49bc227478, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.