GNU bug report logs - #30601
[PATCH staging] gnu: ninja: Disable tests on armhf.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30601 in the body.
You can then email your comments to 30601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Sun, 25 Feb 2018 04:54:38 +0100

* gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
CHECK-PHASE accordingly.
---
 gnu/packages/ninja.scm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
index adb236484..cff2ac38b 100644
--- a/gnu/packages/ninja.scm
+++ b/gnu/packages/ninja.scm
@@ -42,7 +42,15 @@
     (build-system gnu-build-system)
     (native-inputs `(("python" ,python-2)))
     (arguments
-     '(#:phases
+     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
+     ;;   *** Failure in src/subprocess_test.cc:241
+     ;;   ExitSuccess == procs[i]->Finish()
+     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
+     ;; Disable for now.
+     `(#:tests? (let ((system ,(or (%current-target-system)
+                                   (%current-system))))
+                  (not (string-prefix? "arm" system)))
+       #:phases
        (modify-phases %standard-phases
          (replace 'configure
            (lambda _
@@ -53,10 +61,12 @@
            (lambda _
              (invoke "./configure.py" "--bootstrap")))
          (replace 'check
-           (lambda _
-             (invoke "./configure.py")
-             (invoke "./ninja" "ninja_test")
-             (invoke "./ninja_test")))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (if tests?
+                 (and (invoke "./configure.py")
+                      (invoke "./ninja" "ninja_test")
+                      (invoke "./ninja_test"))
+                 (display "test suite not run\n"))))
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
-- 
2.16.2

Message #8 received at 30601 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30601 <at> debbugs.gnu.org
Subject: Re: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Mon, 26 Feb 2018 18:49:49 +0100

Hi!

Marius Bakke <mbakke <at> fastmail.com> skribis:

> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
> CHECK-PHASE accordingly.
> ---
>  gnu/packages/ninja.scm | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
> index adb236484..cff2ac38b 100644
> --- a/gnu/packages/ninja.scm
> +++ b/gnu/packages/ninja.scm
> @@ -42,7 +42,15 @@
>      (build-system gnu-build-system)
>      (native-inputs `(("python" ,python-2)))
>      (arguments
> -     '(#:phases
> +     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
> +     ;;   *** Failure in src/subprocess_test.cc:241
> +     ;;   ExitSuccess == procs[i]->Finish()
> +     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
> +     ;; Disable for now.

Sounds reasonable.  Could you also report it upstream?  :-)

Thanks,
Ludo’.

Message #13 received at 30601-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30601-done <at> debbugs.gnu.org
Subject: Re: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Mon, 26 Feb 2018 20:40:59 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
>> CHECK-PHASE accordingly.
>> ---
>>  gnu/packages/ninja.scm | 20 +++++++++++++++-----
>>  1 file changed, 15 insertions(+), 5 deletions(-)
>>
>> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
>> index adb236484..cff2ac38b 100644
>> --- a/gnu/packages/ninja.scm
>> +++ b/gnu/packages/ninja.scm
>> @@ -42,7 +42,15 @@
>>      (build-system gnu-build-system)
>>      (native-inputs `(("python" ,python-2)))
>>      (arguments
>> -     '(#:phases
>> +     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
>> +     ;;   *** Failure in src/subprocess_test.cc:241
>> +     ;;   ExitSuccess == procs[i]->Finish()
>> +     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
>> +     ;; Disable for now.
>
> Sounds reasonable.  Could you also report it upstream?  :-)

Actually, now that I'm more awake, I found the problem.  On most
machines this test is skipped because it requires 1025 open files.
However, on Hydras armhf machines, this limit is apparently higher.

The problem is that the test calls out to /bin/echo.  I was able to
reproduce it on x86_64 simply by raising the softlimit to 4096.

So, I pushed a one-line fix as d0de4c40e24ee52e4382ee2ac82088932ab49099.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 30601-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30601-done <at> debbugs.gnu.org
Subject: Re: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Mon, 26 Feb 2018 21:02:07 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hi!
>>
>> Marius Bakke <mbakke <at> fastmail.com> skribis:
>>
>>> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
>>> CHECK-PHASE accordingly.
>>> ---
>>>  gnu/packages/ninja.scm | 20 +++++++++++++++-----
>>>  1 file changed, 15 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
>>> index adb236484..cff2ac38b 100644
>>> --- a/gnu/packages/ninja.scm
>>> +++ b/gnu/packages/ninja.scm
>>> @@ -42,7 +42,15 @@
>>>      (build-system gnu-build-system)
>>>      (native-inputs `(("python" ,python-2)))
>>>      (arguments
>>> -     '(#:phases
>>> +     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
>>> +     ;;   *** Failure in src/subprocess_test.cc:241
>>> +     ;;   ExitSuccess == procs[i]->Finish()
>>> +     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
>>> +     ;; Disable for now.
>>
>> Sounds reasonable.  Could you also report it upstream?  :-)
>
> Actually, now that I'm more awake, I found the problem.  On most
> machines this test is skipped because it requires 1025 open files.
> However, on Hydras armhf machines, this limit is apparently higher.
>
> The problem is that the test calls out to /bin/echo.  I was able to
> reproduce it on x86_64 simply by raising the softlimit to 4096.
>
> So, I pushed a one-line fix as d0de4c40e24ee52e4382ee2ac82088932ab49099.

Derp.  Apparently I wasn't awake enough and managed to patch the wrong
file when making the commit.  The followup in
6d796220c417a34100c282a7fa1f9afb6ac00339 fixes it, sorry for the noise.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 30601-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30601-done <at> debbugs.gnu.org
Subject: Re: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Tue, 27 Feb 2018 10:05:22 +0100

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Ludovic Courtès <ludo <at> gnu.org> writes:
>>
>>> Hi!
>>>
>>> Marius Bakke <mbakke <at> fastmail.com> skribis:
>>>
>>>> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
>>>> CHECK-PHASE accordingly.
>>>> ---
>>>>  gnu/packages/ninja.scm | 20 +++++++++++++++-----
>>>>  1 file changed, 15 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
>>>> index adb236484..cff2ac38b 100644
>>>> --- a/gnu/packages/ninja.scm
>>>> +++ b/gnu/packages/ninja.scm
>>>> @@ -42,7 +42,15 @@
>>>>      (build-system gnu-build-system)
>>>>      (native-inputs `(("python" ,python-2)))
>>>>      (arguments
>>>> -     '(#:phases
>>>> +     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
>>>> +     ;;   *** Failure in src/subprocess_test.cc:241
>>>> +     ;;   ExitSuccess == procs[i]->Finish()
>>>> +     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
>>>> +     ;; Disable for now.
>>>
>>> Sounds reasonable.  Could you also report it upstream?  :-)
>>
>> Actually, now that I'm more awake, I found the problem.  On most
>> machines this test is skipped because it requires 1025 open files.
>> However, on Hydras armhf machines, this limit is apparently higher.
>>
>> The problem is that the test calls out to /bin/echo.  I was able to
>> reproduce it on x86_64 simply by raising the softlimit to 4096.
>>
>> So, I pushed a one-line fix as d0de4c40e24ee52e4382ee2ac82088932ab49099.
>
> Derp.  Apparently I wasn't awake enough and managed to patch the wrong
> file when making the commit.  The followup in
> 6d796220c417a34100c282a7fa1f9afb6ac00339 fixes it, sorry for the noise.

Heh, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.