GNU bug report logs - #30270
[PATCH] url-fetch returns #t instead of FILE

Previous Next

Package: guix;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Sat, 27 Jan 2018 17:31:01 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30270 in the body.
You can then email your comments to 30270 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guix <at> gnu.org:
bug#30270; Package guix. (Sat, 27 Jan 2018 17:31:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Sat, 27 Jan 2018 17:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: [PATCH] url-fetch returns #t instead of FILE
Date: Sat, 27 Jan 2018 12:29:48 -0500

Hello!

Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t
instead of the file name (as the docstring says it should), which broke
the fiasco script used to find broken hashes of Github's archives[0].

Patch to follow.

[0]  https://notabug.org/apteryx/fiasco
Information forwarded to bug-guix <at> gnu.org:
bug#30270; Package guix. (Sat, 27 Jan 2018 17:36:02 GMT) Full text and rfc822 format available.

Message #8 received at 30270 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 30270 <at> debbugs.gnu.org
Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE
Date: Sat, 27 Jan 2018 12:35:44 -0500

[Message part 1 (text/plain, inline)]
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello!
>
> Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t
> instead of the file name (as the docstring says it should), which broke
> the fiasco script used to find broken hashes of Github's archives[0].
>
> Patch to follow.
  ^

[0001-download-Fix-return-value-of-the-url-fetch-procedure.patch (text/x-patch, attachment)]
Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Sun, 28 Jan 2018 22:03:01 GMT) Full text and rfc822 format available.
Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Sun, 28 Jan 2018 22:03:02 GMT) Full text and rfc822 format available.

Message #13 received at 30270-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 30270-done <at> debbugs.gnu.org
Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE
Date: Sun, 28 Jan 2018 23:02:14 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Sat, 27 Jan 2018 12:22:11 -0500
> Subject: [PATCH] download: Fix return value of the url-fetch procedure.
>
> Fixes #30270 which was introduced by commit 347fa4aebf.
>
> * guix/build/download.scm (url-fetch): Return `file' instead of #t upon success.

Good catch!

I changed the log to read “Fixes <http://...>” and committed.

Thanks,
Ludo’.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 26 Feb 2018 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 59 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.