GNU bug report logs - #28974
[PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28974 in the body.
You can then email your comments to 28974 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at
 runtime.
Date: Tue, 24 Oct 2017 14:59:54 -0400

When trying to install syslinux to a FAT partition, it requires the
mtools (particularly mcopy) to be available at runtime in PATH.

---
 gnu/packages/bootloaders.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 613537a5d..b747ca579 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -44,6 +44,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages virtualization)
+  #:use-module (gnu packages mtools)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -237,6 +238,8 @@ menu to select one of the installed operating systems.")
          ("python-2" ,python-2)))
       (inputs
        `(("libuuid" ,util-linux)))
+      (propagated-inputs
+         `(("mtools" ,mtools)))
       (arguments
        `(#:parallel-build? #f
          #:make-flags
-- 
2.14.2

Message #8 received at 28974 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 28974 <at> debbugs.gnu.org
Subject: Re: [bug#28974] [PATCH 1/1] gnu: syslinux: Propagate mtools as
 syslinux needs it at runtime.
Date: Wed, 25 Oct 2017 22:09:22 -0700

[Message part 1 (text/plain, inline)]

Hi Adam,

Adam Van Ymeren <adam <at> vany.ca> skribis:

> When trying to install syslinux to a FAT partition, it requires the
> mtools (particularly mcopy) to be available at runtime in PATH.

[...]

> +      (propagated-inputs
> +         `(("mtools" ,mtools)))

A quick inspection showed uses of “mcopy” and “mattrib”.  To avoid
propagating mtools, I propose the patch below.

Could you check if it works for you?

Thank you,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 613537a5d..b4372748c 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -236,7 +236,8 @@ menu to select one of the installed operating systems.")
          ("perl" ,perl)
          ("python-2" ,python-2)))
       (inputs
-       `(("libuuid" ,util-linux)))
+       `(("libuuid" ,util-linux)
+         ("mtools" ,mtools)))
       (arguments
        `(#:parallel-build? #f
          #:make-flags
@@ -251,11 +252,17 @@ menu to select one of the installed operating systems.")
          #:phases
          (modify-phases %standard-phases
            (add-after 'unpack 'patch-files
-             (lambda _
+             (lambda* (#:key inputs #:allow-other-keys)
                (substitute* (find-files "." "Makefile.*|ppmtolss16")
                  (("/bin/pwd") (which "pwd"))
                  (("/bin/echo") (which "echo"))
                  (("/usr/bin/perl") (which "perl")))
+               (let ((mtools (assoc-ref inputs "mtools")))
+                 (substitute* (find-files "." "\\.c$")
+                   (("mcopy")
+                    (string-append mtools "/bin/mcopy"))
+                   (("mattrib")
+                    (string-append mtools "/bin/mattrib"))))
                #t))
            (delete 'configure)
            (add-before 'build 'set-permissions

Message #13 received at 28974-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 28974-done <at> debbugs.gnu.org
Subject: Re: [bug#28974] [PATCH 1/1] gnu: syslinux: Propagate mtools as
 syslinux needs it at runtime.
Date: Thu, 16 Nov 2017 10:45:10 +0100

Hi Adam,

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Adam Van Ymeren <adam <at> vany.ca> skribis:
>
>> When trying to install syslinux to a FAT partition, it requires the
>> mtools (particularly mcopy) to be available at runtime in PATH.
>
> [...]
>
>> +      (propagated-inputs
>> +         `(("mtools" ,mtools)))
>
> A quick inspection showed uses of “mcopy” and “mattrib”.  To avoid
> propagating mtools, I propose the patch below.
>
> Could you check if it works for you?

It LGTM so I pushed it as 0b4dbb401cd94cd04eab3a25f80cbb3fcd3d1daf.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.