GNU bug report logs - #28647
[PATCH] services: base: Add file->udev-rule function.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 29 Sep 2017 16:00:02 UTC

Severity: normal

Tags: fixed, patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28647 in the body.
You can then email your comments to 28647 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Fri, 29 Sep 2017 16:00:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 29 Sep 2017 16:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] services: base: Add file->udev-rule function.
Date: Fri, 29 Sep 2017 11:58:58 -0400

[Message part 1 (text/plain, inline)]
Hello,

While experimenting with udev rules, I found a need to be able to pass
file-like objects containing udev rules to the udev-service. This patch
implements a `file->udev-rule' method that does just that.


[0001-services-base-Add-file-udev-rule-function.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Below is an operating-system declaration that makes use of it.


[config.scm (text/plain, attachment)]
[Message part 5 (text/plain, inline)]
Thanks,

Maxim
Information forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Tue, 03 Oct 2017 13:20:01 GMT) Full text and rfc822 format available.

Message #8 received at 28647 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28647 <at> debbugs.gnu.org
Subject: Re: [bug#28647] [PATCH] services: base: Add file->udev-rule function.
Date: Tue, 03 Oct 2017 15:18:49 +0200

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> While experimenting with udev rules, I found a need to be able to pass
> file-like objects containing udev rules to the udev-service. This patch
> implements a `file->udev-rule' method that does just that.

Looks useful!

> From 050e96b3325f851f3118de0c881d25796d76049b Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Wed, 27 Sep 2017 21:33:25 -0400
> Subject: [PATCH] services: base: Add file->udev-rule function.
>
> This function allows passing a file-like object to the udev service.
>
> * gnu/services/base.scm (file->udev-rule): New function.
> * doc/guix.texi (Base Services): Document it.

[...]

> -@deffn {Scheme Procedure} udev-service [#:udev udev]
> +@deffn {Scheme Procedure} udev-service [#:udev @var{eudev} #:rules @code{'()}]
>  Run @var{udev}, which populates the @file{/dev} directory dynamically.
> +Packages can be included in the @var{rules} list in order to extend the
> +udev rules with the definitions found under their
> +@file{lib/udev/rules.d} sub-directory.
> +
> +The functions @code{udev-rules} and @code{file->udev-rules} from
> +@code{(gnu services base)} can be used to create rule objects based on a
> +string or a file-like object, respectively. Those rule objects can be
> +passed to udev-service just like packages.

Could you document the procedures with @deffn so that they have an entry
in the index?

  @deffn {Scheme Procedure} udev-rules @var{rules}
  …
  @end deffn

  @deffn {Scheme Procedure} file->udev-rules @var{files}
  Similar to @code{udev-rules}, but…
  @end deffn

TIA!

Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Tue, 03 Oct 2017 13:21:02 GMT) Full text and rfc822 format available.

Message #11 received at 28647 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28647 <at> debbugs.gnu.org
Subject: Re: [bug#28647] [PATCH] services: base: Add file->udev-rule function.
Date: Tue, 03 Oct 2017 15:20:35 +0200

Also, could you add an example in guix.texi that shows the use of the
Android udev rules that you submitted separately?

Thanks,
Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Sun, 22 Oct 2017 22:17:01 GMT) Full text and rfc822 format available.

Message #14 received at 28647 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28647 <at> debbugs.gnu.org
Subject: Re: [bug#28647] [PATCH] services: base: Add file->udev-rule function.
Date: Sun, 22 Oct 2017 15:16:28 -0700

Hey Maxim,

Just a friendly reminder.  :-)

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> While experimenting with udev rules, I found a need to be able to pass
>> file-like objects containing udev rules to the udev-service. This patch
>> implements a `file->udev-rule' method that does just that.
>
> Looks useful!
>
>> From 050e96b3325f851f3118de0c881d25796d76049b Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 27 Sep 2017 21:33:25 -0400
>> Subject: [PATCH] services: base: Add file->udev-rule function.
>>
>> This function allows passing a file-like object to the udev service.
>>
>> * gnu/services/base.scm (file->udev-rule): New function.
>> * doc/guix.texi (Base Services): Document it.
>
> [...]
>
>> -@deffn {Scheme Procedure} udev-service [#:udev udev]
>> +@deffn {Scheme Procedure} udev-service [#:udev @var{eudev} #:rules @code{'()}]
>>  Run @var{udev}, which populates the @file{/dev} directory dynamically.
>> +Packages can be included in the @var{rules} list in order to extend the
>> +udev rules with the definitions found under their
>> +@file{lib/udev/rules.d} sub-directory.
>> +
>> +The functions @code{udev-rules} and @code{file->udev-rules} from
>> +@code{(gnu services base)} can be used to create rule objects based on a
>> +string or a file-like object, respectively. Those rule objects can be
>> +passed to udev-service just like packages.
>
> Could you document the procedures with @deffn so that they have an entry
> in the index?
>
>   @deffn {Scheme Procedure} udev-rules @var{rules}
>   …
>   @end deffn
>
>   @deffn {Scheme Procedure} file->udev-rules @var{files}
>   Similar to @code{udev-rules}, but…
>   @end deffn
>
> TIA!
>
> Ludo’.

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Also, could you add an example in guix.texi that shows the use of the
> Android udev rules that you submitted separately?
>
> Thanks,
> Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Mon, 23 Oct 2017 01:54:02 GMT) Full text and rfc822 format available.

Message #17 received at 28647 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28647 <at> debbugs.gnu.org
Subject: Re: [bug#28647] [PATCHv2] services: base: Add file->udev-rule
 function.
Date: Sun, 22 Oct 2017 21:53:28 -0400

[Message part 1 (text/plain, inline)]
Hi Ludovic, and sorry for the delayed reply!

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> While experimenting with udev rules, I found a need to be able to pass
>> file-like objects containing udev rules to the udev-service. This patch
>> implements a `file->udev-rule' method that does just that.
>
> Looks useful!
>
>> From 050e96b3325f851f3118de0c881d25796d76049b Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 27 Sep 2017 21:33:25 -0400
>> Subject: [PATCH] services: base: Add file->udev-rule function.
>>
>> This function allows passing a file-like object to the udev service.
>>
>> * gnu/services/base.scm (file->udev-rule): New function.
>> * doc/guix.texi (Base Services): Document it.
>
> [...]
>
>> -@deffn {Scheme Procedure} udev-service [#:udev udev]
>> +@deffn {Scheme Procedure} udev-service [#:udev @var{eudev} #:rules @code{'()}]
>>  Run @var{udev}, which populates the @file{/dev} directory dynamically.
>> +Packages can be included in the @var{rules} list in order to extend the
>> +udev rules with the definitions found under their
>> +@file{lib/udev/rules.d} sub-directory.
>> +
>> +The functions @code{udev-rules} and @code{file->udev-rules} from
>> +@code{(gnu services base)} can be used to create rule objects based on a
>> +string or a file-like object, respectively. Those rule objects can be
>> +passed to udev-service just like packages.
>
> Could you document the procedures with @deffn so that they have an entry
> in the index?
>
>   @deffn {Scheme Procedure} udev-rules @var{rules}
>   …
>   @end deffn
>
>   @deffn {Scheme Procedure} file->udev-rules @var{files}
>   Similar to @code{udev-rules}, but…
>   @end deffn
>

I'm hoping the attached patch addresses the requested additions. Thanks
for the review and comments.

Maxim


[0001-services-base-Add-file-udev-rule-function.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#28647; Package guix-patches. (Mon, 23 Oct 2017 02:40:01 GMT) Full text and rfc822 format available.

Message #20 received at 28647 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28647 <at> debbugs.gnu.org
Subject: Re: [bug#28647] [PATCHv2] services: base: Add file->udev-rule
 function.
Date: Sun, 22 Oct 2017 19:39:24 -0700

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> I'm hoping the attached patch addresses the requested additions. Thanks
> for the review and comments.

It does!

> From d2da854ad8d9d0d588c646e439ebfb7ef1c21f7c Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Wed, 27 Sep 2017 21:33:25 -0400
> Subject: [PATCH] services: base: Add file->udev-rule function.
>
> This function allows passing a file-like object to the udev service.
>
> * gnu/services/base.scm (file->udev-rule): New function.
> * doc/guix.texi (Base Services): Document it.

Applied, thanks!

Ludo’.
Added tag(s) fixed. Request was from ludo <at> gnu.org (Ludovic Courtès) to control <at> debbugs.gnu.org. (Mon, 23 Oct 2017 02:40:02 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 28647 <at> debbugs.gnu.org and Maxim Cournoyer <maxim.cournoyer <at> gmail.com> Request was from ludo <at> gnu.org (Ludovic Courtès) to control <at> debbugs.gnu.org. (Mon, 23 Oct 2017 02:40:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Nov 2017 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 158 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.