GNU bug report logs - #28310
Grafting prevents build plan from being displayed upfront

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28310 in the body.
You can then email your comments to 28310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: bug-guix <at> gnu.org
Subject: guix build -n misses package builds
Date: Thu, 31 Aug 2017 21:03:34 +0200

Hello,

I am right now in the process of updating pari-gp to version 2.9.3.
After building it on a git check-out of three days ago, which went smoothly,
I rebased my patch on today's master and was pleased to see that no rebuild
was needed:

$ ./pre-inst-env guix build pari-gp -n
outputs nothing.

However, once the -n dropped, the gd package gets built.
And then it is starting ruby, which has no connection to pari-gp:
Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
   ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^

Andreas

Message #10 received at 28310 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 28310 <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Sat, 02 Sep 2017 01:08:12 +0200

Hello,

Andreas Enge <andreas <at> enge.fr> skribis:

> I am right now in the process of updating pari-gp to version 2.9.3.
> After building it on a git check-out of three days ago, which went smoothly,
> I rebased my patch on today's master and was pleased to see that no rebuild
> was needed:
>
> $ ./pre-inst-env guix build pari-gp -n
> outputs nothing.
>
> However, once the -n dropped, the gd package gets built.
> And then it is starting ruby, which has no connection to pari-gp:
> Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
>    ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^

“-n” now implies “--no-grafts” (commit
fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
need to have -n really perform a dry run.

The downside is that with -n we now see only half of the build plan, and
when we remove -n, we start with the other half of the build plan,
grafting.

The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
<https://bugs.gnu.org/22990>, could in theory help with that.

Ludo’.

Message #13 received at 28310 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 28310 <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Sat, 2 Sep 2017 12:04:00 +0200

Hello,

On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.

if I understand your answer correctly, then no output with "-n" means that
the ungrafted packages are already available in my store.

> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.

Then this other half would just be grafting, which would not require to
download source and build packages locally.

Or are the built packages the replacements for packages with security
updates, that are grafted upon the existing packages?

Andreas

Message #16 received at 28310 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 28310 <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Sat, 02 Sep 2017 22:13:32 +0200

Hi,

Andreas Enge <andreas <at> enge.fr> skribis:

> On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
>> “-n” now implies “--no-grafts” (commit
>> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
>> need to have -n really perform a dry run.
>
> if I understand your answer correctly, then no output with "-n" means that
> the ungrafted packages are already available in my store.

Exactly.

>> The downside is that with -n we now see only half of the build plan, and
>> when we remove -n, we start with the other half of the build plan,
>> grafting.
>
> Then this other half would just be grafting, which would not require to
> download source and build packages locally.

Grafting usually means downloading/building the replacements first, and
finally performing the actual graft.

I agree it makes it harder to follow from a user viewpoint.

Cheers,
Ludo’.

Message #21 received at 28310-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 28310-done <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Thu, 7 Sep 2017 14:42:55 +0200

On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.
> 
> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.
> 
> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
> <https://bugs.gnu.org/22990>, could in theory help with that.

Okay, so to simplify, I am closing this bug report.

Andreas

Message #28 received at 28310 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 28310 <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Thu, 07 Sep 2017 15:24:01 +0200

Andreas Enge <andreas <at> enge.fr> skribis:

> On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
>> “-n” now implies “--no-grafts” (commit
>> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
>> need to have -n really perform a dry run.
>> 
>> The downside is that with -n we now see only half of the build plan, and
>> when we remove -n, we start with the other half of the build plan,
>> grafting.
>> 
>> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
>> <https://bugs.gnu.org/22990>, could in theory help with that.
>
> Okay, so to simplify, I am closing this bug report.

I’ve reopened it (it’s a real problem after all) so we can keep track of
it, and feel the relief when we finally close it.  :-)

Ludo’.

Message #33 received at 28310-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 28310-done <at> debbugs.gnu.org
Subject: Re: bug#28310: guix build -n misses package builds
Date: Sun, 22 Mar 2020 12:48:39 +0100

Hello,

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Andreas Enge <andreas <at> enge.fr> skribis:
>
>> I am right now in the process of updating pari-gp to version 2.9.3.
>> After building it on a git check-out of three days ago, which went smoothly,
>> I rebased my patch on today's master and was pleased to see that no rebuild
>> was needed:
>>
>> $ ./pre-inst-env guix build pari-gp -n
>> outputs nothing.
>>
>> However, once the -n dropped, the gd package gets built.
>> And then it is starting ruby, which has no connection to pari-gp:
>> Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
>>    ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^
>
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.
>
> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.

This is now fixed with this patch series:

  https://issues.guix.gnu.org/issue/40130

It does mean that “The following derivations will be built” can be
printed several times during a build.  That’s a natural consequence of
having dynamic dependencies (grafts) in the graph: we can’t always
statically determine what’s going to be built.

> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
> <https://bugs.gnu.org/22990>, could in theory help with that.

‘with-build-handler’ also has to do with continuations, only in a
different way.  :-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.