GNU bug report logs - #28285
Add heimdall

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28285 in the body.
You can then email your comments to 28285 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Add heimdall
Date: Tue, 29 Aug 2017 23:58:29 +0200

[Message part 1 (text/plain, inline)]

Hi,

this patch adds heimdall, a tool I just used to flash replicant on my
smartphone :)

[0001-gnu-Add-heimdall.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: guix-patches <at> gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Wed, 30 Aug 2017 10:13:25 +0200

Maybe we could do it in "flashing-tools.scm".

Am 29.08.2017 um 23:58 schrieb Julien Lepiller:
> Hi,
> 
> this patch adds heimdall, a tool I just used to flash replicant on my
> smartphone :)
> 

Message #11 received at 28285 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>, 28285 <at> debbugs.gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Wed, 30 Aug 2017 21:25:51 +0200

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> Hi,
>
> this patch adds heimdall, a tool I just used to flash replicant on my
> smartphone :)

Cool!

> * gnu/packages/android.scm (heimdall): New variable.

I agree with Jonathan that 'flashing-tools.scm' is better suited.

[...]

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +               (mkdir-p bin)
> +               (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> +               (copy-file "bin/heimdall-frontend"
> +                          (string-append bin "/heimdall-frontend"))))))))

(copy-file ...) has an unspecified return value[0], so please add a #t
at the end of this phase for determinism.

> +    (inputs
> +     `(("libusb" ,libusb)
> +       ("qt" ,qt)

Can you try to use the modular qt packages here (qtbase and friends),
instead of the 'qt' monolith?  The latter is not well maintained and
will be removed eventually.

> +       ("zlib" ,zlib)))
> +    (home-page "http://glassechidna.com.au/heimdall/")
> +    (synopsis "Flash firmware onto Samsung mobile devices")
> +    (description "Heimdall is a tool suite used to flash firmware (aka ROMs)
> +onto Samsung mobile devices.  Heimdall connects to a mobile device over USB and
> +interacts with low-level software running on the device, known as Loke.  Loke
> +and Heimdall communicate via the custom Samsung-developed protocol typically
> +referred to as the 'Odin 3 protocol'.")

`guix lint` should complain about the single quotes, no?  Escaped double
quotes are okay, though.

LGTM with these cosmetic changes.

[0] https://www.gnu.org/software/guile/manual/guile.html#File-System

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28285 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 28285 <at> debbugs.gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Sun, 3 Sep 2017 18:53:06 +0200

[Message part 1 (text/plain, inline)]

Le Wed, 30 Aug 2017 21:25:51 +0200,
Marius Bakke <mbakke <at> fastmail.com> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > Hi,
> >
> > this patch adds heimdall, a tool I just used to flash replicant on
> > my smartphone :)  
> 
> Cool!
> 
> > * gnu/packages/android.scm (heimdall): New variable.  
> 
> I agree with Jonathan that 'flashing-tools.scm' is better suited.
> 
> [...]
Ok.

> 
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let ((bin (string-append (assoc-ref outputs "out")
> > "/bin")))
> > +               (mkdir-p bin)
> > +               (copy-file "bin/heimdall" (string-append bin
> > "/heimdall"))
> > +               (copy-file "bin/heimdall-frontend"
> > +                          (string-append bin
> > "/heimdall-frontend"))))))))  
> 
> (copy-file ...) has an unspecified return value[0], so please add a #t
> at the end of this phase for determinism.
Done.

> 
> > +    (inputs
> > +     `(("libusb" ,libusb)
> > +       ("qt" ,qt)  
> 
> Can you try to use the modular qt packages here (qtbase and friends),
> instead of the 'qt' monolith?  The latter is not well maintained and
> will be removed eventually.
only qtbase is needed it seems. Done.

> 
> > +       ("zlib" ,zlib)))
> > +    (home-page "http://glassechidna.com.au/heimdall/")
> > +    (synopsis "Flash firmware onto Samsung mobile devices")
> > +    (description "Heimdall is a tool suite used to flash firmware
> > (aka ROMs) +onto Samsung mobile devices.  Heimdall connects to a
> > mobile device over USB and +interacts with low-level software
> > running on the device, known as Loke.  Loke +and Heimdall
> > communicate via the custom Samsung-developed protocol typically
> > +referred to as the 'Odin 3 protocol'.")  
> 
> `guix lint` should complain about the single quotes, no?  Escaped
> double quotes are okay, though.
It doesn't. I'm not sure what you mean with escaped double quotes. \"
or \\\"?

> 
> LGTM with these cosmetic changes.
I had to change the import of licenses and license field of all
packages because heimdall depends on zlib, which is also a license
name. Should I mention that in the commit message too? Should it be in
a separate commit?

> 
> [0] https://www.gnu.org/software/guile/manual/guile.html#File-System

[0001-gnu-Add-heimdall.patch (text/x-patch, attachment)]

Message #17 received at 28285 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 28285 <at> debbugs.gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Mon, 04 Sep 2017 16:22:55 +0200

Hello,

Julien Lepiller <julien <at> lepiller.eu> skribis:

> I had to change the import of licenses and license field of all
> packages because heimdall depends on zlib, which is also a license
> name. Should I mention that in the commit message too? Should it be in
> a separate commit?

IMO it’s marginely better as a separate commit, but no big deal.

> From 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.

[...]

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +               (mkdir-p bin)
> +               (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> +               (copy-file "bin/heimdall-frontend"
> +                          (string-append bin "/heimdall-frontend"))

You can write these as:

  (install-file "bin/heimdall" bin)
  …

and also remove (mkdir-p bin).

OK with these changes!

Ludo’.

Message #22 received at 28285 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 28285 <at> debbugs.gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Fri, 8 Sep 2017 14:41:36 +0200

Hi Julien,

On Tue, 29 Aug 2017 23:58:29 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

> this patch adds heimdall, a tool I just used to flash replicant on my
> smartphone :)

There are udev rules in ./heimdall/60-heimdall.rules which we might want to install too.

And there's a libpit.a - not sure whether it makes sense to install it (whether it has public API).

Thoughts?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.