GNU bug report logs - #28253
perl-www-opensearch: provide Test-Simple module

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28253 in the body.
You can then email your comments to 28253 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: perl-www-opensearch: provide Test-Simple module
Date: Sun, 27 Aug 2017 18:28:55 +0000

[Message part 1 (text/plain, inline)]

This was supposed to fix the tests, but it doesn't
so someone has to fix the large number of failing tests.

Someone with perl test-simple knowledge or time to
read into it.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-perl-www-opensearch-Provide-Test-Simple.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 28253-close <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: ng0 <ng0 <at> infotropique.org>, 28253-close <at> debbugs.gnu.org
Subject: Re: [bug#28253] perl-www-opensearch: provide Test-Simple module
Date: Mon, 28 Aug 2017 22:28:47 +0200

[Message part 1 (text/plain, inline)]

ng0 <ng0 <at> infotropique.org> writes:

> This was supposed to fix the tests, but it doesn't
> so someone has to fix the large number of failing tests.
>
> Someone with perl test-simple knowledge or time to
> read into it.

I'm closing this bug, since guix-patches already has a huge backlog and
it's not a good avenue to discuss one-line work-in-progress patches.

If you would like assistance tracking down the failing test cases, I
suggest taking it on help-guix@ and/or upstream.

PS: We could use some help reviewing! :-)

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 28253-close <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 28253-close <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28253] perl-www-opensearch: provide Test-Simple module
Date: Mon, 28 Aug 2017 20:59:38 +0000

[Message part 1 (text/plain, inline)]

Marius Bakke transcribed 1.1K bytes:
> ng0 <ng0 <at> infotropique.org> writes:
> 
> > This was supposed to fix the tests, but it doesn't
> > so someone has to fix the large number of failing tests.
> >
> > Someone with perl test-simple knowledge or time to
> > read into it.
> 
> I'm closing this bug, since guix-patches already has a huge backlog and
> it's not a good avenue to discuss one-line work-in-progress patches.
> 
> If you would like assistance tracking down the failing test cases, I
> suggest taking it on help-guix@ and/or upstream.
> 
> PS: We could use some help reviewing! :-)

Uh. Why? I added a dependency and commented that tests are
failing. Previously it states that "some more perl packages
are required". This *is* an improvement over the current status.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 28253 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 28253 <at> debbugs.gnu.org
Subject: Re: [bug#28253] perl-www-opensearch: provide Test-Simple module
Date: Mon, 28 Aug 2017 21:24:19 +0000

[Message part 1 (text/plain, inline)]

Updated patch with a small comment grammar fix.

Purpose of this patch: to add a dependency which was
previously unknown and had to be figured out by the
person who would try to fix the tests. So to go from
"nothing, uh what do we need here?" to
"hey, we have the test dependency" is an improvement
and not just a "work in progress" one-liner.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-perl-www-opensearch-Provide-Test-Simple.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28253-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: ng0 <ng0 <at> infotropique.org>, 28253-done <at> debbugs.gnu.org
Subject: Re: [bug#28253] perl-www-opensearch: provide Test-Simple module
Date: Sat, 02 Sep 2017 12:45:15 +0200

[Message part 1 (text/plain, inline)]

ng0 <ng0 <at> infotropique.org> writes:

> Updated patch with a small comment grammar fix.
>
> Purpose of this patch: to add a dependency which was
> previously unknown and had to be figured out by the
> person who would try to fix the tests. So to go from
> "nothing, uh what do we need here?" to
> "hey, we have the test dependency" is an improvement
> and not just a "work in progress" one-liner.

Right.  I don't think adding dependencies that does not change anything
with the package is very useful.  A comment stating that this dependency
would be needed to enable tests would do the same purpose without
changing the derivation.  But, it would take any packager about 20
seconds to find that Test::Simple is needed, so it's kind of "stating
the obvious".

Anyway I tried building this package with tests enabled and just kept
adding the modules it could not find as native-inputs until it
succeeded.  So I pushed a superset of this patch as
3fe666aa29e72a9fbb1e267eebcd7d197ec802f3.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.