GNU bug report logs - #28054
coreutils 8.27 test failure on x86_64-foxkit-linux-musl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28054 in the body.
You can then email your comments to 28054 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "A. Wilcox" <awilfox <at> adelielinux.org>
To: bug-coreutils <at> gnu.org
Subject: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Fri, 11 Aug 2017 13:49:46 -0500

[Message part 1 (text/plain, inline)]

The first test failure, csplit-io-err, seems to be a simple error
message format change.

The third test failure, sort-debug-warn, seems to be sensitive to
locales.  I am not sure the best way to fix this.

Best,
--arw

-- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
http://adelielinux.org

[coreutils-test-suite.log (text/x-log, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 28054 <at> debbugs.gnu.org (full text, mbox):

From: "A. Wilcox" <awilfox <at> adelielinux.org>
To: 28054 <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Fri, 11 Aug 2017 15:38:24 -0500

[Message part 1 (text/plain, inline)]

Probing further at printf-surprise.sh, it appears that the problem is:

* musl is unaffected by the printf bug being tested

* therefore, it does successfully output 20 MiB of blank space

* `head -c 10 fifo` will read the first 10 characters of the fifo

* the rest of the 20 MiB cannot be written, so SIGPIPE is received

* 'exit=141' (- 128 = 13 = SIGPIPE)


I have attached a patch that fixes both csplit-io-err and
printf-surprise on my test box.

-- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
http://adelielinux.org

[coreutils-8.27-test-fixes.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 28054-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: "A. Wilcox" <awilfox <at> adelielinux.org>, 28054-done <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Sun, 13 Aug 2017 01:07:33 -0700

[Message part 1 (text/plain, inline)]

On 11/08/17 11:49, A. Wilcox wrote:

> FAIL: tests/misc/csplit-io-err
> ==============================
This was due to an inconsistency in the errors output by seq.
A fix for that buglet is attached.

> FAIL: tests/misc/printf-surprise
> ================================
Depending on exit 141 couples the script to the value of SIGPIPE
and to the shell implementation (ksh will return 269 here for e.g.).
So I've attached a solution that should hopefully work in all situations.

> FAIL: tests/misc/sort-debug-warn
> ================================
This was due to an assumption that for "missing" locales
that sort would fail to C rather than C.UTF8.
I've adjusted sort to not assume that in the attached.

thanks,
Pádraig

[seq-write-error.patch (text/x-patch, attachment)]

[printf-musl.patch (text/x-patch, attachment)]

[sort-debug-locale.patch (text/x-patch, attachment)]

Message #16 received at 28054 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 28054 <at> debbugs.gnu.org, Pádraig Brady <P <at> draigbrady.com>, 
 awilfox <at> adelielinux.org
Cc: 28054-done <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Sun, 13 Aug 2017 09:22:56 -0700

On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
> On 11/08/17 11:49, A. Wilcox wrote:
>
>> FAIL: tests/misc/csplit-io-err
>> ==============================
> This was due to an inconsistency in the errors output by seq.
> A fix for that buglet is attached.
>
>> FAIL: tests/misc/printf-surprise
>> ================================
> Depending on exit 141 couples the script to the value of SIGPIPE
> and to the shell implementation (ksh will return 269 here for e.g.).
> So I've attached a solution that should hopefully work in all situations.
>
>> FAIL: tests/misc/sort-debug-warn
>> ================================
> This was due to an assumption that for "missing" locales
> that sort would fail to C rather than C.UTF8.
> I've adjusted sort to not assume that in the attached.

Nice work. All three patches looks fine.  You might want to insert "in
https://bugs.gnu.org/28054" at the end of each log message.

Considering the use of "yes | :", even though there's an identical
prior use in tests/misc/seq-epipe.sh, I wondered if there exists a
shell/system where that would infloop. Maybe paranoid overkill, but
inserting a timeout would avoid the possibility.

Message #22 received at 28054 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>, 28054 <at> debbugs.gnu.org,
 awilfox <at> adelielinux.org
Cc: 28054-done <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Sun, 13 Aug 2017 21:30:29 -0700

On 13/08/17 09:22, Jim Meyering wrote:
> On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
>> On 11/08/17 11:49, A. Wilcox wrote:
>>
>>> FAIL: tests/misc/csplit-io-err
>>> ==============================
>> This was due to an inconsistency in the errors output by seq.
>> A fix for that buglet is attached.
>>
>>> FAIL: tests/misc/printf-surprise
>>> ================================
>> Depending on exit 141 couples the script to the value of SIGPIPE
>> and to the shell implementation (ksh will return 269 here for e.g.).
>> So I've attached a solution that should hopefully work in all situations.
>>
>>> FAIL: tests/misc/sort-debug-warn
>>> ================================
>> This was due to an assumption that for "missing" locales
>> that sort would fail to C rather than C.UTF8.
>> I've adjusted sort to not assume that in the attached.
> 
> Nice work. All three patches looks fine.  You might want to insert "in
> https://bugs.gnu.org/28054" at the end of each log message.

Good point. I'll adjust.

> Considering the use of "yes | :", even though there's an identical
> prior use in tests/misc/seq-epipe.sh, I wondered if there exists a
> shell/system where that would infloop. Maybe paranoid overkill, but
> inserting a timeout would avoid the possibility.

Also good point, and I vaguely remember there being such an issue
on systems where pipes were simulated using files.
Though timeout would have the same portability issues as such pipes I think.
I'll look at refactoring this pattern in a separate patch
and cater for all uses of this pattern with a
require_regular_pipe_ or equivalent.

thanks,
Pádraig

Message #28 received at 28054 <at> debbugs.gnu.org (full text, mbox):

From: "A. Wilcox" <awilfox <at> adelielinux.org>
To: Jim Meyering <jim <at> meyering.net>, 28054 <at> debbugs.gnu.org,
 Pádraig Brady <P <at> draigbrady.com>
Cc: 28054-done <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Thu, 17 Aug 2017 23:55:18 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 13/08/17 11:22, Jim Meyering wrote:
> On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady <P <at> draigbrady.com>
> wrote:
>> On 11/08/17 11:49, A. Wilcox wrote:
>> 
>>> FAIL: tests/misc/csplit-io-err ==============================
>> This was due to an inconsistency in the errors output by seq. A
>> fix for that buglet is attached.
>> 
>>> FAIL: tests/misc/printf-surprise 
>>> ================================
>> Depending on exit 141 couples the script to the value of SIGPIPE 
>> and to the shell implementation (ksh will return 269 here for
>> e.g.). So I've attached a solution that should hopefully work in
>> all situations.
>> 
>>> FAIL: tests/misc/sort-debug-warn 
>>> ================================
>> This was due to an assumption that for "missing" locales that
>> sort would fail to C rather than C.UTF8. I've adjusted sort to
>> not assume that in the attached.
> 
> Nice work. All three patches looks fine.  You might want to insert
> "in https://bugs.gnu.org/28054" at the end of each log message.
> 
> Considering the use of "yes | :", even though there's an identical 
> prior use in tests/misc/seq-epipe.sh, I wondered if there exists a 
> shell/system where that would infloop. Maybe paranoid overkill,
> but inserting a timeout would avoid the possibility.
> 

I can confirm that seq and printf-surprise are fixed by these patches.
 The sort-debug-warn test still fails, because "failed to set locale"
is not printed on musl (missing locales are redirected to C.UTF8).

Also, the seq-epipe patch fixes the grep but not the comment directly
above it.

Thank you for your efforts and the fixes.

Best,
- --arw

- -- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
http://adelielinux.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZlnMzAAoJEMspy1GSK50UUsIQALmcw3yfChX9yrY/RwGTTKtP
FX3K6h1IoTOh9pQRN3cO/AitUYTrQ0CMF3HyOw1eY41g2Cy7l5uFf36bZuXYOghc
WkWk8K3uuvlvkJbIDbszsVzXkHjhoigAC0mcljORXPrTXCS4CpmcRLlaH/HI0niV
p1pk64dvNJhgdD/O7M9vatj8s0RH86HleWf0Jl87Vl7wBXfPnB5V4Uu9hpCxRWy6
j0pfZpaOmqbAYLxjWDWfOlfJq0BOFKrtTy4SHhUF1r2CG88WVVSpr1RD/bM+SVkr
R9LT/XMXw1tZ82z76AIn2+4KFaunRGhSbOulmhs2yCHORHhgc8jyomSvS8oh47yK
EmMgT//VN6hJsKDBYQ2fkiFvrRd4gbf2tXKU92J1KfewoB23wgHvG1EahiSCFUA5
la9xSIZ4X8IIGIiNnHvooxITITdC8oGct8XaLcBfiHYz2GXihAyI0gX+Sc4gL7PI
uyK9C2/I3Tw6zJslU+lPtCCwGVUpwLH1LWRxy0YAQn8ejI7eOeK6QNvmsX/tJXEf
5NjauAA5Hca4d11Nq6hRZxkTAsEdbvxupvOQ9EcWoRyLqIj2ayaCvP7VuBjrNYLF
huL7oXUGPD81duPaDE1ALPyflG9O70NEmQdXVqv3mLSpkdmbKNzjZZJJ80UV6lXw
eLgWSdw8MIQqXUNYMnmo
=h0SV
-----END PGP SIGNATURE-----

Message #34 received at 28054 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: "A. Wilcox" <awilfox <at> adelielinux.org>, 28054 <at> debbugs.gnu.org
Subject: Re: bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl
Date: Sat, 19 Aug 2017 15:51:05 -0700

On 17/08/17 21:55, A. Wilcox wrote:
> On 13/08/17 11:22, Jim Meyering wrote:
>> On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady <P <at> draigbrady.com>
>> wrote:
>>> On 11/08/17 11:49, A. Wilcox wrote:
>>>
>>>> FAIL: tests/misc/csplit-io-err ==============================
>>> This was due to an inconsistency in the errors output by seq. A
>>> fix for that buglet is attached.
>>>
>>>> FAIL: tests/misc/printf-surprise 
>>>> ================================
>>> Depending on exit 141 couples the script to the value of SIGPIPE 
>>> and to the shell implementation (ksh will return 269 here for
>>> e.g.). So I've attached a solution that should hopefully work in
>>> all situations.
>>>
>>>> FAIL: tests/misc/sort-debug-warn 
>>>> ================================
>>> This was due to an assumption that for "missing" locales that
>>> sort would fail to C rather than C.UTF8. I've adjusted sort to
>>> not assume that in the attached.
> 
>> Nice work. All three patches looks fine.  You might want to insert
>> "in https://bugs.gnu.org/28054" at the end of each log message.
> 
>> Considering the use of "yes | :", even though there's an identical 
>> prior use in tests/misc/seq-epipe.sh, I wondered if there exists a 
>> shell/system where that would infloop. Maybe paranoid overkill,
>> but inserting a timeout would avoid the possibility.
> 
> 
> I can confirm that seq and printf-surprise are fixed by these patches.
>  The sort-debug-warn test still fails, because "failed to set locale"
> is not printed on musl (missing locales are redirected to C.UTF8).
> 
> Also, the seq-epipe patch fixes the grep but not the comment directly
> above it.
> 
> Thank you for your efforts and the fixes.

Ah Assaf already mentioned this musl issue on this list,
and followed up with musl at:
http://www.openwall.com/lists/musl/2016/04/02/1

I've installed a patch to handle these issues at:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=4b5bc54

thanks,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.