GNU bug report logs - #27567
netpbm is not reproducible

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27567 in the body.
You can then email your comments to 27567 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: netpbm is not reproducible
Date: Mon, 3 Jul 2017 21:04:58 +0200

Message #8 received at 27567 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 27567 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.
Date: Mon,  3 Jul 2017 21:08:01 +0200

* gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
---
 gnu/packages/netpbm.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..6b97d7e06 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -109,6 +109,11 @@
    (arguments
     `(#:phases
       (modify-phases %standard-phases
+       (add-after 'unpack 'patch-timestamps
+         (lambda _
+           (substitute* "buildtools/makepointerman"
+             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
+           #t))
        (replace 'configure
          (lambda* (#:key inputs outputs #:allow-other-keys)
            (copy-file "config.mk.in" "config.mk")

Message #11 received at 27567 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 27567 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH v2] gnu: netpbm: Remove timestamps.
Date: Mon,  3 Jul 2017 21:16:38 +0200

* gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
---
 gnu/packages/netpbm.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..652c23aed 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -87,6 +87,9 @@
                 (drop "ppmtopjxl" in "converter/ppm")
 
                 ;; Remove timestamps from the generated code.
+                (substitute* "buildtools/makepointerman"
+                  (("gmctime[(][)]")
+                   "\"Thu Jan 1 00:00:00 1970\""))
                 (substitute* "buildtools/stamp-date"
                   (("^DATE=.*")
                    "DATE=\"Thu Jan 01 00:00:00+0000 1970\"\n")

Message #14 received at 27567 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27567 <at> debbugs.gnu.org
Subject: Re: bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.
Date: Tue, 4 Jul 2017 15:01:56 -0400

[Message part 1 (text/plain, inline)]

On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> ---
>  gnu/packages/netpbm.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..6b97d7e06 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -109,6 +109,11 @@
>     (arguments
>      `(#:phases
>        (modify-phases %standard-phases
> +       (add-after 'unpack 'patch-timestamps
> +         (lambda _
> +           (substitute* "buildtools/makepointerman"
> +             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> +           #t))

Why this particular date instead of the Unix epoch?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 27567 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27567 <at> debbugs.gnu.org
Subject: Re: bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.
Date: Tue, 4 Jul 2017 21:04:00 +0200

Hi Leo,

On Tue, 4 Jul 2017 15:01:56 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
> > * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> > ---
> > +             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> > +           #t))  
> 
> Why this particular date instead of the Unix epoch?

Copy & paste from example. We can use the Unix epoch as well :)

Message #20 received at 27567 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27567 <at> debbugs.gnu.org
Subject: Re: bug#27567: [PATCH v2] gnu: netpbm: Remove timestamps.
Date: Tue, 4 Jul 2017 15:04:42 -0400

[Message part 1 (text/plain, inline)]

On Mon, Jul 03, 2017 at 09:16:38PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
> ---
>  gnu/packages/netpbm.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..652c23aed 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -87,6 +87,9 @@
>                  (drop "ppmtopjxl" in "converter/ppm")
>  
>                  ;; Remove timestamps from the generated code.
> +                (substitute* "buildtools/makepointerman"
> +                  (("gmctime[(][)]")
> +                   "\"Thu Jan 1 00:00:00 1970\""))

I'm not sure what's going on with core-updates: the last evaluation was
aborted.

So, assuming that you can build groff on core-updates with this change
before Hydra builds netpbm on core-updates, LGTM. Once we build
core-updates to that point, we should wait for the next core-updates
cycle.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.