GNU bug report logs - #27143
file-systems: Improve error reporting for ISO9660

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27143 in the body.
You can then email your comments to 27143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: build: Improve error reporting.
Date: Tue, 30 May 2017 11:12:58 +0200

* gnu/build/file-systems.scm (read-iso9660-primary-volume-descriptor):
Improve error reporting.
---
 gnu/build/file-systems.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 17c1182ce..bd6997adc 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -245,7 +245,10 @@ Trailing spaces are trimmed."
   "Find and read the first primary volume descriptor, starting at OFFSET.
    Return #f if not found."
   (let* ((sblock    (read-superblock device offset 2048 iso9660-superblock?))
-         (type-code (if sblock (array-ref sblock 0) 255)))
+         (type-code (if sblock
+                      (array-ref sblock 0)
+                      (error (format #f "Could not read ISO9660 primary
+volume descriptor from ~s" device)))))
     (match type-code
       (255 #f) ; Volume Descriptor Set Terminator.
       (1 sblock) ; Primary Volume Descriptor

Message #8 received at 27143 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27143 <at> debbugs.gnu.org
Subject: Re: bug#27143: [PATCH] gnu: build: Improve error reporting.
Date: Wed, 31 May 2017 17:16:07 +0200

Hi Danny,

The prefix for the subject line should just be “file-systems:”.

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/build/file-systems.scm (read-iso9660-primary-volume-descriptor):
> Improve error reporting.

[...]

>     Return #f if not found."
>    (let* ((sblock    (read-superblock device offset 2048 iso9660-superblock?))
> -         (type-code (if sblock (array-ref sblock 0) 255)))
> +         (type-code (if sblock
> +                      (array-ref sblock 0)
> +                      (error (format #f "Could not read ISO9660 primary
> +volume descriptor from ~s" device)))))

‘format’ misses an argument.

I hadn’t noticed earlier, but we should use:

  (bytevector-u8-ref sblock 0)

instead of ‘array-ref’ (the array API is not appropriate in this
context; in fact it’s rarely appropriate :-)).

Also make sure to indent the ‘if’ arms properly.

OK with these changes, thanks!

Ludo’.

Message #11 received at 27143 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 27143 <at> debbugs.gnu.org
Subject: Re: bug#27143: [PATCH] gnu: build: Improve error reporting.
Date: Wed, 31 May 2017 20:24:48 +0200

Hi Ludo,

On Wed, 31 May 2017 17:16:07 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> The prefix for the subject line should just be “file-systems:”.

OK

> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> 
> > +                      (error (format #f "Could not read ISO9660 primary
> > +volume descriptor from ~s" device)))))  
> 
> ‘format’ misses an argument.

Uh?  Which one does it miss?

> I hadn’t noticed earlier, but we should use:
> 
>   (bytevector-u8-ref sblock 0)

OK!

> Also make sure to indent the ‘if’ arms properly.

OK!

Message #14 received at 27143 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27143 <at> debbugs.gnu.org
Subject: Re: bug#27143: [PATCH] gnu: build: Improve error reporting.
Date: Wed, 31 May 2017 22:41:46 +0200

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> On Wed, 31 May 2017 17:16:07 +0200
> ludo <at> gnu.org (Ludovic Courtès) wrote:
>
>> The prefix for the subject line should just be “file-systems:”.
>
> OK
>
>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>> 
>> > +                      (error (format #f "Could not read ISO9660 primary
>> > +volume descriptor from ~s" device)))))  
>> 
>> ‘format’ misses an argument.
>
> Uh?  Which one does it miss?

Oh sorry, I guess I didn’t have my glasses on.

Ludo’.

Message #23 received at 27143-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27143-done <at> debbugs.gnu.org
Subject: Re: bug#27143: [PATCH] gnu: build: Improve error reporting.
Date: Sat, 03 Jun 2017 16:14:39 +0200

This was pushed as 203a9455c4695152fc5d0085bffeead9ce3216c2, so closing it.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.