GNU bug report logs - #26840
[PATCH 2/3] gnu: go-1.4: Add missing module imports.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26840 in the body.
You can then email your comments to 26840 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergei Trofimovich <slyfox <at> inbox.ru>
To: guix-patches <at> gnu.org
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>
Subject: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Mon,  8 May 2017 20:55:48 +0100

* gnu/packages/golang.scm (go-1.4): Add missing modules to
  %modify-phases call: srfi-1
---
 gnu/packages/golang.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 00630ce06..d19aa65af 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -62,7 +62,8 @@
     (arguments
      `(#:modules ((ice-9 match)
                   (guix build gnu-build-system)
-                  (guix build utils))
+                  (guix build utils)
+                  (srfi srfi-1))
        #:tests? #f ; Tests are run by the all.bash script.
        #:phases
        (modify-phases %standard-phases
-- 
2.12.2

Message #8 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Sergei Trofimovich <slyfox <at> inbox.ru>
Cc: 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Thu, 11 May 2017 15:57:40 -0400

[Message part 1 (text/plain, inline)]

Sergei Trofimovich <slyfox <at> inbox.ru> writes:

> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>   %modify-phases call: srfi-1
> ---
>  gnu/packages/golang.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 00630ce06..d19aa65af 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -62,7 +62,8 @@
>      (arguments
>       `(#:modules ((ice-9 match)
>                    (guix build gnu-build-system)
> -                  (guix build utils))
> +                  (guix build utils)
> +                  (srfi srfi-1))
>         #:tests? #f ; Tests are run by the all.bash script.
>         #:phases
>         (modify-phases %standard-phases

*/me looks at git log and facepalms*

Never mind my other email... I see that the reason these are already on
master is because they were already pushed there. Feel free to close
these!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>, 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Thu, 11 May 2017 23:06:22 +0200

Hi Kei,

> Never mind my other email... I see that the reason these are already on
> master is because they were already pushed there. Feel free to close
> these!

Hehe yeah.  I wonder though:  If I put "Fixes <https://bugs.gnu.org/xxxx>" into the commit log, does that mean that something (a cron job etc) actually marks the bug report as fixed?  How often does that happen?

Message #14 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>, 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Thu, 11 May 2017 17:25:41 -0400

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi Kei,
>
>> Never mind my other email... I see that the reason these are already on
>> master is because they were already pushed there. Feel free to close
>> these!
>
> Hehe yeah.  I wonder though: If I put "Fixes
> <https://bugs.gnu.org/xxxx>" into the commit log, does that mean that
> something (a cron job etc) actually marks the bug report as fixed?
> How often does that happen?

I'm not sure about the log-reading method you describe, but I know that
adding "-done" to the debbugs email closes the bug.

Example: xxxxx <at> debbugs.gnu.org --> xxxxx-done <at> debbugs.gnu.org

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26840 <at> debbugs.gnu.org, Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Thu, 11 May 2017 17:28:41 -0400

[Message part 1 (text/plain, inline)]

On Thu, May 11, 2017 at 11:06:22PM +0200, Danny Milosavljevic wrote:
> Hi Kei,
> 
> > Never mind my other email... I see that the reason these are already on
> > master is because they were already pushed there. Feel free to close
> > these!
> 
> Hehe yeah.  I wonder though:  If I put "Fixes
> <https://bugs.gnu.org/xxxx>" into the commit log, does that mean that
> something (a cron job etc) actually marks the bug report as fixed?
> How often does that happen?

It doesn't happen :)

You have to send mail to the debbugs ticket. For example
<12345-done <at> debbugs.gnu.org>, where 12345 is the bug number.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>,
 Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26840 <at> debbugs.gnu.org, Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 00:19:40 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Thu, May 11, 2017 at 11:06:22PM +0200, Danny Milosavljevic wrote:
>> Hi Kei,
>> 
>> > Never mind my other email... I see that the reason these are already on
>> > master is because they were already pushed there. Feel free to close
>> > these!
>> 
>> Hehe yeah.  I wonder though:  If I put "Fixes
>> <https://bugs.gnu.org/xxxx>" into the commit log, does that mean that
>> something (a cron job etc) actually marks the bug report as fixed?
>> How often does that happen?
>
> It doesn't happen :)
>
> You have to send mail to the debbugs ticket. For example
> <12345-done <at> debbugs.gnu.org>, where 12345 is the bug number.

Alternatively, email control <at> debbugs.gnu.org with "close 12345".

I see it also takes a "version" parameter, e.g. "close 12345 aaabbbccc".

https://debbugs.gnu.org/server-control.html

Useful if you don't want to spam list subscribers with an empty message.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26840 <at> debbugs.gnu.org, Kei Kebreau <kei <at> openmailbox.org>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 00:29:37 +0200

On Fri, 12 May 2017 00:19:40 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:
> Alternatively, email control <at> debbugs.gnu.org with "close 12345".
> 
> I see it also takes a "version" parameter, e.g. "close 12345 aaabbbccc".

Nice!

I wonder whether it would be possible to have an auto-closer job?

I think it's not really useful to have to specify that the bug is fixed twice - once in the commit message and once in the bug report.

If we wanted to automate it, who could we ask about it?

Message #28 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 26840 <at> debbugs.gnu.org,
 Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 00:26:49 -0400

On Fri, May 12, 2017 at 12:29:37AM +0200, Danny Milosavljevic wrote:
> I think it's not really useful to have to specify that the bug is
> fixed twice - once in the commit message and once in the bug report.

Are we mentioning the guix-patches bugs in commit messages? I thought it
was just for the items from bug-guix.

Message #31 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>, 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 23:52:02 +0200

Hi Kei,

Kei Kebreau <kei <at> openmailbox.org> skribis:

> Sergei Trofimovich <slyfox <at> inbox.ru> writes:
>
>> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>>   %modify-phases call: srfi-1
>> ---
>>  gnu/packages/golang.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>> index 00630ce06..d19aa65af 100644
>> --- a/gnu/packages/golang.scm
>> +++ b/gnu/packages/golang.scm
>> @@ -62,7 +62,8 @@
>>      (arguments
>>       `(#:modules ((ice-9 match)
>>                    (guix build gnu-build-system)
>> -                  (guix build utils))
>> +                  (guix build utils)
>> +                  (srfi srfi-1))
>>         #:tests? #f ; Tests are run by the all.bash script.
>>         #:phases
>>         (modify-phases %standard-phases
>
> */me looks at git log and facepalms*
>
> Never mind my other email... I see that the reason these are already on
> master is because they were already pushed there. Feel free to close
> these!

Though as discussed in another thread with Sergei, it’s not entirely
clear to me that these #:modules patches should be committed (and they
are for ‘core-updates’, not ‘master’.)

I would rather see whether we can find a more generic solution to this
problem before patching every single instance.

How does that sound?

Ludo’.

Message #34 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>, 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 19:05:22 -0400

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> Sergei Trofimovich <slyfox <at> inbox.ru> writes:
>>
>>> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>>>   %modify-phases call: srfi-1
>>> ---
>>>  gnu/packages/golang.scm | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>>> index 00630ce06..d19aa65af 100644
>>> --- a/gnu/packages/golang.scm
>>> +++ b/gnu/packages/golang.scm
>>> @@ -62,7 +62,8 @@
>>>      (arguments
>>>       `(#:modules ((ice-9 match)
>>>                    (guix build gnu-build-system)
>>> -                  (guix build utils))
>>> +                  (guix build utils)
>>> +                  (srfi srfi-1))
>>>         #:tests? #f ; Tests are run by the all.bash script.
>>>         #:phases
>>>         (modify-phases %standard-phases
>>
>> */me looks at git log and facepalms*
>>
>> Never mind my other email... I see that the reason these are already on
>> master is because they were already pushed there. Feel free to close
>> these!
>
> Though as discussed in another thread with Sergei, it’s not entirely
> clear to me that these #:modules patches should be committed (and they
> are for ‘core-updates’, not ‘master’.)
>
> I would rather see whether we can find a more generic solution to this
> problem before patching every single instance.
>
> How does that sound?
>
> Ludo’.

I have no objections. Should the patches already on master be reverted,
or should they be left until further notice?

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 26840 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>, 26840 <at> debbugs.gnu.org
Subject: Re: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Sat, 13 May 2017 15:08:53 +0200

Kei Kebreau <kei <at> openmailbox.org> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Hi Kei,
>>
>> Kei Kebreau <kei <at> openmailbox.org> skribis:
>>
>>> Sergei Trofimovich <slyfox <at> inbox.ru> writes:
>>>
>>>> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>>>>   %modify-phases call: srfi-1
>>>> ---
>>>>  gnu/packages/golang.scm | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>>>> index 00630ce06..d19aa65af 100644
>>>> --- a/gnu/packages/golang.scm
>>>> +++ b/gnu/packages/golang.scm
>>>> @@ -62,7 +62,8 @@
>>>>      (arguments
>>>>       `(#:modules ((ice-9 match)
>>>>                    (guix build gnu-build-system)
>>>> -                  (guix build utils))
>>>> +                  (guix build utils)
>>>> +                  (srfi srfi-1))
>>>>         #:tests? #f ; Tests are run by the all.bash script.
>>>>         #:phases
>>>>         (modify-phases %standard-phases
>>>
>>> */me looks at git log and facepalms*
>>>
>>> Never mind my other email... I see that the reason these are already on
>>> master is because they were already pushed there. Feel free to close
>>> these!
>>
>> Though as discussed in another thread with Sergei, it’s not entirely
>> clear to me that these #:modules patches should be committed (and they
>> are for ‘core-updates’, not ‘master’.)
>>
>> I would rather see whether we can find a more generic solution to this
>> problem before patching every single instance.
>>
>> How does that sound?
>>
>> Ludo’.
>
> I have no objections. Should the patches already on master be reverted,
> or should they be left until further notice?

We can leave them, but let’s not push more without further thought.  :-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.