GNU bug report logs - #26813
[PATCH] re2: add missing '#:modules' imports

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26813 in the body.
You can then email your comments to 26813 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergei Trofimovich <slyfox <at> inbox.ru>
To: guix-patches <at> gnu.org
Cc: Sergei Trofimovich <slyfox <at> inbox.ru>
Subject: [PATCH] re2: add missing '#:modules' imports
Date: Sun,  7 May 2017 11:48:37 +0100

Noticed as a 're2' build failure:

/gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
to match any pattern in form (%modify-phases phases* (delete (quote configure)))

* gnu/packages/regex.scm (re2): add missing '#:modules' imports

Signed-off-by: Sergei Trofimovich <slyfox <at> inbox.ru>
---
 gnu/packages/regex.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/regex.scm b/gnu/packages/regex.scm
index f55faaf04..779050525 100644
--- a/gnu/packages/regex.scm
+++ b/gnu/packages/regex.scm
@@ -41,7 +41,10 @@
                  "1s3kdcrz2mwi30k6pz9jkv5vk8b704bz65xgcr67wbn2pn3hpnqr"))))
      (build-system gnu-build-system)
      (arguments
-      `(#:test-target "test"
+      `(#:modules ((guix build gnu-build-system)
+                   (guix build utils)
+                   (srfi srfi-1))
+        #:test-target "test"
         ;; There is no configure step, but the Makefile respects a prefix.
         ;; As ./configure does not know anything about the target CXX
         ;; we need to specify TARGET-g++ explicitly.
-- 
2.12.2

Message #10 received at 26813-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Sergei Trofimovich <slyfox <at> inbox.ru>
Cc: 26813-done <at> debbugs.gnu.org
Subject: Re: bug#26813: [PATCH] re2: add missing '#:modules' imports
Date: Sun, 7 May 2017 14:21:29 -0400

[Message part 1 (text/plain, inline)]

On Sun, May 07, 2017 at 11:48:37AM +0100, Sergei Trofimovich wrote:
> Noticed as a 're2' build failure:
> 
> /gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
> to match any pattern in form (%modify-phases phases* (delete (quote configure)))
> 
> * gnu/packages/regex.scm (re2): add missing '#:modules' imports
> 
> Signed-off-by: Sergei Trofimovich <slyfox <at> inbox.ru>

Pushed by Danny as 7a4a64e99e65e96a4dc3e65ae691b4c80b7642e8.

Sergei, we use the signed-off-by line to make it easier to see when
somebody has pushed a patch to Savannah on behalf of somebody else
(other projects use it in a variety of different ways). In this case,
Danny signed off on the commit for you. So, no need to sign off on your
Guix contributions :)

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 26813-done <at> debbugs.gnu.org (full text, mbox):

From: Sergei Trofimovich <slyfox <at> inbox.ru>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26813-done <at> debbugs.gnu.org
Subject: Re: bug#26813: [PATCH] re2: add missing '#:modules' imports
Date: Sun, 7 May 2017 20:49:31 +0100

[Message part 1 (text/plain, inline)]

On Sun, 7 May 2017 14:21:29 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> Sergei, we use the signed-off-by line to make it easier to see when
> somebody has pushed a patch to Savannah on behalf of somebody else
> (other projects use it in a variety of different ways). In this case,
> Danny signed off on the commit for you. So, no need to sign off on your
> Guix contributions :)

Got it. Thanks!

-- 

  Sergei

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.