GNU bug report logs - #26123
guile-2.2.0: AI_ADDRCONFIG

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26123 in the body.
You can then email your comments to 26123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Klausner <tk <at> giga.or.at>
To: bug-guile <at> gnu.org
Cc: Greg Troxel <gdt <at> lexort.com>
Subject: guile-2.2.0: AI_ADDRCONFIG
Date: Thu, 16 Mar 2017 10:29:18 +0100

Hi!

When compiling guile-2.2.0 on NetBSD_7.99.65/amd64, I see:


  SNARF  net_db.doc
net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:

Compilation continues even though this looks like an error.
 Thomas

Message #8 received at 26123 <at> debbugs.gnu.org (full text, mbox):

From: <dsmich <at> roadrunner.com>
To: 26123 <at> debbugs.gnu.org
Subject: Re: bug#26123: guile-2.2.0: AI_ADDRCONFIG
Date: Fri, 17 Mar 2017 9:11:45 -0400

---- Thomas Klausner <tk <at> giga.or.at> wrote: 
> 
>   SNARF  net_db.doc
> net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
> net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
> 
> Compilation continues even though this looks like an error.

Yeah,  while annoying, this is harmless.

The proper fix in my opinion is to limit the regular expression on line 28 in libguile/guile-func-name-check to only match function definition macros.  Currently, it matches other macros that define things other than functions, and so erroneously looks for a function body.

For example, adding a space like /^SCM_DEFINE / would probably be appropriate.  However, that would prevent it from matching any other function defining macros, if they exist.

-Dale
 

Message #13 received at 26123-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: <dsmich <at> roadrunner.com>
Cc: 26123-done <at> debbugs.gnu.org
Subject: Re: bug#26123: guile-2.2.0: AI_ADDRCONFIG
Date: Wed, 19 Apr 2017 16:50:18 +0200

On Fri 17 Mar 2017 14:11, <dsmich <at> roadrunner.com> writes:

> ---- Thomas Klausner <tk <at> giga.or.at> wrote: 
>> 
>>   SNARF  net_db.doc
>> net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
>> net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
>> 
>> Compilation continues even though this looks like an error.
>
> Yeah,  while annoying, this is harmless.
>
> The proper fix in my opinion is to limit the regular expression on line
> 28 in libguile/guile-func-name-check to only match function definition
> macros.  Currently, it matches other macros that define things other
> than functions, and so erroneously looks for a function body.
>
> For example, adding a space like /^SCM_DEFINE / would probably be appropriate.  However, that would prevent it from matching any other function defining macros, if they exist.

Good idea, done.  Thanks :)

ANdy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.