GNU bug report logs - #25821
grep-3.0 FAILS on Make phase

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25821 in the body.
You can then email your comments to 25821 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rennes <at> openmailbox.org
To: bug-grep <at> gnu.org
Subject: grep-3.0 FAILS on Make phase
Date: Mon, 20 Feb 2017 16:12:32 -0600

[Message part 1 (text/plain, inline)]

Hello,
I´m trying to build 'grep' version 3.0 on Hurd system through Guix 
package manager, in the 'Make' phase i´ve the error:

/-------------------------------------------------------------/
 CC       localcharset.o
  CC       glthread/lock.o
glthread/lock.c: In function 'glthread_rwlock_init_for_glibc':
glthread/lock.c:53:3: warning: implicit declaration of function 
'pthread_rwlockattr_setkind_np' [-Wimplicit-function-declaration]
   err = pthread_rwlockattr_setkind_np (&attributes,
   ^
glthread/lock.c:54:40: error: 
'PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP' undeclared (first use in 
this function)
                                        
PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP);
                                        ^
glthread/lock.c:54:40: note: each undeclared identifier is reported only 
once for each function it appears in
Makefile:1711: recipe for target 'glthread/lock.o' failed
make[3]: *** [glthread/lock.o] Error 1
make[3]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0/lib'
Makefile:1478: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0/lib'
Makefile:1291: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0'
Makefile:1232: recipe for target 'all' failed
make: *** [all] Error 2
phase `build' failed after 5.3 seconds
/-------------------------------------------------------------/

Any ideas that can help me to understand the error?

Attached environment variables file and build log file.
Thanks

[config.log (text/plain, attachment)]

[environment-variables (text/plain, attachment)]

Message #10 received at 25821-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: rennes <at> openmailbox.org, Bruno Haible <bruno <at> clisp.org>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, 25821-done <at> debbugs.gnu.org
Subject: Re: bug#25821: grep-3.0 FAILS on Make phase
Date: Mon, 20 Feb 2017 16:35:23 -0800

Thanks for the bug report <https://bugs.gnu.org/25821>. I'm forwarding this to 
bug-gnulib, as it is apparently a bug in the Gnulib lock module's implementation 
on the Hurd.

This bug does not affect grep per se, as it's a Gnulib test-harness bug and not 
a Grep bug. I'm therefore closing the Grep bug report.

> I´m trying to build 'grep' version 3.0 on Hurd system through Guix package
> manager, in the 'Make' phase i´ve the error:
>
> /-------------------------------------------------------------/
>  CC       localcharset.o
>   CC       glthread/lock.o
> glthread/lock.c: In function 'glthread_rwlock_init_for_glibc':
> glthread/lock.c:53:3: warning: implicit declaration of function
> 'pthread_rwlockattr_setkind_np' [-Wimplicit-function-declaration]
>    err = pthread_rwlockattr_setkind_np (&attributes,
>    ^
> glthread/lock.c:54:40: error: 'PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP'
> undeclared (first use in this function)
>
> PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP);
>                                         ^
> glthread/lock.c:54:40: note: each undeclared identifier is reported only once
> for each function it appears in
> Makefile:1711: recipe for target 'glthread/lock.o' failed
> make[3]: *** [glthread/lock.o] Error 1
> make[3]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0/lib'
> Makefile:1478: recipe for target 'all' failed
> make[2]: *** [all] Error 2
> make[2]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0/lib'
> Makefile:1291: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/tmp/guix-build-grep-3.0.drv-0/grep-3.0'
> Makefile:1232: recipe for target 'all' failed
> make: *** [all] Error 2
> phase `build' failed after 5.3 seconds
> /-------------------------------------------------------------/
>
> Any ideas that can help me to understand the error?
>
> Attached environment variables file and build log file.
> Thanks

Message #13 received at 25821-done <at> debbugs.gnu.org (full text, mbox):

From: rennes <at> openmailbox.org
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, Bruno Haible <bruno <at> clisp.org>,
 25821-done <at> debbugs.gnu.org
Subject: Re: bug#25821: grep-3.0 FAILS on Make phase
Date: Mon, 20 Feb 2017 18:39:11 -0600

Hi,
Thank you for the quick response, I will keep an eye on the response of 
gnulib team.

On 2017-02-20 18:35, Paul Eggert wrote:
> Thanks for the bug report <https://bugs.gnu.org/25821>. I'm forwarding
> this to bug-gnulib, as it is apparently a bug in the Gnulib lock
> module's implementation on the Hurd.
> 
> This bug does not affect grep per se, as it's a Gnulib test-harness
> bug and not a Grep bug. I'm therefore closing the Grep bug report.
> 

Message #16 received at 25821-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: rennes <at> openmailbox.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, Gnulib bugs <bug-gnulib <at> gnu.org>,
 25821-done <at> debbugs.gnu.org
Subject: Re: bug#25821: grep-3.0 FAILS on Make phase
Date: Tue, 21 Feb 2017 17:10:43 +0100

Hi Rene,

> > glthread/lock.c:54:40: error: 'PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP'
> > undeclared (first use in this function)
> >
> > PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP);
> >                                         ^

Thanks for the report. Fixed in gnulib as follows:


2017-02-21  Bruno Haible  <bruno <at> clisp.org>

	lock tests: Fix build failure on GNU/Hurd (regression from 2017-01-05).
	Reported by Rene Saavedra <rennes <at> openmailbox.org> in
	https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25821 via Paul Eggert.
	* lib/glthread/lock.h: On glibc systems without
	PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP, use the fallback
	implementation of rwlocks.
	* lib/glthread/lock.c: Likewise.

diff --git a/lib/glthread/lock.c b/lib/glthread/lock.c
index 061562b..afc86f4 100644
--- a/lib/glthread/lock.c
+++ b/lib/glthread/lock.c
@@ -30,7 +30,7 @@
 
 /* ------------------------- gl_rwlock_t datatype ------------------------- */
 
-# if HAVE_PTHREAD_RWLOCK && (HAVE_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER || (__GNU_LIBRARY__ > 1))
+# if HAVE_PTHREAD_RWLOCK && (HAVE_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER || (defined PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP && (__GNU_LIBRARY__ > 1)))
 
 #  ifdef PTHREAD_RWLOCK_INITIALIZER
 
diff --git a/lib/glthread/lock.h b/lib/glthread/lock.h
index ec16d39..67932aa 100644
--- a/lib/glthread/lock.h
+++ b/lib/glthread/lock.h
@@ -179,7 +179,7 @@ typedef pthread_mutex_t gl_lock_t;
 
 /* ------------------------- gl_rwlock_t datatype ------------------------- */
 
-# if HAVE_PTHREAD_RWLOCK && (HAVE_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER || (__GNU_LIBRARY__ > 1))
+# if HAVE_PTHREAD_RWLOCK && (HAVE_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER || (defined PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP && (__GNU_LIBRARY__ > 1)))
 
 #  ifdef PTHREAD_RWLOCK_INITIALIZER
 

Message #19 received at 25821-done <at> debbugs.gnu.org (full text, mbox):

From: rennes <at> openmailbox.org
To: Bruno Haible <bruno <at> clisp.org>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, Gnulib bugs <bug-gnulib <at> gnu.org>,
 25821-done <at> debbugs.gnu.org
Subject: Re: bug#25821: grep-3.0 FAILS on Make phase
Date: Tue, 21 Feb 2017 12:14:55 -0600

Hello Bruno,
thanks for the fix, now 'grep' built successfully.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.